1380021 - Tests for showing the Page Action device sub-menu have a 5 second waits in them

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Mark Banner (:standard8)]

In moving some code in bug 1380009, we discovered that bug 1369095 added a 5 second timeout to parts of tests that are waiting for the device sub-menu to be displayed:

http://searchfox.org/mozilla-central/rev/5dadcbe55b4ddd1e448c06c77390ff6483aa009b/browser/base/content/test/urlbar/browser_page_action_menu.js#436

(as of bug 1380009 landing, that is moving to the head.js file).

If I run the tests manually (MacBook Pro mid-2015), I can see that occasionally the device sub-menu is opened and then after a second or so it changes size, before the test then continues.

This seems like it is could be a glitch that users will see, hence flagging as possible photon work.

Comment 1

[:Gijs (he/him)]

I think the glitching is basically bug 1374509. The 5 seconds isn't when the relayout happens that you noticed here:

(In reply to Mark Banner (:standard8) from comment #0)
> If I run the tests manually (MacBook Pro mid-2015), I can see that
> occasionally the device sub-menu is opened and then after a second or so it
> changes size, before the test then continues.

the timeout is related to when the item populates because of delayed sync initialization on startup and ensuring that's finished (for which apparently there isn't a useful event).

Comment 2

[:Gijs (he/him)]

Drew is fixing this in bug 1384464, I believe.

Comment 3

[Drew Willcoxon :adw]

Bug 1384464 fixed browser_page_action_menu.js (let's hope it sticks and actually works), but browser_PageActions.js still has a 5000ms timeout: https://dxr.mozilla.org/mozilla-central/rev/ffe6cc09ccf38cca6f0e727837bbc6cb722d1e71/browser/modules/test/browser/browser_PageActions.js#1031

I think that's the only other one that needs fixing.

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1380021 - Remove 5000ms timeout from browser_PageActions.js test.

Review commit: https://reviewboard.mozilla.org/r/181526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181526/

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b013a4d06c7

Comment 6

[Drew Willcoxon :adw]

A bunch of en-US failures... not sure what that's about.  Bad tree I guess.  But other than that, try looks OK.

Comment 7

[:Gijs (he/him)]

Comment on attachment 8910052 [details]
Bug 1380021 - Remove 5000ms timeout from browser_PageActions.js test.

https://reviewboard.mozilla.org/r/181526/#review187024

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c613a3d09cc1
Remove 5000ms timeout from browser_PageActions.js test. r=Gijs

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c613a3d09cc1