Closed Bug 1368332 Opened 2 years ago Closed 2 years ago

Intermittent browser/components/extensions/test/browser/browser_ext_devtools_panel.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: aryx, Assigned: rpl)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing])

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=102638253&repo=mozilla-inbound

[task 2017-05-28T06:49:52.794247Z] 06:49:52     INFO - Wait until the Addon Devtools Panel has been loaded - after visibilityswitch toggled
[task 2017-05-28T06:49:52.796407Z] 06:49:52     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panel.js | Got the same devtools.inspectedWindow.tabId from devtools panel after visibility toggled - 
[task 2017-05-28T06:49:52.799477Z] 06:49:52     INFO - Addon Devtools Panel hidden - after visibilityswitch toggled
[task 2017-05-28T06:49:52.801552Z] 06:49:52     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panel.js | devtools.panel.create callback has been called once - 
[task 2017-05-28T06:49:52.805157Z] 06:49:52     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panel.js | panel.onShown listener has been called three times - 
[task 2017-05-28T06:49:52.807322Z] 06:49:52     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_devtools_panel.js | panel.onHidden listener has been called three times - 
[task 2017-05-28T06:49:52.809399Z] 06:49:52     INFO - Buffered messages logged at 06:49:51
[task 2017-05-28T06:49:52.813452Z] 06:49:52     INFO - Leaving test bound test_devtools_page_panels_create
[task 2017-05-28T06:49:52.815489Z] 06:49:52     INFO - Buffered messages finished
[task 2017-05-28T06:49:52.817904Z] 06:49:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_devtools_panel.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
Priority: -- → P5
We have 37 failures in the past 7 days.
Platforms: windows10-64-ccov debug, Linux x64 and Linux debug.
Recent log failure: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=173136689&lineNumber=8584

Relevant part of the log: [task 2018-04-11T17:51:49.967Z] 17:51:49     INFO - Buffered messages finished
[task 2018-04-11T17:51:49.969Z] 17:51:49     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_devtools_panel.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2018-04-11T17:51:49.970Z] 17:51:49     INFO - TEST-FAIL | browser/components/extensions/test/browser/browser_ext_devtools_panel.js | Assertion count 4 is greater than expected range 0-0 assertions. - 
[task 2018-04-11T17:51:49.976Z] 17:51:49     INFO - GECKO(1049) | MEMORY STAT | vsize 1292MB | residentFast 464MB | heapAllocated 151MB
[task 2018-04-11T17:51:49.977Z] 17:51:49     INFO - TEST-OK | browser/components/extensions/test/browser/browser_ext_devtools_panel.js | took 105199ms
[task 2018-04-11T17:51:49.978Z] 17:51:49     INFO - GECKO(1049) | ++DOCSHELL 0xe2402400 == 1 [pid = 1097] [id = {6c88c913-54cc-4a50-b46c-fff4c13c598f}]
[task 2018-04-11T17:51:49.979Z] 17:51:49     INFO - GECKO(1049) | ++DOMWINDOW == 2 (0xe2455080) [pid = 1097] [serial = 121] [outer = (nil)]
[task 2018-04-11T17:51:49.981Z] 17:51:49     INFO - GECKO(1049) | ++DOMWINDOW == 3 (0xe2404800) [pid = 1097] [serial = 122] [outer = 0xe2455080]
[task 2018-04-11T17:51:49.982Z] 17:51:49     INFO - checking window state

:ddurst can you please take a look here?
Flags: needinfo?(ddurst)
Whiteboard: [stockwell needswork:owner]
Luca, can you please take a look at this? It's been failing a lot since bug 1394750 landed.
Blocks: 1394750
Flags: needinfo?(lgreco)
add another 15 failures to last week from bug 1453570.  This is on a fast track to be disabled.
(In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked) from comment #21)
> Luca, can you please take a look at this? It's been failing a lot since bug
> 1394750 landed.

Yes absolutely, I'm looking into it. 

I briefly looked into the failures logs and all of them seems to timeout while all the test cases are completed
and the test file is exiting (and most of them are on linux32 debug, and all of them are on debug builds).

In Bug 1394750 I've split one of that test case and added an additional round cycle
of "toolbox close and re-open" as part of verifying the behaviors expected by the devtools page/panel when they
are toggled by the user from the toolbox options panel, and those are likely the reason why this test file is
taking longer to run.

(In the meantime I'm not clearing the needinfo assigned to me yet, until I've attached a patch which fix this high intermittency issue).
Flags: needinfo?(ddurst)
Comment on attachment 8968254 [details]
Bug 1368332 - Request a longer test timeout for the browser_ext_devtools_panel test file.

https://reviewboard.mozilla.org/r/236936/#review242730
Attachment #8968254 - Flags: review?(aswan) → review+
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Flags: needinfo?(lgreco)
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/2f01bf0dc41a
Request a longer test timeout for the browser_ext_devtools_panel test file. r=aswan
https://hg.mozilla.org/mozilla-central/rev/2f01bf0dc41a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Whiteboard: [stockwell disable-recommended] → [stockwell fixed:timing]
Flags: qe-verify-
Flags: in-testsuite-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.