136835 - file bookmark dialog window resizes itself after every use from with 2 or more tabs open from the browser menus

Status: RESOLVED DUPLICATE of bug 123207

(SeaMonkey :: Bookmarks & History, defect)

Description

[[not reading bugmail]]

this is a problem from the patch for the bookmark groups UI in bug 119599.  

Problem:

If you close all the open tabs so you only have 1, the original 'non group
folder UI' dialog does persist its size you adjusted it to in step one, and does
not come up as the default size.

If you are into filing a lot of bookmarks.. and always have 2 tabs or more it
shows the 'Group Folder UI dialog' which happens to be the default size each and
every time even after you adjust it, not persisting the size you adjusted it
to.. this gets real annoying.

--

Jag's note: 

the problem I tried to solve was that if the dialog is persisted
in the default size, and then brought up in the "file as group" version, the OK
and Cancel button are pushed partially outside the dialog.

I guess I could store the current width and height in e.g. addgroupheight and
addgroupwidth attributes on window and set height and width to those on dialog
open in the addGroup mode.

Note that for the normal case (just one tab open) nothing should have changed.




----pasting my comment from bug 119599 comment #52 ----

Explaining in detail: 

If you have 1 tab/page in the browser and open file bookmark dialog the first
time, you then want to adjust the window to a new size you like based on the
root level bookmark view.   If I do adjust it and hit [OK] or [x] it will
persist its size upon reuse.  Now if I open a new tab so I have 2, I want to
file a 
new bookmark from either tab, I hit file dialog.., it opens to default
size.  (I think at this step it should of been persisted from the last instance)   

- so your saying that the buttons will be off the dialog because you're adding a
few lines at the top is the reason for choosing the default size here, so that
isn't garbled.  

Question 1) 

Is there a way to remove the same amount of 'create in folder' box space above
the buttons here while adding in the lines to the top at the same time?

Solution 1) 

If so, then size could be persisted globably.. and adjust as needed much like
other UI items in Mozilla.

Solution 2)

- I believe you're saying this is probably possible to persist the dialog size
instead of reseting it everytime by adding height and width attributes.  This
would also be a good solution. 

So could you then create a seperate persisted size based upon the added UI and
checkbox dialog state, you are saving two sizes, 1 for 1 tab, and 1 for 2 or
more tabs.

Solution 3) 

I guess another solution maybe to move the [ok] and [cancel] buttons up to the
right side under the [new folder] and [default] buttons.


Also see related bug 123207 for file Dialog and Bookmark Manager.

Comment 1

[[not reading bugmail]]

cc'ing Jag. adding nomination based on bug 119599.

Comment 2

[[not reading bugmail]]

Jag, I finally understand what you did say in your comment before I started
asking all the long explainations and questions.., I mis-understood, for some
reason I was getting all caught up in the fact that I didn't think you
understood..  So I see a little too late from the last line from your comment
there.. *(nothing should have changed part with one tab for the default case)* 
Geez, I kill myself sometimes.. :(  Anyway... 

Comment 3

[Peter Trudelle]

nsbeta1+/adt3 per Nav triage team.

Comment 4

[André Dahlqvist]

Seeing this with 2002-04-17-11 on Linux from the 1.0 branch.

OS->All

Comment 5

[Peter Trudelle]

Mass moving nsbeta1+/adt3 bugs assigned to Navigator team engineers out to
target milestone 1.0.1.  Please confine your attentions to driving down our list
of TM 1.0 bugs for beta.  Better to help, debug, or test one of them than fix
one of these.

Comment 6

[Rainer Bielefeld]

I believe, bug 136835 or bug 123207 shold be marked as DUP of the other one

Comment 7

[WD]

*** This bug has been marked as a duplicate of 123207 ***

Comment 8

[[not reading bugmail]]

this is not a dupe.. this is for the file bookmark problem with bookmark groups
and mmore than 1 tab open..  it is seperate code from the file bookmark dialog
off the bookmark manager menus.. 

Comment 9

[[not reading bugmail]]

updating summary : add browser

Comment 10

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 11

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 12

[André Dahlqvist]

*** Bug 138913 has been marked as a duplicate of this bug. ***

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment #8 is wrong -- this is in fact exactly the same dialog.  See
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarksOverlay.js#866
and
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarks.xml#1603



*** This bug has been marked as a duplicate of 123207 ***

Comment 14

[[not reading bugmail]]

Boris, regarding comment #8, If you're saying that the bug 123207 will fix both
the horizontal and vertical resizing when it is fixed from the "bookmark
manager" menu versus from the pull down menu and from the personal toolbar
dialog then I would agree that I've created a dupe of my own bug.  From what I
can tell is that there is either the 3 dialogs start from a seperate code path
and the prelogic before the dialog code gets executed in the bookmarks.xml and
overlay files has the problem then between the two areas of the program and some
logic doesn't seem to execute the persisted size correctly when traveling down
the 3 code paths of execute logic and therefore I found a difference between
these two bugs.  I think its time for me to break out the VC++ I found cheap
here. :)

I would like to see that "file at group" checkbox bug changes backed out now
that we have a option in Bookmark Menu to File as a group.  I hope the other bug
with neals patch really fixes this problem.