1368487 - Make layout/reftests/abs-pos/scrollframe-1.html pass on linux64-qr with APZ enabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

With WR+APZ enabled, there are a bunch of reftest failures [1]. The first one is layout/reftests/abs-pos/scrollframe-1.html. I investigated and it turned out to be because of a bug in my code to set up the scroll layers in WR.

In particular, when pushing a scrolling clip, both the content rect and clip rect are supposed to be relative to the enclosing stacking context. However, the value we are passing generally has 0,0 for the origin of the content rect, which is not what webrender wants. (I say "generally" because I didn't check what happens in RTL pages, it might be different).

Anyway, fixing that makes this reftest pass along with the following other reftests:

layout/reftests/abs-pos/scrollframe-2.html
layout/reftests/async-scrolling/element-1.html
layout/reftests/async-scrolling/iframe-1.html
layout/reftests/async-scrolling/nested-1.html
layout/reftests/async-scrolling/nested-2.html
layout/reftests/async-scrolling/split-layers-1.html
layout/reftests/async-scrolling/split-layers-multi-scrolling-1.html
layout/reftests/async-scrolling/culling-1.html
layout/reftests/async-scrolling/offscreen-prerendered-active-opacity.html
layout/reftests/bugs/580863-1.html
layout/reftests/bugs/825999.html
layout/reftests/forms/input/number/number-similar-to-text-unthemed-vertical-lr.html
layout/reftests/forms/input/text/size-1.html
layout/reftests/image-element/element-paint-native-widget.html
layout/reftests/scrolling/scroll-behavior-2.html
layout/reftests/scrolling/scroll-behavior-3.html 
layout/reftests/scrolling/scroll-behavior-4.html 
layout/reftests/scrolling/scroll-behavior-5.html
layout/reftests/scrolling/scroll-behavior-6.html 
layout/reftests/scrolling/scroll-behavior-8.html
layout/reftests/scrolling/iframe-scrolling-attr-2.html

It also made a couple of tests start failing but overall this seems like progress. 

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=88dd3e8d7ff18be6cf8aa3dd9606f64e889a2b37

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1368487 - Add some default-disabled logging functionality to WebRenderAPI.cpp

Review commit: https://reviewboard.mozilla.org/r/143864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143864/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1368487 - Fix content rect passed to scroll layers to be relative to the right thing.

Review commit: https://reviewboard.mozilla.org/r/143866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143866/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8872373 [details]
Bug 1368487 - Add some default-disabled logging functionality to WebRenderAPI.cpp

https://reviewboard.mozilla.org/r/143864/#review147604

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8872374 [details]
Bug 1368487 - Fix content rect passed to scroll layers to be relative to the right thing.

https://reviewboard.mozilla.org/r/143866/#review147606

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/036bb5908450
Add some default-disabled logging functionality to WebRenderAPI.cpp r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/cd4f49d7d26e
Fix content rect passed to scroll layers to be relative to the right thing. r=jrmuizel

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/036bb5908450
https://hg.mozilla.org/mozilla-central/rev/cd4f49d7d26e