1339474 - (wr-apz) [meta] APZ in QuantumRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

This is a metabug to track the work needed to get APZ up and running in QuantumRender builds.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I have a patch queue that in theory pushes scroll metadata and hit testing information over to APZ. I'll split it into a separate bug but linking it here for now: https://github.com/staktrace/gecko-dev/commits/wr-apz

Comment 2

[Kartikaya Gupta (email:[e-mail])]

We'll need a WR update including csets 2a21b1a and 48a098f for APZ.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I'd like to turn this on sooner rather than later, even though I haven't fixed all the reftests yet. I've opened bugs for the remaining reftest failures and there's not that many. I'll continue working on them. Given that there's some large-ish changes coming down the pipe (not just upstream WR, but also ethan's no-layers changes) I'd like to make sure we have APZ coverage in automation and can catch regressions easily. I also think it would be worthwhile getting people using APZ in WR so we can catch problems faster.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdd3bdcf54c4d2c589649c0bb53e1ead95437f07

Comment 5

[Kartikaya Gupta (email:[e-mail])]

So the try push is green enough. But running the build locally doesn't produce great results. Loading simple pages is fine but CNN takes a long time and seems to eat my CPU. I'll need to investigate.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Turned out the issues in comment 5 were because I was running a debug build. Opt builds seem to behave much more normally.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1339474 - Enable APZ in QuantumRender builds.

All reftests that are still failing with APZ enabled are annotated with
a bug number that is tracking the fix.

Review commit: https://reviewboard.mozilla.org/r/150566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150566/

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8879287 [details]
Bug 1339474 - Enable APZ in QuantumRender builds.

https://reviewboard.mozilla.org/r/150566/#review155296

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aa71b712379
Enable APZ in QuantumRender builds. r=jrmuizel

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0aa71b712379