Closed
Bug 1368648
Opened 7 years ago
Closed 7 years ago
remove import_script functionality
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: automatedtester, Assigned: automatedtester)
References
Details
Attachments
(1 file)
This is a hangover from B2G and nothing appears to use it anymore. Its not a feature I want us supporting moving forward.
|
||
Comment 1•7 years ago
|
||
The import script feature is actually fairly high quality code and well
tested. I don’t believe it has caused any extra maintenance issues.
I suppose it is not good to accumulate potentially sizeable chunks of JS
in memory, but I would consider it fairly low priority.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8872575 [details]
Bug 1368648: Remove importScript functionality from Marionette
https://reviewboard.mozilla.org/r/144100/#review147884
As I said in my earlier comment, I’m sad to see this go as it is quite excellent code, but I suppose all things must come to an end.
::: commit-message-0daf9:3
(Diff revision 2)
> +This removes importScript functionality that was used extensively for B2G testing
> +but is no longer used in tree.
This should be wrapped at ~72 characters.
Attachment #8872575 -
Flags: review?(ato) → review+
| Comment hidden (mozreview-request) |
Pushed by dburns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0710e3c80efa
Remove importScript functionality from Marionette r=ato
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•