1370857 - Remove Marionette.clear_imported_scripts API

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

The import script functionality was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1368648, but the Marionette.clear_imported_script API was not removed from the client.

We are currently making calls after every test (!) to the clearImportedScripts command in the server, but we are apparently ignoring the ‘unknown command’ error that is being returned.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1370857 - Remove Marionette.clear_imported_scripts API;

The import script functionality was removed in
https://bugzilla.mozilla.org/show_bug.cgi?id=1368648, but the
Marionette.clear_imported_script API was not removed from the client.

We are currently making calls after every test to the clearImportedScripts
command in the server, but we are apparently ignoring the ‘unknown
command’ error that is being returned.

Review commit: https://reviewboard.mozilla.org/r/146660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146660/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1370857 - Remove Marionette.import_script API;

Removes the Marionette.import_script API as it is not used by any
consumers of the client, including the Firefox UI tests.

Review commit: https://reviewboard.mozilla.org/r/146662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146662/

Comment 3

[David Burns :automatedtester]

Comment on attachment 8875265 [details]
Bug 1370857 - Remove Marionette.clear_imported_scripts API;

https://reviewboard.mozilla.org/r/146660/#review150720

Comment 4

[David Burns :automatedtester]

Comment on attachment 8875266 [details]
Bug 1370857 - Remove Marionette.import_script API;

https://reviewboard.mozilla.org/r/146662/#review150722

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s e969912ce866 -d 9e2113a451b7: rebasing 400514:e969912ce866 "Bug 1370857 - Remove Marionette.clear_imported_scripts API; r=automatedtester"
merging testing/marionette/client/marionette_driver/marionette.py
merging testing/marionette/harness/marionette_harness/marionette_test/testcases.py
warning: conflicts while merging testing/marionette/harness/marionette_harness/marionette_test/testcases.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8875265 [details]
Bug 1370857 - Remove Marionette.clear_imported_scripts API;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146660/diff/1-2/

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8875266 [details]
Bug 1370857 - Remove Marionette.import_script API;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146662/diff/1-2/

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s cc8483d6df0d -d 47f43b453c2d: rebasing 400750:cc8483d6df0d "Bug 1370857 - Remove Marionette.clear_imported_scripts API; r=automatedtester"
merging testing/marionette/client/marionette_driver/marionette.py
merging testing/marionette/harness/marionette_harness/marionette_test/testcases.py
warning: conflicts while merging testing/marionette/harness/marionette_harness/marionette_test/testcases.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8875265 [details]
Bug 1370857 - Remove Marionette.clear_imported_scripts API;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146660/diff/2-3/

Comment 10

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8875266 [details]
Bug 1370857 - Remove Marionette.import_script API;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146662/diff/2-3/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dac00039fda
Remove Marionette.clear_imported_scripts API; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/6b37ea6c7ad1
Remove Marionette.import_script API; r=automatedtester

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0dac00039fda
https://hg.mozilla.org/mozilla-central/rev/6b37ea6c7ad1