1368664 - Use Vary header when matching HTTP/2 pushed items

Status: RESOLVED INACTIVE

(Core :: Networking: HTTP, defect, P3)

Description

[Jake Archibald [:jakea]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce:

I built a little test suite thing for this: https://github.com/jakearchibald/http2-push-test/

The test is served at /vary-cookie/, which pushes a request that has "Cookie: val=a", and the pushed response has "Vary: Cookie".

1. Press the "Set cookie b" button, this sets val=b
2. Press "Fetch with credentials" & observe the console


Actual results:

4 random numbers are logged. This is the pushed resource.


Expected results:

"NOT FROM PUSH" - because the pushed resource should not have matched.

Comment 1

[Mark Nottingham]

It'd be interesting to see if the cache did this for a non-push request; my WPT tests didn't cover cases where the cookie was changed. Will give it a go ~tomorrow (currently in the air).

Comment 2

[Firefox Bug Husbandry Bot]

Bulk priority update: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 3

[Valentin Gosu [:valentin] {{ IETF until 25 July - PTO until 3 August }}]

Unassigning bugs owned by Patrick.

Comment 4

[Valentin Gosu [:valentin] {{ IETF until 25 July - PTO until 3 August }}]

Fixed by disabling HTTP/2 push in bug 1915848.