1915848 - Pref off HTTP/2 push

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

Chrome has removed HTTP/2 push from their browser almost 2 years ago.
https://chromestatus.com/feature/6302414934114304

Recently, we've started seeing some issues that are exclusively related to us supporting HTTP/2 push - See bug 1915830 for a list of such issues, as well as other known bugs in our implementation. It also caused an incident in bug 1909271 when we tried to ship Extensible Prioritization Scheme for HTTP/2.

In order to avoid future webcompat problems only affecting Firefox, I think we should disable HTTP/2 push.
This bug will track flipping the network.http.http2.allow-push pref to false, with a separate bug to remove the implementation in a few releases if the deprecation goes smoothly.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1915848 - Set network.http.http2.allow-push to false r=kershaw

HTTP/2 Push was involved in several web-compat issues recently.
See bug 1915830 for known H2-push bugs.

As such it's best to turn off the feature and align with Chrome
in order to avoid future push bugs only affecting Firefox.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/791b8e439bbd
Set network.http.http2.allow-push to false r=kershaw

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing xpcshell failure on test_dns_by_type_resolve.js

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec4fbd52f18c
Set network.http.http2.allow-push to false r=kershaw

Comment 5

[Atila Butkovits]

Backed out for causing xpcshell failures at test_trr.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/22e0ba48f910d3749db421eb3552277bc7dccc9b

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Zt3ZzK8aSCSxgBf9692Yiw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=9df375df8b809ac5b938fd14b069b7463f5c9900

Failure log: https://treeherder.mozilla.org/logviewer?job_id=473585820&repo=autoland&lineNumber=4670

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77ed711b4717
Set network.http.http2.allow-push to false r=kershaw

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/77ed711b4717