1368957 - Not all elements are highlighted when searching for an element in "about:preferences#containers"

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Attachment: shopping.png

[Affected versions]:
Nightly 55.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Launch Firefox, go to about:config and search for "browser.preferences.search" and set it value to true.
2. Go to "about:preferences".
3. Search "Banking" on search input field.

[Expected result]:
"Check for updates" button should be displayed and highlighted after searching for "update" in search field.

[Actual result]:
Not all elements are highlighted when searching on this page "about:preferences#containers".

[Note]:
When searching for "Add new container" all the elements from "about:preferences#containers" are displayed.

Comment 1

[Hani Yacoub, Desktop QA]

Attachment: add_new_container.png

Comment 2

[Evan Tseng [:evanxd]]

I would say this could be fixed by Bug 1363721's patch. It is also about the highlighting sub-dialoag thing.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Bug 1363721 will focus on supporting highlight for sub-dialogs (popup dialog). However, #containers pane is rendered as part of an usual preferences pane itself with a separate route. So it makes sense to deal with that in this separate bug.

I'm going to figure out why containers pane cannot be highlighted as expected.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1368957 - Making the labels for containers highlightable

Review commit: https://reviewboard.mozilla.org/r/145686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145686/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8874333 [details]
Bug 1368957 - Making the labels for containers highlightable

https://reviewboard.mozilla.org/r/145686/#review149790

Thanks!

::: commit-message-8a3aa:1
(Diff revision 1)
> +Bug 1368957 - Make container panel highlightable r?mconley

Nit: We can probably be a little more specific here and say that we're making the labels for containers highlightable.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8874333 [details]
Bug 1368957 - Making the labels for containers highlightable

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145686/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e956bdfab8b
Making the labels for containers highlightable r=mconley

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0e956bdfab8b

Comment 9

[Hani Yacoub, Desktop QA]

Build ID: 20170612091112
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.