1369065 - Please enable Win32 tests for cedar twig.

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Mike Conley (:mconley) (:⚙️)]

So I've now got Linux64, OS X, and Windows 8 64-bit tests running on cedar. I need Win32 as well - I presume that'll be Windows 7.

From my understanding, this is not a thing I can control within the taskgraph "target_tasks.py" file. These types of builds are apparently something buildbot does, and I guess I have no control over that.

Is it possible to get Win32 builds, mochitests, xpcshell and talos tests working on cedar?

Comment 1

[Chris Cooper [:coop] (he/him)]

Shifting NI to Kim for prioritization.

Comment 2

[Kim Moir [:kmoir] ET]

The buildduty folks are away today for a national holiday in Romania, I'll talk to them tomorrow about this bug.

Comment 3

[Alin Selagea [:aselagea]]

Attachment: bug_1369065.patch

Patch to enable Windows 7 tests on cedar. I re-worked an older patch a bit and removed the 'linux64' part since those tests run in TaskCluster now.

Comment 4

[Alin Selagea [:aselagea]]

Attachment: diff_builders.txt

Builders diff.

Comment 5

[Alin Selagea [:aselagea]]

Attachment: diff_tests.txt

Comment 6

[Kim Moir [:kmoir] ET]

Comment on attachment 8874761 [details] [diff] [review]
bug_1369065.patch

Thanks Alin!

Comment 7

[Alin Selagea [:aselagea]]

Comment on attachment 8874761 [details] [diff] [review]
bug_1369065.patch

https://hg.mozilla.org/build/buildbot-configs/rev/211d472921ef
https://hg.mozilla.org/build/buildbot-configs/rev/89fc40bf83b2

Comment 8

[Alin Selagea [:aselagea]]

Comment on attachment 8874761 [details] [diff] [review]
bug_1369065.patch

I backed out this patch because the travis check fails on some masters.

Traceback (most recent call last):
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/.tox/braindump/buildbot-related/dump_master_json.py", line 167, in <module>
    main()
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/.tox/braindump/buildbot-related/dump_master_json.py", line 148, in main
    2017-06-06 14:31:42,548 - Couldn't load test-output/bm106-tests1-macosx/master.cfg
Traceback (most recent call last):
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/.tox/braindump/buildbot-related/dump_master_json.py", line 113, in dump_master
    c = loadMaster(path)
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/.tox/braindump/buildbot-related/dump_master_json.py", line 26, in loadMaster
    execfile(path, g, g)
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/test-output/bm106-tests1-macosx/master.cfg", line 10, in <module>
    import config
  File "/home/travis/build/mozilla-releng/build-buildbot-configs/test-output/bm106-tests1-macosx/config.py", line 3310, in <module>
    for slave_platform in BRANCHES[name]['platforms'][platform].keys():
KeyError: 'win32'

I'll need to fix the error and re-land the patch.

Comment 9

[Alin Selagea [:aselagea]]

Attachment: bug_1369065_v2.patch

I don't know why those tests fail tbh. Running 'test-masters.sh' went fine, I  also manually ran 'dump_master_json.py' using a similar configuration to a master for which the check failed and it completed without any issues.

So instead of touching a previous patch, I only left the part that enabled win32 builds and tests on cedar. Diff files are the same.

Comment 10

[Andrei Obreja [:aobreja NOT AVAILABLE][:buildduty]]

Comment on attachment 8875221 [details] [diff] [review]
bug_1369065_v2.patch

Lgtm

Comment 11

[Alin Selagea [:aselagea]]

Comment on attachment 8875221 [details] [diff] [review]
bug_1369065_v2.patch

https://hg.mozilla.org/build/buildbot-configs/rev/a756e2becb2c
https://hg.mozilla.org/build/buildbot-configs/rev/3146efaa3cc7

Travis checks passed for each of these two commits.

Comment 12

[[e-mail] (:bhearsum)]

I think this broke again? My push to the default branch of buildbot-configs got this error in Travis: https://travis-ci.org/mozilla-releng/build-buildbot-configs/jobs/240885762, which doesn't seem likely to be related to my patch. I'm not sure why it passed on your commit...

Comment 13

[Alin Selagea [:aselagea]]

Travis ran fine for the next push to bb-configs: https://travis-ci.org/mozilla-releng/build-buildbot-configs/builds/241128458
I'll keep an eye on how things go and eventually rework the patch if any related failure occurs.

Comment 14

[Alin Selagea [:aselagea]]

It looks the error appeared a few more times this week. Taking a closer look, I noticed that I used a wrong key while iterating over the list of slave platforms - 'name' instead of 'branch'.

Pushed a fix here:  https://hg.mozilla.org/build/buildbot-configs/rev/df484a274696
Sorry for the trouble.

On the other hand, tests look fine on cedar, so I think the work here is done.