Closed Bug 1369305 Opened 6 years ago Closed 6 years ago

Highlight wrong items when searching the "choose" keyword

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: evanxd, Assigned: evanxd)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog.
59 bytes, text/x-review-board-request
mconley
: review+
Details 
Highlight wrong items when searching the "choose" keyword.

STR:
1. Search the "choose" keyword.
2. Check the "Choose..." button on the "Notifications" section.

Expected:
Should not highlight the "Choose..." button.

Actual:
The "Choose..." button is highlighted.
Flags: qe-verify+
Hi Mike,

Could you help review the patch?

Thanks.
Comment on attachment 8873753 [details]
Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog.

https://reviewboard.mozilla.org/r/145166/#review149312

Thanks!
Attachment #8873753 - Flags: review?(mconley) → review+
Thank you for reviewing, Mike. Let's land the patch.
Keywords: checkin-needed
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d5df2dead2c
Do not show a tooltip for the button will not open sub-dialog. r=mconley
Keywords: checkin-needed
Hi Sheriff,

We are during soft code freeze duration.

Let's land the patch into mozilla-central after merge day of Nightly version 55 (6/12).

Thanks.
https://hg.mozilla.org/mozilla-central/rev/7d5df2dead2c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
I have reproduced this Bug on Nightly 55.0a1 (2017-06-01) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 55.0a1

Build ID    :	20170607030206
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170607]
Build ID: 20170612091112
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.