1369305 - Highlight wrong items when searching the "choose" keyword

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Evan Tseng [:evanxd]]

Highlight wrong items when searching the "choose" keyword.

STR:
1. Search the "choose" keyword.
2. Check the "Choose..." button on the "Notifications" section.

Expected:
Should not highlight the "Choose..." button.

Actual:
The "Choose..." button is highlighted.

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog.

Review commit: https://reviewboard.mozilla.org/r/145166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145166/

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8873753 [details]
Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145166/diff/1-2/

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8873753 [details]
Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145166/diff/2-3/

Comment 4

[Evan Tseng [:evanxd]]

Hi Mike,

Could you help review the patch?

Thanks.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8873753 [details]
Bug 1369305 - Do not show a tooltip for the button will not open sub-dialog.

https://reviewboard.mozilla.org/r/145166/#review149312

Thanks!

Comment 6

[Evan Tseng [:evanxd]]

Thank you for reviewing, Mike. Let's land the patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d5df2dead2c
Do not show a tooltip for the button will not open sub-dialog. r=mconley

Comment 8

[Evan Tseng [:evanxd]]

Hi Sheriff,

We are during soft code freeze duration.

Let's land the patch into mozilla-central after merge day of Nightly version 55 (6/12).

Thanks.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7d5df2dead2c

Comment 10

[Saddam Hossain]

I have reproduced this Bug on Nightly 55.0a1 (2017-06-01) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 55.0a1

Build ID    :	20170607030206
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170607]

Comment 11

[Hani Yacoub, Desktop QA]

Build ID: 20170612091112
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.