1369307 - Hiding "Firefox Screenshot" button from interface should also hide "Take a Screenshot" option in right mouse button menu and disable Firefox Screenshot extension completely

Status: VERIFIED WONTFIX

(Firefox :: Screenshots, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Hiding "Firefox Screenshot" button from interface should also hide "Take a Screenshot" option in right mouse button menu, so it should disable this Firefox feature completely, the same like it is now with Pocket feature.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

+ adding "perf" & "topperf" keywords per bug #1361792

Comment 2

[:Gijs (out for now; he/him)]

We don't prioritize bugs by the number of keywords they have, and the concern here is clearly for UX rather than perf - the fact that the add-on regresses perf wouldn't necessarily be fixed by hiding the context menu item, nor would fixing the perf issues necessarily mean that we can just call this bug worksforme.

Comment 3

[:Gijs (out for now; he/him)]

FWIW, it's not clear to me we'll be keeping this kind of opt-out for pocket given that we're adding it to the page action set and urlbar, and removing it from the navbar by default. The screenshot toolbar button will likely go the same way. Removing it from the urlbar would still show it in the page action menu. But wanting your urlbar decluttered isn't the same as not wanting the feature, given it'd still show up in the page action menu, and so it's no longer a good signal to remove all the other UI. As a result, I think we should wontfix this.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

If users could simply disable all that useless bloat for them with other "system features" in Add-ons Manager, it would be nice... ;)

Comment 5

[John Gruen [:jgruen]]

Hey, you can disable the context menu stuff from about:config by toggling extensions.screenshots.disabled to true. We're also working an a more user-friendly version of the same here: https://github.com/mozilla-services/screenshots/issues/2711 which is where i think this should be tracked.

:Gijs is correct that we are going page-action in 57, so i'm going to wontfix this.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

OK. Awesome! If there will be option in GUI to disable Screenshot feature, not just in about:config, so every user could disable it, it's awesome. Thank you very much! I'm also agreeing with that, especially with Gijs Kruitbosch [:Gijs] arguments.