Closed Bug 1356243 Opened 9 years ago Closed 9 years ago

Enable Screenshots for FF 55 & beyond

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
relnote-firefox --- 55+
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Enable by default
1.06 KB, patch
mossop
: review+
Details | Diff | Splinter Review
Following the initial landing of screenshots, once it is uplifted, then we'd like to enable screenshots for FF 55 & beyond by default.
This will apply once inbound is merged ;-) We're going to be landing this on Monday.
Attachment #8857946 - Flags: review?(dtownsend)
Attachment #8857946 - Flags: review?(dtownsend) → review+
Feels like this should have landed behind a NIGHTLY_BUILD ifdef since AFAIK, this hasn't gotten a go for riding the trains yet (see the current release-drivers thread).
Backed out for mass-failing reftests and crashtests, at least on Linux: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c9671705cdaca87c9bf94b2890108d62cacdc40 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ad9d525e6db72327cd534740981fdf3b7a11a3ae&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=94098096&repo=mozilla-inbound [task 2017-04-25T16:27:56.974248Z] 16:27:56 INFO - --DOMWINDOW == 4 (0x7fb562d05000) [pid = 1004] [serial = 7712] [outer = (nil)] [url = file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/variable-declaration-18-ref.html] [task 2017-04-25T16:27:57.221066Z] 16:27:57 INFO - [1004] WARNING: Fonts still alive while shutting down gfxFontCache: 'mFonts.Count() == 0', file /home/worker/workspace/build/src/gfx/thebes/gfxFont.cpp, line 216 [task 2017-04-25T16:27:57.228990Z] 16:27:57 INFO - Assertion failed at /home/worker/workspace/build/src/gfx/cairo/cairo/src/cairo-hash.c:196: hash_table->live_entries == 0 [task 2017-04-25T16:27:57.230254Z] 16:27:57 INFO - WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS! [task 2017-04-25T16:27:57.231178Z] 16:27:57 INFO - [1004] ###!!! ASSERTION: Component Manager being held past XPCOM shutdown.: 'cnt == 0', file /home/worker/workspace/build/src/xpcom/build/XPCOMInit.cpp, line 1040 [task 2017-04-25T16:28:13.468235Z] 16:28:13 INFO - #01: ScopedXPCOMStartup::~ScopedXPCOMStartup [toolkit/xre/nsAppRunner.cpp:1446] [task 2017-04-25T16:28:13.469520Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.470778Z] 16:28:13 INFO - #02: mozilla::DefaultDelete<ScopedXPCOMStartup>::operator() [mfbt/UniquePtr.h:529] [task 2017-04-25T16:28:13.472094Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.473319Z] 16:28:13 INFO - #03: XREMain::XRE_main [toolkit/xre/nsAppRunner.cpp:4758] [task 2017-04-25T16:28:13.474329Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.475650Z] 16:28:13 INFO - #04: XRE_main [toolkit/xre/nsAppRunner.cpp:4815] [task 2017-04-25T16:28:13.476772Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.499542Z] 16:28:13 INFO - #05: do_main [browser/app/nsBrowserApp.cpp:236] [task 2017-04-25T16:28:13.500772Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.502202Z] 16:28:13 INFO - #06: main [browser/app/nsBrowserApp.cpp:309] [task 2017-04-25T16:28:13.503417Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.504287Z] 16:28:13 INFO - #07: libc.so.6 + 0x20830 [task 2017-04-25T16:28:13.504974Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.505918Z] 16:28:13 INFO - #08: _start [task 2017-04-25T16:28:13.506801Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.507568Z] 16:28:13 INFO - [1004] WARNING: '!compMgr', file /home/worker/workspace/build/src/xpcom/components/nsComponentManagerUtils.cpp, line 63 [task 2017-04-25T16:28:13.508703Z] 16:28:13 INFO - [1004] ###!!! ASSERTION: 341 dynamic atom(s) with non-zero refcount: de-*,ru,place,no-bar,autocomplete-richlistbox,autocomplete-result-popupset,oncustomizationending,timepicker,oncustomizationchange,ia-*,da-*,sl,onmozshowdropdown,onTabOpen,gl-*,moz-nullprincipal:{e5cf022d-e4da-4f1a-b4f8-89dde824bcf9},onAboutPrivateBrowsingDontShowIntroPanelAgain,bs-*,nav-bar,preference,...: 'nonZeroRefcountAtomsCount == 0', file /home/worker/workspace/build/src/xpcom/ds/nsAtomTable.cpp, line 421 [task 2017-04-25T16:28:13.508893Z] 16:28:13 INFO - #01: NS_ShutdownAtomTable [xpcom/ds/nsAtomTable.cpp:575] [task 2017-04-25T16:28:13.510049Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.510371Z] 16:28:13 INFO - #02: mozilla::ShutdownXPCOM [xpcom/build/XPCOMInit.cpp:1050] [task 2017-04-25T16:28:13.510899Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.511850Z] 16:28:13 INFO - #03: ScopedXPCOMStartup::~ScopedXPCOMStartup [toolkit/xre/nsAppRunner.cpp:1446] [task 2017-04-25T16:28:13.512427Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.512697Z] 16:28:13 INFO - #04: mozilla::DefaultDelete<ScopedXPCOMStartup>::operator() [mfbt/UniquePtr.h:529] [task 2017-04-25T16:28:13.513470Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.514423Z] 16:28:13 INFO - #05: XREMain::XRE_main [toolkit/xre/nsAppRunner.cpp:4758] [task 2017-04-25T16:28:13.514672Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.515551Z] 16:28:13 INFO - #06: XRE_main [toolkit/xre/nsAppRunner.cpp:4815] [task 2017-04-25T16:28:13.515857Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.516762Z] 16:28:13 INFO - #07: do_main [browser/app/nsBrowserApp.cpp:236] [task 2017-04-25T16:28:13.519421Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.520293Z] 16:28:13 INFO - #08: main [browser/app/nsBrowserApp.cpp:309] [task 2017-04-25T16:28:13.521050Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.521859Z] 16:28:13 INFO - #09: libc.so.6 + 0x20830 [task 2017-04-25T16:28:13.523063Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.523959Z] 16:28:13 INFO - #10: _start [task 2017-04-25T16:28:13.524944Z] 16:28:13 INFO - [task 2017-04-25T16:28:13.525786Z] 16:28:13 INFO - firefox: fccache.c:534: FcCacheFini: Assertion `fcCacheChains[i] == NULL' failed. [task 2017-04-25T16:28:13.526633Z] 16:28:13 INFO - ExceptionHandler::GenerateDump cloned child 1115 [task 2017-04-25T16:28:13.527473Z] 16:28:13 INFO - ExceptionHandler::SendContinueSignalToChild sent continue signal to child [task 2017-04-25T16:28:13.528366Z] 16:28:13 INFO - ExceptionHandler::WaitForContinueSignal waiting for continue signal... [task 2017-04-25T16:28:13.529214Z] 16:28:13 INFO - TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/variable-declaration-33.html | application terminated with exit code 6 [task 2017-04-25T16:28:13.530098Z] 16:28:13 INFO - REFTEST INFO | Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmpTqyjtV.mozrunner/minidumps/3546386f-a8c3-a790-a0d2-99468dd7445b.dmp /home/worker/workspace/build/symbols [task 2017-04-25T16:28:20.594278Z] 16:28:20 INFO - REFTEST INFO | Saved minidump as /home/worker/workspace/build/blobber_upload_dir/3546386f-a8c3-a790-a0d2-99468dd7445b.dmp [task 2017-04-25T16:28:20.595229Z] 16:28:20 INFO - REFTEST INFO | Saved app info as /home/worker/workspace/build/blobber_upload_dir/3546386f-a8c3-a790-a0d2-99468dd7445b.extra [task 2017-04-25T16:28:20.648433Z] 16:28:20 INFO - REFTEST PROCESS-CRASH | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/variable-declaration-33.html | application crashed [@ libc-2.23.so + 0x35428] [task 2017-04-25T16:28:20.649445Z] 16:28:20 INFO - Crash dump filename: /tmp/tmpTqyjtV.mozrunner/minidumps/3546386f-a8c3-a790-a0d2-99468dd7445b.dmp [task 2017-04-25T16:28:20.650279Z] 16:28:20 INFO - Operating system: Linux [task 2017-04-25T16:28:20.651132Z] 16:28:20 INFO - 0.0.0 Linux 3.13.0-112-generic #159-Ubuntu SMP Fri Mar 3 15:26:07 UTC 2017 x86_64 [task 2017-04-25T16:28:20.651849Z] 16:28:20 INFO - CPU: amd64 [task 2017-04-25T16:28:20.652750Z] 16:28:20 INFO - family 6 model 62 stepping 4 [task 2017-04-25T16:28:20.653538Z] 16:28:20 INFO - 2 CPUs [task 2017-04-25T16:28:20.654298Z] 16:28:20 INFO - [task 2017-04-25T16:28:20.655150Z] 16:28:20 INFO - GPU: UNKNOWN [task 2017-04-25T16:28:20.655856Z] 16:28:20 INFO - [task 2017-04-25T16:28:20.656716Z] 16:28:20 INFO - Crash reason: SIGABRT [task 2017-04-25T16:28:20.657809Z] 16:28:20 INFO - Crash address: 0x3e8000003ec [task 2017-04-25T16:28:20.658535Z] 16:28:20 INFO - Process uptime: not available [task 2017-04-25T16:28:20.659281Z] 16:28:20 INFO - [task 2017-04-25T16:28:20.660085Z] 16:28:20 INFO - Thread 0 (crashed) [task 2017-04-25T16:28:20.660886Z] 16:28:20 INFO - 0 libc-2.23.so + 0x35428 [task 2017-04-25T16:28:20.661662Z] 16:28:20 INFO - rax = 0x0000000000000000 rdx = 0x0000000000000006 [task 2017-04-25T16:28:20.662457Z] 16:28:20 INFO - rcx = 0xffffffffffffffff rbx = 0x00007fb599fa3000 [task 2017-04-25T16:28:20.663287Z] 16:28:20 INFO - rsi = 0x00000000000003ec rdi = 0x00000000000003ec [task 2017-04-25T16:28:20.664022Z] 16:28:20 INFO - rbp = 0x00007fb5943811dc rsp = 0x00007fff0c149ad8 [task 2017-04-25T16:28:20.664828Z] 16:28:20 INFO - r8 = 0x0000000000000000 r9 = 0xffffffffff000000 [task 2017-04-25T16:28:20.665672Z] 16:28:20 INFO - r10 = 0x0000000000000008 r11 = 0x0000000000000202 [task 2017-04-25T16:28:20.666420Z] 16:28:20 INFO - r12 = 0x0000000000000216 r13 = 0x00007fb594381390 [task 2017-04-25T16:28:20.667209Z] 16:28:20 INFO - r14 = 0x00007fb55ba16080 r15 = 0x00007fb57a7f7320 [task 2017-04-25T16:28:20.668036Z] 16:28:20 INFO - rip = 0x00007fb598b3c428 [task 2017-04-25T16:28:20.668799Z] 16:28:20 INFO - Found by: given as instruction pointer in context [task 2017-04-25T16:28:20.669627Z] 16:28:20 INFO - 1 libc-2.23.so + 0x3702a [task 2017-04-25T16:28:20.670437Z] 16:28:20 INFO - rsp = 0x00007fff0c149ae0 rip = 0x00007fb598b3e02a [task 2017-04-25T16:28:20.671155Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.671986Z] 16:28:20 INFO - 2 firefox!arena_dalloc [jemalloc.c:ad9d525e6db7 : 1625 + 0x5] [task 2017-04-25T16:28:20.672934Z] 16:28:20 INFO - rsp = 0x00007fff0c149b80 rip = 0x000000000041aa9e [task 2017-04-25T16:28:20.673776Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.675656Z] 16:28:20 INFO - 3 libfontconfig.so.1.9.0 + 0x26390 [task 2017-04-25T16:28:20.676635Z] 16:28:20 INFO - rsp = 0x00007fff0c149bb0 rip = 0x00007fb594381390 [task 2017-04-25T16:28:20.677528Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.678459Z] 16:28:20 INFO - 4 firefox!je_free [jemalloc.c:ad9d525e6db7 : 6374 + 0x8] [task 2017-04-25T16:28:20.679377Z] 16:28:20 INFO - rsp = 0x00007fff0c149bd0 rip = 0x000000000041cf80 [task 2017-04-25T16:28:20.680313Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.681179Z] 16:28:20 INFO - 5 libc-2.23.so + 0x18f658 [task 2017-04-25T16:28:20.682091Z] 16:28:20 INFO - rsp = 0x00007fff0c149be0 rip = 0x00007fb598c96658 [task 2017-04-25T16:28:20.683045Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.683897Z] 16:28:20 INFO - 6 libfontconfig.so.1.9.0 + 0x261dc [task 2017-04-25T16:28:20.684737Z] 16:28:20 INFO - rsp = 0x00007fff0c149be8 rip = 0x00007fb5943811dc [task 2017-04-25T16:28:20.685587Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.686473Z] 16:28:20 INFO - 7 libfontconfig.so.1.9.0 + 0x26390 [task 2017-04-25T16:28:20.686829Z] 16:28:20 INFO - rsp = 0x00007fff0c149bf8 rip = 0x00007fb594381390 [task 2017-04-25T16:28:20.687631Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.688856Z] 16:28:20 INFO - 8 libfontconfig.so.1.9.0 + 0x261dc [task 2017-04-25T16:28:20.689640Z] 16:28:20 INFO - rsp = 0x00007fff0c149c08 rip = 0x00007fb5943811dc [task 2017-04-25T16:28:20.690866Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.691730Z] 16:28:20 INFO - 9 libc-2.23.so + 0x2dbd7 [task 2017-04-25T16:28:20.692524Z] 16:28:20 INFO - rsp = 0x00007fff0c149c10 rip = 0x00007fb598b34bd7 [task 2017-04-25T16:28:20.693307Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.694094Z] 16:28:20 INFO - 10 libfontconfig.so.1.9.0 + 0x261d2 [task 2017-04-25T16:28:20.695299Z] 16:28:20 INFO - rsp = 0x00007fff0c149c20 rip = 0x00007fb5943811d2 [task 2017-04-25T16:28:20.696117Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.696943Z] 16:28:20 INFO - 11 libfontconfig.so.1.9.0 + 0x26390 [task 2017-04-25T16:28:20.697738Z] 16:28:20 INFO - rsp = 0x00007fff0c149c30 rip = 0x00007fb594381390 [task 2017-04-25T16:28:20.698522Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.699352Z] 16:28:20 INFO - 12 libfontconfig.so.1.9.0 + 0x261dc [task 2017-04-25T16:28:20.700180Z] 16:28:20 INFO - rsp = 0x00007fff0c149c50 rip = 0x00007fb5943811dc [task 2017-04-25T16:28:20.701015Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.701802Z] 16:28:20 INFO - 13 libfontconfig.so.1.9.0 + 0x261d2 [task 2017-04-25T16:28:20.702594Z] 16:28:20 INFO - rsp = 0x00007fff0c149c58 rip = 0x00007fb5943811d2 [task 2017-04-25T16:28:20.703470Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.704735Z] 16:28:20 INFO - 14 libc-2.23.so + 0x2dc82 [task 2017-04-25T16:28:20.705552Z] 16:28:20 INFO - rsp = 0x00007fff0c149c60 rip = 0x00007fb598b34c82 [task 2017-04-25T16:28:20.706736Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.708037Z] 16:28:20 INFO - 15 libfontconfig.so.1.9.0 + 0x90f9 [task 2017-04-25T16:28:20.709046Z] 16:28:20 INFO - rsp = 0x00007fff0c149c90 rip = 0x00007fb5943640f9 [task 2017-04-25T16:28:20.710044Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.711036Z] 16:28:20 INFO - 16 libfontconfig.so.1.9.0 + 0x1697e [task 2017-04-25T16:28:20.712028Z] 16:28:20 INFO - rsp = 0x00007fff0c149ca0 rip = 0x00007fb59437197e [task 2017-04-25T16:28:20.713025Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.713661Z] 16:28:20 INFO - 17 libxul.so!MOZ_gdk_display_close [nsAppRunner.cpp:ad9d525e6db7 : 2925 + 0x5] [task 2017-04-25T16:28:20.714351Z] 16:28:20 INFO - rsp = 0x00007fff0c149cb0 rip = 0x00007fb58b77f14e [task 2017-04-25T16:28:20.714442Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.715179Z] 16:28:20 INFO - 18 libnspr4.so!PR_Unlock [ptsynch.c:ad9d525e6db7 : 209 + 0x8] [task 2017-04-25T16:28:20.716414Z] 16:28:20 INFO - rsp = 0x00007fff0c149cc0 rip = 0x00007fb5984d2793 [task 2017-04-25T16:28:20.717149Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.717885Z] 16:28:20 INFO - 19 libxul.so!XREMain::XRE_main [nsAppRunner.cpp:ad9d525e6db7 : 4791 + 0xc] [task 2017-04-25T16:28:20.718608Z] 16:28:20 INFO - rsp = 0x00007fff0c149d10 rip = 0x00007fb58b7879a7 [task 2017-04-25T16:28:20.720117Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.720214Z] 16:28:20 INFO - 20 libpthread-2.23.so + 0x2182c0 [task 2017-04-25T16:28:20.721988Z] 16:28:20 INFO - rsp = 0x00007fff0c149d18 rip = 0x00007fb599d952c0 [task 2017-04-25T16:28:20.722700Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.723457Z] 16:28:20 INFO - 21 libxul.so!nsLocalFile::AppendRelativeNativePath [nsLocalFileUnix.cpp:ad9d525e6db7 : 542 + 0xd] [task 2017-04-25T16:28:20.725731Z] 16:28:20 INFO - rsp = 0x00007fff0c149d38 rip = 0x00007fb588f6e3cc [task 2017-04-25T16:28:20.725825Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.726499Z] 16:28:20 INFO - 22 firefox!_fini + 0x168 [task 2017-04-25T16:28:20.727200Z] 16:28:20 INFO - rsp = 0x00007fff0c149d78 rip = 0x000000000041dd00 [task 2017-04-25T16:28:20.727293Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.727984Z] 16:28:20 INFO - 23 libxul.so!XRE_main [nsAppRunner.cpp:ad9d525e6db7 : 4815 + 0x5] [task 2017-04-25T16:28:20.728682Z] 16:28:20 INFO - rsp = 0x00007fff0c149dc0 rip = 0x00007fb58b787b11 [task 2017-04-25T16:28:20.729377Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.730127Z] 16:28:20 INFO - 24 libxul.so!_fini + 0x1bcd038 [task 2017-04-25T16:28:20.730823Z] 16:28:20 INFO - rsp = 0x00007fff0c149e58 rip = 0x00007fb58e0e2c90 [task 2017-04-25T16:28:20.732279Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.732372Z] 16:28:20 INFO - 25 libxul.so!_fini + 0x1bcd080 [task 2017-04-25T16:28:20.733605Z] 16:28:20 INFO - rsp = 0x00007fff0c149e60 rip = 0x00007fb58e0e2cd8 [task 2017-04-25T16:28:20.734316Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.735043Z] 16:28:20 INFO - 26 libxul.so!_fini + 0x1e32b78 [task 2017-04-25T16:28:20.735767Z] 16:28:20 INFO - rsp = 0x00007fff0c149ea0 rip = 0x00007fb58e3487d0 [task 2017-04-25T16:28:20.736486Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.737205Z] 16:28:20 INFO - 27 libxul.so!_fini + 0x1e32b78 [task 2017-04-25T16:28:20.737942Z] 16:28:20 INFO - rsp = 0x00007fff0c149ea8 rip = 0x00007fb58e3487d0 [task 2017-04-25T16:28:20.738673Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.739411Z] 16:28:20 INFO - 28 firefox!strndup [mozmemory_wrap.c:ad9d525e6db7 : 77 + 0xe] [task 2017-04-25T16:28:20.740812Z] 16:28:20 INFO - rsp = 0x00007fff0c149f60 rip = 0x0000000000415b1e [task 2017-04-25T16:28:20.740904Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.741579Z] 16:28:20 INFO - 29 libc-2.23.so + 0x39786 [task 2017-04-25T16:28:20.742343Z] 16:28:20 INFO - rsp = 0x00007fff0c149f70 rip = 0x00007fb598b40786 [task 2017-04-25T16:28:20.743622Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.744349Z] 16:28:20 INFO - 30 firefox!do_main [nsBrowserApp.cpp:ad9d525e6db7 : 236 + 0x22] [task 2017-04-25T16:28:20.745081Z] 16:28:20 INFO - rsp = 0x00007fff0c149fb0 rip = 0x0000000000406466 [task 2017-04-25T16:28:20.745840Z] 16:28:20 INFO - Found by: stack scanning [task 2017-04-25T16:28:20.746552Z] 16:28:20 INFO - 31 firefox!_fini + 0x19f [task 2017-04-25T16:28:20.747283Z] 16:28:20 INFO - rsp = 0x00007fff0c149fc0 rip = 0x000000000041dd37 [task 2017-04-25T16:28:20.749873Z] 16:28:20 INFO - Found by: stack scanning
Flags: needinfo?(standard8)
I hadn't realised this depends on bug 1357805 being fixed - I'd assumed screenshots was disabled during all tests, not just mochitest/xpcshell.
Depends on: 1357805
Flags: needinfo?(standard8)
Backed this out in https://hg.mozilla.org/mozilla-central/rev/b25ad0674afd563e888dc07981baa626e8d794db so I could get inbound merged around without also merging around bug 1361792.
Flags: needinfo?(standard8)
Jared is working on this in that bug.
Flags: needinfo?(standard8)
Update: The fix in bug 1362234 should have fixed most performance regressions. Any others should be already filed against bug 1361792 and will be fixed in a short period of time (so I'm told via Jared).
https://hg.mozilla.org/mozilla-central/rev/caa721034f47
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Sorry to be the bearer of bad news, but it seems like the second landing of this was similarly affected by many regressions of many Talos test suites across the board. I think this should be backed out again until these regressions are addressed.
Back out again https://hg.mozilla.org/mozilla-central/rev/c273884ffe6bb255399bb15fbad6eb0b66be49eb
Status: RESOLVED → REOPENED
status-firefox55: fixed → affected
Resolution: FIXED → ---
Target Milestone: Firefox 55 → ---
Depends on: 1356828
Depends on: 1362224
Depends on: 1356810
Depends on: 1356827
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1ca88950d83c Enable Screenshots by default. r=Mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1ca88950d83c
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Depends on: 1368279
It looks like this landed without the changes to lazily load background scripts, which means we're currently spending about 40ms loading unnecessary background scripts at startup on a fast machine, and probably several times longer on slow machines.
Mark, could you add a release notes addition request to this bug please? Thanks
Flags: needinfo?(standard8)
Depends on: 1368401
(In reply to Pascal Chevrel:pascalc from comment #18) > Mark, could you add a release notes addition request to this bug please? > Thanks -> Ian as he's one of the leads on this.
Flags: needinfo?(standard8) → needinfo?(ianb)
Sorry all, I got a little too eager and merged this before the corresponding new code (bug 1368146) landed. The new code contains critical performance fixes. Bug 1368146 should be merged shortly, and should make its way into m-c this afternoon.
[Why is this notable]: Adds a new screenshot feature to Firefox [Affects Firefox for Android]: No [Suggested wording]: Firefox includes a new feature: make screenshots of webpages, and save those locally or upload them to the cloud [Links (documentation, blog post, etc)]: Site: https://screenshots.firefox.com/ Development repository: https://github.com/mozilla-services/screenshots Blog post will be forthcoming
relnote-firefox: --- → ?
Flags: needinfo?(ianb)
(In reply to Jared Hirsch [:_6a68] (please use 'needinfo' :-) from comment #22) > Following up on comment 20, the updated code has landed: > https://hg.mozilla.org/integration/autoland/rev/e0e0d7d31cd5 What about all of the other regressions that this caused? See https://treeherder.mozilla.org/perf.html#/alerts?id=6920 Is some other bug tracking the work for those regressions to not be shipped in Firefox 55? How are we going to ensure that as this keeps living on m-c? > Here's a Try run of the updated code with 5 Talos retries: > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=88b6a2c7e3587d29783c05e1c96b19d0e358655e That try push was pushed with -t none FWIW.
Flags: needinfo?(jhirsch)
> That try push was pushed with -t none FWIW. Yeah, that was my mistake. I pushed a later Try run with full talos tests; it was linked in the EOD email, but not pasted in here. Link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cfd309079dfff978be9735abec1ff791988454e > What about all of the other regressions that this caused? See https://treeherder.mozilla.org/perf.html#/alerts?id=6920 Is some other bug tracking the work for those regressions to not be shipped in Firefox 55? How are we going to ensure that as this keeps living on m-c? Great questions, we're looking into it now
Flags: needinfo?(jhirsch)
Hmm. Since "we're working on it" isn't an adequate answer, given the current focus on perf, I"ll leave this ni? me until we actually answer Ehsan's questions
Flags: needinfo?(jhirsch)
OK, perf discussion related to Screenshots seems to be happening in bug 1361792. It's a long bug; see comment 40+ for discussion of the current list of regressions and perf optimizations we might try next to address them.
Flags: needinfo?(jhirsch)
adding to the 55beta release notes
relnote-firefox: ? → 55+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: