1369403 - TEST-UNEXPECTED-FAIL | C:\slave\test\build\tests\mozmill\content-tabs\test-about-support.js | test-about-support.js::test_display_about_support

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

First seen 2017-06-01

https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=6431fecfdf99c9cf927373c0de46a26c20428f32&selectedJob=103699988

https://archive.mozilla.org/pub/thunderbird/nightly/2017/06/2017-06-01-03-02-08-comm-central/comm-central_win7_ix_test-mozmill-bm126-tests1-windows-build34.txt.gz

says:
07:06:19     INFO -  JavaScript error: chrome://messenger/content/about-support/aboutSupport.js, line 674: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]

M-C last good: bdb2387396b4a74dfefb7c983733eed362
M-C first bad: 0bcea6bac1797e14b00af45cc7c368d124

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bdb2387396b4a74dfefb7c983733eed362&tochange=0bcea6bac1797e14b00af45cc7c368d124

Comment 1

[Jorg K (CEST = GMT+2)]

Looks like it comes from here:
https://hg.mozilla.org/mozilla-central/diff/39941ecd6096/toolkit/locales/en-US/chrome/global/aboutSupport.properties

Comment 2

[Jorg K (CEST = GMT+2)]

Looks like we simply need to port bug 1358223:
https://hg.mozilla.org/mozilla-central/rev/39941ecd6096#l2.12

Let's try this now.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1369403-sandbox.patch

https://hg.mozilla.org/comm-central/rev/57b7bce56f6b5a431672b257798eef387ef836aa

We'll see whether this helps.

Comment 4

[Jorg K (CEST = GMT+2)]

Done here.

Comment 5

[Markus Adrario [:Taraman]]

This patch causes a failure in cal-recurrence/testWeeklyWithExceptionRecurrence.js. [1]

starting with this push: [2]


[1]: https://treeherder.mozilla.org/logviewer.html#?job_id=103749685&repo=comm-central&lineNumber=17696
[2]: cal-recurrence/testWeeklyWithExceptionRecurrence.js

Comment 6

[Markus Adrario [:Taraman]]

Only on linux debug builds...

Comment 7

[Jorg K (CEST = GMT+2)]

Hmm, that seems unrelated. What would packaging sandbox.xpt have to do with this:
https://hg.mozilla.org/comm-central/rev/57b7bce56f6b5a431672b257798eef387ef836aa

I saw the failures and was thinking of you, so perhaps you can investigate.

Also, on Windows the failure came and went:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=4fb99e8e947aba3e7815cec74b5e6d1ec5f67006&selectedJob=104347515

I don't really feel culpable here ;-)