Closed Bug 1369410 Opened 2 years ago Closed 2 years ago
Enable JSVM code coverage collection on linux64-ccov
59 bytes, text/x-review-board-request
:nbp would you have any ideas about how 2 or 3 could be fixed or where the problems are coming from?
I spoke with nbp over IRC and he mentioned that problem 3 is expected because we can't relazify after a lazy function is called since we need to keep the coverage count. So, that means that we can skip these tests, along with the tests mentioned in 1. There is still some work that needs to be done to see if anything can be done for 2.
I am all for skipping tests; lets make sure that we do it in an easy to query way so in the future it is straightforward to find all tests skipped, etc. :)
I am thinking of adding this comment: # skip-if = coverage for jit-test That would make it easier to find all tests being skipped for coverage on DXR. I'll make two bugs to document the problems, one for the runtime error failures and one for the lazy function problem. (No bug for the coverage error, since that's self-explanatory). So I'll skip the tests, write the bugs, test the jsvm on all test suites again and then submit a patch for review.
Here's a test run with JSVM on all test-suites with the tests disabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=00c60d16bcf1c5233ef2b6b337c3e810dd6d8f89 I can submit the patch now or after bug 1367763 has landed. Either way, one or the other will need to be modified slightly.
lets submit for review so this can land- the jittests are all green right now!
Assignee: nobody → gmierz2
Comment on attachment 8873898 [details] Bug 1369410 - Enable JSVM code coverage collection on linux64-ccov. https://reviewboard.mozilla.org/r/145286/#review149246 thanks, this looks great.
Attachment #8873898 - Flags: review?(jmaher) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/74b1f6dafa0a Enable JSVM code coverage collection on linux64-ccov. r=jmaher
You need to log in before you can comment on or make changes to this bug.