1369704 - Menulist items aren't highlighted

Status: VERIFIED FIXED

(Toolkit :: Preferences, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Attachment: actual result.png

[Affected versions]: 
Nightly 55.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Launch Firefox, go to about:config and search for "browser.preferences.search" and set it value to true.
2. Go to "about:preferences".
3. Search for "yahoo" in the search field.

[Expected result]:
Menulist items should be highlighted if they matched the keyword.

[Actual result]:
Menulist items aren't highlighted.

Comment 1

[Hani Yacoub, Desktop QA]

Attachment: expected result1.png

Comment 2

[Hani Yacoub, Desktop QA]

Attachment: expected result2.png

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1369704 - Menulist items aren't highlighted

Review commit: https://reviewboard.mozilla.org/r/145652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145652/

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Mike, I suspect this regression is due to bug 1352481 after resolving merge conflict. Please review it kindly thanks!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8874284 [details]
Bug 1369704 - Menulist items aren't highlighted

https://reviewboard.mozilla.org/r/145652/#review149786

This looks okay, though note that [when the item is selected in the menupopup](http://i.imgur.com/XJ9Wd86.png), the highlight changes. Not sure if that's desirable or not, but thought I'd point it out - perhaps something worth running by UX.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Thanks for bringing this up. I had a conversation on this topic with visual designer yesterday and here is latest "Search Highlights Visual" spec for this.

https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/237178978_6-1_Search_Highlights_Visual

I'll update the color within this patch. Thanks

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8874284 [details]
Bug 1369704 - Menulist items aren't highlighted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145652/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcc662d5a3cc
Menulist items aren't highlighted r=mconley

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dcc662d5a3cc

Comment 10

[Hani Yacoub, Desktop QA]

Build ID: 20170612091112
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.