Removal of gray roots tracer on shutdown calls the wrong API

NEW
Assigned to

Status

()

Core
JavaScript: GC
P3
normal
5 months ago
4 days ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

(Depends on: 1 bug, {triage-deferred})

55 Branch
triage-deferred
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
Created attachment 8873818 [details] [diff] [review]
fix-remove-gray-roots-tracer

I noticed while reading the code that CycleCollectedJSRuntime::Shutdown calls JS_RemoveExtraGCRootsTracer to remove the gray roots tracer.  That won't work because that only removes tracers installed with JS_AddExtraGCRootsTracer.
Attachment #8873818 - Flags: review?(continuation)
Comment on attachment 8873818 [details] [diff] [review]
fix-remove-gray-roots-tracer

Review of attachment 8873818 [details] [diff] [review]:
-----------------------------------------------------------------

Can we assert if a call to JS_RemoveExtraGCRootsTracer doesn't remove anything?
Attachment #8873818 - Flags: review?(continuation) → review+

Comment 2

4 months ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8adc00c59534
Fix removing the gray roots tracer r=mccr8
Backed out for crashes in xpcshell tests on Linux and OS X, e.g. in test_captive_portal_not_found.js @ JS::HeapObjectPostBarrier:

https://hg.mozilla.org/integration/mozilla-inbound/rev/5df249f4aee1e3b33de2f4822d47b49839eb922a

Push with failures (the xpcshell fips failures are from a previous push): https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8adc00c59534ca1ad6c30908d1e166c679bcf4fc&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Failure log example: https://treeherder.mozilla.org/logviewer.html#?job_id=104854195&repo=mozilla-inbound

[task 2017-06-06T11:12:29.228751Z] 11:12:29     INFO -  TEST-START | toolkit/components/captivedetect/test/unit/test_captive_portal_not_found.js
[task 2017-06-06T11:12:30.054700Z] 11:12:30  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/captivedetect/test/unit/test_captive_portal_not_found.js | xpcshell return code: -11
[task 2017-06-06T11:12:30.327966Z] 11:12:30     INFO -  TEST-INFO took 826ms
[task 2017-06-06T11:12:30.328410Z] 11:12:30     INFO -  >>>>>>>
[task 2017-06-06T11:12:30.328696Z] 11:12:30     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2017-06-06T11:12:30.330643Z] 11:12:30     INFO -  (xpcshell/head.js) | test pending (2)
[task 2017-06-06T11:12:30.333870Z] 11:12:30     INFO -  TEST-PASS | toolkit/components/captivedetect/test/unit/test_captive_portal_not_found.js | prepare - [prepare : 36] 1 == 1
[task 2017-06-06T11:12:30.335015Z] 11:12:30     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2017-06-06T11:12:30.335468Z] 11:12:30     INFO -  running event loop
[task 2017-06-06T11:12:30.337823Z] 11:12:30     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2017-06-06T11:12:30.338162Z] 11:12:30     INFO -  PID 11590 | HTTP activity
[task 2017-06-06T11:12:30.340537Z] 11:12:30     INFO -  TEST-PASS | toolkit/components/captivedetect/test/unit/test_captive_portal_not_found.js | complete - [complete : 40] 2 == 2
[task 2017-06-06T11:12:30.341955Z] 11:12:30     INFO -  TEST-PASS | toolkit/components/captivedetect/test/unit/test_captive_portal_not_found.js | complete - [complete : 41] true == true
[task 2017-06-06T11:12:30.343308Z] 11:12:30     INFO -  TEST-PASS | toolkit/components/captivedetect/test/unit/test_captive_portal_not_found.js | complete - [complete : 42] 1 == 1
[task 2017-06-06T11:12:30.343574Z] 11:12:30     INFO -  PID 11590 | server stop
[task 2017-06-06T11:12:30.346639Z] 11:12:30     INFO -  (xpcshell/head.js) | test finished (1)
[task 2017-06-06T11:12:30.346950Z] 11:12:30     INFO -  exiting test
[task 2017-06-06T11:12:30.349644Z] 11:12:30     INFO -  PID 11590 | ExceptionHandler::GenerateDump cloned child 11616
[task 2017-06-06T11:12:30.351135Z] 11:12:30     INFO -  PID 11590 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2017-06-06T11:12:30.352474Z] 11:12:30     INFO -  PID 11590 | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2017-06-06T11:12:30.352723Z] 11:12:30     INFO -  <<<<<<<
[task 2017-06-06T11:12:30.356547Z] 11:12:30     INFO -  mozcrash Downloading symbols from: https://queue.taskcluster.net/v1/task/Oq5g99p8SBCAD60aX8gdtQ/artifacts/public/build/target.crashreporter-symbols.zip
[task 2017-06-06T11:12:44.622354Z] 11:12:44     INFO -  mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/xpc-other-KwWwIg/420a4d63-6484-3449-ca0c-3205f7ee7f09.dmp /tmp/tmpcKf38Q
[task 2017-06-06T11:13:04.470215Z] 11:13:04     INFO -  mozcrash Saved minidump as /home/worker/workspace/build/blobber_upload_dir/420a4d63-6484-3449-ca0c-3205f7ee7f09.dmp
[task 2017-06-06T11:13:04.474247Z] 11:13:04     INFO -  mozcrash Saved app info as /home/worker/workspace/build/blobber_upload_dir/420a4d63-6484-3449-ca0c-3205f7ee7f09.extra
[task 2017-06-06T11:13:04.487260Z] 11:13:04  WARNING -  PROCESS-CRASH | toolkit/components/captivedetect/test/unit/test_captive_portal_not_found.js | application crashed [@ JS::HeapObjectPostBarrier]
[task 2017-06-06T11:13:04.548086Z] 11:13:04     INFO -  Crash dump filename: /tmp/xpc-other-KwWwIg/420a4d63-6484-3449-ca0c-3205f7ee7f09.dmp
[task 2017-06-06T11:13:04.550323Z] 11:13:04     INFO -  Operating system: Linux
[task 2017-06-06T11:13:04.551828Z] 11:13:04     INFO -                    0.0.0 Linux 3.13.0-100-generic #147-Ubuntu SMP Tue Oct 18 16:48:51 UTC 2016 x86_64
[task 2017-06-06T11:13:04.552137Z] 11:13:04     INFO -  CPU: amd64
[task 2017-06-06T11:13:04.552432Z] 11:13:04     INFO -       family 6 model 45 stepping 7
[task 2017-06-06T11:13:04.554124Z] 11:13:04     INFO -       1 CPU
[task 2017-06-06T11:13:04.554378Z] 11:13:04     INFO -  GPU: UNKNOWN
[task 2017-06-06T11:13:04.554652Z] 11:13:04     INFO -  Crash reason:  SIGSEGV
[task 2017-06-06T11:13:04.557099Z] 11:13:04     INFO -  Crash address: 0x7fcbd92ffff0
[task 2017-06-06T11:13:04.560506Z] 11:13:04     INFO -  Process uptime: not available
[task 2017-06-06T11:13:04.562600Z] 11:13:04     INFO -  Thread 0 (crashed)
[task 2017-06-06T11:13:04.568570Z] 11:13:04     INFO -   0  libxul.so!JS::HeapObjectPostBarrier [Heap.h:8adc00c59534 : 1207 + 0x0]
[task 2017-06-06T11:13:04.570761Z] 11:13:04     INFO -      rax = 0x00007fcbf1328090   rdx = 0x0000000000000000
[task 2017-06-06T11:13:04.572803Z] 11:13:04     INFO -      rcx = 0x00000000f94c10dd   rbx = 0x00007fcbd913ad60
[task 2017-06-06T11:13:04.576197Z] 11:13:04     INFO -      rsi = 0x00007fcbd9200000   rdi = 0x00007fcbd913ad70
[task 2017-06-06T11:13:04.578201Z] 11:13:04     INFO -      rbp = 0x00007fff76b51370   rsp = 0x00007fff76b51330
[task 2017-06-06T11:13:04.580174Z] 11:13:04     INFO -       r8 = 0x0000000000000000    r9 = 0x00007fcbdfb00f68
[task 2017-06-06T11:13:04.582175Z] 11:13:04     INFO -      r10 = 0x00000000eabfc89c   r11 = 0x00007fcbd913adf0
[task 2017-06-06T11:13:04.584333Z] 11:13:04     INFO -      r12 = 0x00007fcbd913ad70   r13 = 0x00007fcbd913ad70
[task 2017-06-06T11:13:04.588542Z] 11:13:04     INFO -      r14 = 0x0000000000000003   r15 = 0x00007fcbd91c5128
[task 2017-06-06T11:13:04.590719Z] 11:13:04     INFO -      rip = 0x00007fcbefc7f9cc
[task 2017-06-06T11:13:04.592686Z] 11:13:04     INFO -      Found by: given as instruction pointer in context
[task 2017-06-06T11:13:04.594819Z] 11:13:04     INFO -   1  libxul.so!mozilla::dom::binding_detail::FastEventHandlerNonNull::~FastEventHandlerNonNull [RootingAPI.h:8adc00c59534 : 631 + 0x8]
[task 2017-06-06T11:13:04.597170Z] 11:13:04     INFO -      rbx = 0x00007fcbd913ad60   rbp = 0x00007fff76b513a0
[task 2017-06-06T11:13:04.600481Z] 11:13:04     INFO -      rsp = 0x00007fff76b51380   r12 = 0x00007fcbd913ad78
[task 2017-06-06T11:13:04.602558Z] 11:13:04     INFO -      r13 = 0x00007fcbd913ad70   r14 = 0x0000000000000003
[task 2017-06-06T11:13:04.604845Z] 11:13:04     INFO -      r15 = 0x00007fcbd91c5128   rip = 0x00007fcbed43983d
[task 2017-06-06T11:13:04.608480Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.610531Z] 11:13:04     INFO -   2  libxul.so!SuspectAfterShutdown [nsCycleCollector.cpp:8adc00c59534 : 3992 + 0x5]
[task 2017-06-06T11:13:04.612535Z] 11:13:04     INFO -      rbx = 0x00007fcbd913ad60   rbp = 0x00007fff76b513d0
[task 2017-06-06T11:13:04.614617Z] 11:13:04     INFO -      rsp = 0x00007fff76b513b0   r12 = 0x00007fcbda5dd400
[task 2017-06-06T11:13:04.620624Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000003
[task 2017-06-06T11:13:04.622863Z] 11:13:04     INFO -      r15 = 0x00007fcbd91c5128   rip = 0x00007fcbec4cead5
[task 2017-06-06T11:13:04.624972Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.626994Z] 11:13:04     INFO -   3  libxul.so!mozilla::dom::CallbackObject::Release [nsISupportsImpl.h:8adc00c59534 : 245 + 0x5]
[task 2017-06-06T11:13:04.629105Z] 11:13:04     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff76b513f0
[task 2017-06-06T11:13:04.631088Z] 11:13:04     INFO -      rsp = 0x00007fff76b513e0   r12 = 0x00007fcbda5dd400
[task 2017-06-06T11:13:04.633459Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000003
[task 2017-06-06T11:13:04.636491Z] 11:13:04     INFO -      r15 = 0x00007fcbd91c5128   rip = 0x00007fcbedb37449
[task 2017-06-06T11:13:04.640428Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.642545Z] 11:13:04     INFO -   4  libxul.so!mozilla::JSEventHandler::~JSEventHandler [JSEventHandler.h:8adc00c59534 : 155 + 0x10]
[task 2017-06-06T11:13:04.644601Z] 11:13:04     INFO -      rbx = 0x00007fcbd913adc0   rbp = 0x00007fff76b51410
[task 2017-06-06T11:13:04.646657Z] 11:13:04     INFO -      rsp = 0x00007fff76b51400   r12 = 0x00007fcbda5dd400
[task 2017-06-06T11:13:04.652500Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000003
[task 2017-06-06T11:13:04.654502Z] 11:13:04     INFO -      r15 = 0x00007fcbd91c5128   rip = 0x00007fcbedc6536b
[task 2017-06-06T11:13:04.656449Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.658469Z] 11:13:04     INFO -   5  libxul.so!mozilla::JSEventHandler::DeleteCycleCollectable [JSEventHandler.cpp:8adc00c59534 : 48 + 0x5]
[task 2017-06-06T11:13:04.660405Z] 11:13:04     INFO -      rbx = 0x00007fcbd913adc0   rbp = 0x00007fff76b51430
[task 2017-06-06T11:13:04.662351Z] 11:13:04     INFO -      rsp = 0x00007fff76b51420   r12 = 0x00007fcbda5dd400
[task 2017-06-06T11:13:04.664339Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000003
[task 2017-06-06T11:13:04.666325Z] 11:13:04     INFO -      r15 = 0x00007fcbd91c5128   rip = 0x00007fcbedc67299
[task 2017-06-06T11:13:04.672461Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.674546Z] 11:13:04     INFO -   6  libxul.so!SuspectAfterShutdown [nsCycleCollector.cpp:8adc00c59534 : 3992 + 0x5]
[task 2017-06-06T11:13:04.676523Z] 11:13:04     INFO -      rbx = 0x00007fcbd913adc0   rbp = 0x00007fff76b51460
[task 2017-06-06T11:13:04.678619Z] 11:13:04     INFO -      rsp = 0x00007fff76b51440   r12 = 0x00007fcbda5dd400
[task 2017-06-06T11:13:04.680555Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000003
[task 2017-06-06T11:13:04.682509Z] 11:13:04     INFO -      r15 = 0x00007fcbd91c5128   rip = 0x00007fcbec4cead5
[task 2017-06-06T11:13:04.684419Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.686458Z] 11:13:04     INFO -   7  libxul.so!mozilla::JSEventHandler::Release [nsISupportsImpl.h:8adc00c59534 : 245 + 0x5]
[task 2017-06-06T11:13:04.688584Z] 11:13:04     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff76b51480
[task 2017-06-06T11:13:04.692505Z] 11:13:04     INFO -      rsp = 0x00007fff76b51470   r12 = 0x00007fcbda5dd400
[task 2017-06-06T11:13:04.694673Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000003
[task 2017-06-06T11:13:04.696702Z] 11:13:04     INFO -      r15 = 0x00007fcbd91c5128   rip = 0x00007fcbedc645f9
[task 2017-06-06T11:13:04.700396Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.702635Z] 11:13:04     INFO -   8  libxul.so!nsTArray_Impl<mozilla::EventListenerManager::Listener, nsTArrayInfallibleAllocator>::RemoveElementsAt [CallbackObject.h:8adc00c59534 : 542 + 0xf]
[task 2017-06-06T11:13:04.704700Z] 11:13:04     INFO -      rbx = 0x00007fcbda5dd388   rbp = 0x00007fff76b514c0
[task 2017-06-06T11:13:04.706654Z] 11:13:04     INFO -      rsp = 0x00007fff76b51490   r12 = 0x00007fcbda5dd400
[task 2017-06-06T11:13:04.712526Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000003
[task 2017-06-06T11:13:04.714758Z] 11:13:04     INFO -      r15 = 0x00007fcbd91c5128   rip = 0x00007fcbedc72b2f
[task 2017-06-06T11:13:04.716924Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.718959Z] 11:13:04     INFO -   9  libxul.so!mozilla::EventListenerManager::RemoveAllListeners [nsTArray.h:8adc00c59534 : 1738 + 0x5]
[task 2017-06-06T11:13:04.720933Z] 11:13:04     INFO -      rbx = 0x00007fcbd91c5110   rbp = 0x00007fff76b514e0
[task 2017-06-06T11:13:04.722887Z] 11:13:04     INFO -      rsp = 0x00007fff76b514d0   r12 = 0x00007fcbd91c5120
[task 2017-06-06T11:13:04.725022Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x00007fcbd9351e78
[task 2017-06-06T11:13:04.727361Z] 11:13:04     INFO -      r15 = 0x00007fcbd9351e88   rip = 0x00007fcbedc72bb3
[task 2017-06-06T11:13:04.732471Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.734858Z] 11:13:04     INFO -  10  libxul.so!mozilla::DOMEventTargetHelper::~DOMEventTargetHelper [DOMEventTargetHelper.cpp:8adc00c59534 : 96 + 0x5]
[task 2017-06-06T11:13:04.737073Z] 11:13:04     INFO -      rbx = 0x00007fcbd9351c00   rbp = 0x00007fff76b51500
[task 2017-06-06T11:13:04.738975Z] 11:13:04     INFO -      rsp = 0x00007fff76b514f0   r12 = 0x00007fcbd6e98240
[task 2017-06-06T11:13:04.740968Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x00007fcbd9351e78
[task 2017-06-06T11:13:04.742914Z] 11:13:04     INFO -      r15 = 0x00007fcbd9351e88   rip = 0x00007fcbedc5a6b2
[task 2017-06-06T11:13:04.745076Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.748620Z] 11:13:04     INFO -  11  libxul.so!mozilla::dom::XMLHttpRequestMainThread::~XMLHttpRequestMainThread [XMLHttpRequestEventTarget.h:8adc00c59534 : 27 + 0x28]
[task 2017-06-06T11:13:04.750624Z] 11:13:04     INFO -      rbx = 0x00007fcbd9351c00   rbp = 0x00007fff76b51550
[task 2017-06-06T11:13:04.752596Z] 11:13:04     INFO -      rsp = 0x00007fff76b51510   r12 = 0x00007fcbd6e98240
[task 2017-06-06T11:13:04.756472Z] 11:13:04     INFO -      r13 = 0x0000000000000000   r14 = 0x00007fcbd9351e78
[task 2017-06-06T11:13:04.758480Z] 11:13:04     INFO -      r15 = 0x00007fcbd9351e88   rip = 0x00007fcbee3b4e9d
[task 2017-06-06T11:13:04.760498Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.762788Z] 11:13:04     INFO -  12  libxul.so!mozilla::dom::XMLHttpRequestMainThread::~XMLHttpRequestMainThread [XMLHttpRequestMainThread.cpp:8adc00c59534 : 225 + 0x5]
[task 2017-06-06T11:13:04.768516Z] 11:13:04     INFO -      rbx = 0x00007fcbd9351c00   rbp = 0x00007fff76b51570
[task 2017-06-06T11:13:04.770541Z] 11:13:04     INFO -      rsp = 0x00007fff76b51560   r12 = 0x00007fcbd9351c00
[task 2017-06-06T11:13:04.772572Z] 11:13:04     INFO -      r13 = 0x00007fcbd9351c20   r14 = 0x0000000000000001
[task 2017-06-06T11:13:04.774551Z] 11:13:04     INFO -      r15 = 0x0000000000000000   rip = 0x00007fcbee3b4fb1
[task 2017-06-06T11:13:04.776468Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.778546Z] 11:13:04     INFO -  13  libxul.so!mozilla::DOMEventTargetHelper::Release [DOMEventTargetHelper.cpp:8adc00c59534 : 85 + 0x9]
[task 2017-06-06T11:13:04.780519Z] 11:13:04     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff76b515b0
[task 2017-06-06T11:13:04.784494Z] 11:13:04     INFO -      rsp = 0x00007fff76b51580   r12 = 0x00007fcbd9351c00
[task 2017-06-06T11:13:04.786545Z] 11:13:04     INFO -      r13 = 0x00007fcbd9351c20   r14 = 0x0000000000000001
[task 2017-06-06T11:13:04.788563Z] 11:13:04     INFO -      r15 = 0x0000000000000000   rip = 0x00007fcbedc48958
[task 2017-06-06T11:13:04.790465Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.792632Z] 11:13:04     INFO -  14  libxul.so!mozilla::dom::DeferredFinalizerImpl<nsISupports>::DeferredFinalize [nsCOMPtr.h:8adc00c59534 : 294 + 0x6]
[task 2017-06-06T11:13:04.796487Z] 11:13:04     INFO -      rbx = 0x00007fcbd91b0018   rbp = 0x00007fff76b51600
[task 2017-06-06T11:13:04.798470Z] 11:13:04     INFO -      rsp = 0x00007fff76b515c0   r12 = 0x0000000000000001
[task 2017-06-06T11:13:04.800457Z] 11:13:04     INFO -      r13 = 0x00007fcbd91b0000   r14 = 0x0000000000000001
[task 2017-06-06T11:13:04.802425Z] 11:13:04     INFO -      r15 = 0x0000000000000000   rip = 0x00007fcbec4c0cd2
[task 2017-06-06T11:13:04.808454Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.810734Z] 11:13:04     INFO -  15  libxul.so!mozilla::IncrementalFinalizeRunnable::ReleaseNow [CycleCollectedJSRuntime.cpp:8adc00c59534 : 1332 + 0xc]
[task 2017-06-06T11:13:04.812730Z] 11:13:04     INFO -      rbx = 0x00000df9121eb159   rbp = 0x00007fff76b51650
[task 2017-06-06T11:13:04.814740Z] 11:13:04     INFO -      rsp = 0x00007fff76b51610   r12 = 0x0000000000000001
[task 2017-06-06T11:13:04.816697Z] 11:13:04     INFO -      r13 = 0x00000000004c4b40   r14 = 0x00007fcbdfabd3c0
[task 2017-06-06T11:13:04.818640Z] 11:13:04     INFO -      r15 = 0x00007fcbdfabd3f8   rip = 0x00007fcbec4c9d2c
[task 2017-06-06T11:13:04.820520Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.822514Z] 11:13:04     INFO -  16  libxul.so!mozilla::CycleCollectedJSRuntime::OnGC [CycleCollectedJSRuntime.cpp:8adc00c59534 : 1455 + 0x8]
[task 2017-06-06T11:13:04.828558Z] 11:13:04     INFO -      rbx = 0x00007fcbdda82c00   rbp = 0x00007fff76b51680
[task 2017-06-06T11:13:04.830757Z] 11:13:04     INFO -      rsp = 0x00007fff76b51660   r12 = 0x0000000000000001
[task 2017-06-06T11:13:04.832751Z] 11:13:04     INFO -      r13 = 0x00007fcbdbedf000   r14 = 0x0000000000000000
[task 2017-06-06T11:13:04.834681Z] 11:13:04     INFO -      r15 = 0x00007fcbdbee2458   rip = 0x00007fcbec4c9fe0
[task 2017-06-06T11:13:04.836541Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.838510Z] 11:13:04     INFO -  17  libxul.so!js::gc::GCRuntime::gcCycle [jsgc.cpp:8adc00c59534 : 1470 + 0xe]
[task 2017-06-06T11:13:04.840466Z] 11:13:04     INFO -      rbx = 0x00007fcbdda82c00   rbp = 0x00007fff76b51760
[task 2017-06-06T11:13:04.842675Z] 11:13:04     INFO -      rsp = 0x00007fff76b51690   r12 = 0x00007fcbec4ca0a0
[task 2017-06-06T11:13:04.848481Z] 11:13:04     INFO -      r13 = 0x00007fcbf046a440   r14 = 0x0000000000000000
[task 2017-06-06T11:13:04.850447Z] 11:13:04     INFO -      r15 = 0x00007fcbdbee2458   rip = 0x00007fcbefa2fce1
[task 2017-06-06T11:13:04.852382Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.854368Z] 11:13:04     INFO -  18  libxul.so!js::gc::GCRuntime::collect [jsgc.cpp:8adc00c59534 : 6717 + 0xa]
[task 2017-06-06T11:13:04.856307Z] 11:13:04     INFO -      rbx = 0x0000000000000002   rbp = 0x00007fff76b51820
[task 2017-06-06T11:13:04.858247Z] 11:13:04     INFO -      rsp = 0x00007fff76b51770   r12 = 0x00007fcbdbee2000
[task 2017-06-06T11:13:04.860151Z] 11:13:04     INFO -      r13 = 0x00007fff76b517b0   r14 = 0x0000000000000001
[task 2017-06-06T11:13:04.862148Z] 11:13:04     INFO -      r15 = 0x00007fcbdbee2400   rip = 0x00007fcbefa3016c
[task 2017-06-06T11:13:04.864442Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.868520Z] 11:13:04     INFO -  19  libxul.so!js::gc::GCRuntime::gc [jsgc.cpp:8adc00c59534 : 6783 + 0x11]
[task 2017-06-06T11:13:04.870503Z] 11:13:04     INFO -      rbx = 0x00007fcbdbee2000   rbp = 0x00007fff76b51870
[task 2017-06-06T11:13:04.872509Z] 11:13:04     INFO -      rsp = 0x00007fff76b51830   r12 = 0x00007fcbdbee2400
[task 2017-06-06T11:13:04.874540Z] 11:13:04     INFO -      r13 = 0x00007fff76b51880   r14 = 0x00007fcbdbedf000
[task 2017-06-06T11:13:04.878738Z] 11:13:04     INFO -      r15 = 0x00007fcbdda81000   rip = 0x00007fcbefa30348
[task 2017-06-06T11:13:04.880920Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.882909Z] 11:13:04     INFO -  20  libxul.so!JSRuntime::destroyRuntime [Runtime.cpp:8adc00c59534 : 315 + 0xf]
[task 2017-06-06T11:13:04.884934Z] 11:13:04     INFO -      rbx = 0x00007fcbdbee2000   rbp = 0x00007fff76b518c0
[task 2017-06-06T11:13:04.888439Z] 11:13:04     INFO -      rsp = 0x00007fff76b51880   r12 = 0x00007fcbdbee2400
[task 2017-06-06T11:13:04.890411Z] 11:13:04     INFO -      r13 = 0x00007fff76b51880   r14 = 0x00007fcbdbedf000
[task 2017-06-06T11:13:04.892396Z] 11:13:04     INFO -      r15 = 0x00007fcbdda81000   rip = 0x00007fcbefb71039
[task 2017-06-06T11:13:04.896452Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.898578Z] 11:13:04     INFO -  21  libxul.so!js::DestroyContext [jscntxt.cpp:8adc00c59534 : 245 + 0x5]
[task 2017-06-06T11:13:04.900582Z] 11:13:04     INFO -      rbx = 0x00007fcbdbedf000   rbp = 0x00007fff76b51910
[task 2017-06-06T11:13:04.902522Z] 11:13:04     INFO -      rsp = 0x00007fff76b518d0   r12 = 0x0000000000000000
[task 2017-06-06T11:13:04.904623Z] 11:13:04     INFO -      r13 = 0x00007fcbdda810c0   r14 = 0x00007fcbdfa63d08
[task 2017-06-06T11:13:04.912523Z] 11:13:04     INFO -      r15 = 0x00007fcbdda81000   rip = 0x00007fcbef9cd5f5
[task 2017-06-06T11:13:04.914644Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.916777Z] 11:13:04     INFO -  22  libxul.so!mozilla::CycleCollectedJSContext::~CycleCollectedJSContext [CycleCollectedJSContext.cpp:8adc00c59534 : 101 + 0xc]
[task 2017-06-06T11:13:04.918739Z] 11:13:04     INFO -      rbx = 0x00007fcbdda81000   rbp = 0x00007fff76b519a0
[task 2017-06-06T11:13:04.921095Z] 11:13:04     INFO -      rsp = 0x00007fff76b51920   r12 = 0x00007fcbdda810f8
[task 2017-06-06T11:13:04.923039Z] 11:13:04     INFO -      r13 = 0x00007fcbdda810c0   r14 = 0x00007fcbdfa63d08
[task 2017-06-06T11:13:04.925011Z] 11:13:04     INFO -      r15 = 0x00007fcbdda81000   rip = 0x00007fcbec4cadfb
[task 2017-06-06T11:13:04.926900Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.932562Z] 11:13:04     INFO -  23  libxul.so!XPCJSContext::~XPCJSContext [XPCJSContext.cpp:8adc00c59534 : 608 + 0x5]
[task 2017-06-06T11:13:04.934561Z] 11:13:04     INFO -      rbx = 0x00007fcbdda81000   rbp = 0x00007fff76b519c0
[task 2017-06-06T11:13:04.936575Z] 11:13:04     INFO -      rsp = 0x00007fff76b519b0   r12 = 0x00007fcbdfa63e30
[task 2017-06-06T11:13:04.938528Z] 11:13:04     INFO -      r13 = 0x00007fcbdfaf8228   r14 = 0x00007fcbdfa63d08
[task 2017-06-06T11:13:04.940498Z] 11:13:04     INFO -      r15 = 0x0000000000000045   rip = 0x00007fcbecdbb631
[task 2017-06-06T11:13:04.942380Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.944399Z] 11:13:04     INFO -  24  libxul.so!nsXPConnect::~nsXPConnect [nsXPConnect.cpp:8adc00c59534 : 111 + 0x5]
[task 2017-06-06T11:13:04.948517Z] 11:13:04     INFO -      rbx = 0x00007fcbdbed8dc0   rbp = 0x00007fff76b519e0
[task 2017-06-06T11:13:04.950514Z] 11:13:04     INFO -      rsp = 0x00007fff76b519d0   r12 = 0x00007fcbdfa63e30
[task 2017-06-06T11:13:04.952539Z] 11:13:04     INFO -      r13 = 0x00007fcbdfaf8228   r14 = 0x00007fcbdfa63d08
[task 2017-06-06T11:13:04.954518Z] 11:13:04     INFO -      r15 = 0x0000000000000045   rip = 0x00007fcbecdf3aa8
[task 2017-06-06T11:13:04.956588Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.960532Z] 11:13:04     INFO -  25  libxul.so!nsXPConnect::Release [nsXPConnect.cpp:8adc00c59534 : 115 + 0x5]
[task 2017-06-06T11:13:04.962556Z] 11:13:04     INFO -      rbx = 0x00007fcbdbed8dc0   rbp = 0x00007fff76b51a00
[task 2017-06-06T11:13:04.964572Z] 11:13:04     INFO -      rsp = 0x00007fff76b519f0   r12 = 0x00007fcbdfa63e30
[task 2017-06-06T11:13:04.968442Z] 11:13:04     INFO -      r13 = 0x00007fcbdfaf8228   r14 = 0x00007fcbdfa63d08
[task 2017-06-06T11:13:04.970591Z] 11:13:04     INFO -      r15 = 0x0000000000000045   rip = 0x00007fcbecdf3b13
[task 2017-06-06T11:13:04.972545Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.974526Z] 11:13:04     INFO -  26  libxul.so!xpcModuleDtor [XPCModule.cpp:8adc00c59534 : 22 + 0x5]
[task 2017-06-06T11:13:04.976623Z] 11:13:04     INFO -      rbx = 0x00007fcbdda303c0   rbp = 0x00007fff76b51a10
[task 2017-06-06T11:13:04.979051Z] 11:13:04     INFO -      rsp = 0x00007fff76b51a10   r12 = 0x00007fcbdfa63e30
[task 2017-06-06T11:13:04.984586Z] 11:13:04     INFO -      r13 = 0x00007fcbdfaf8228   r14 = 0x00007fcbdfa63d08
[task 2017-06-06T11:13:04.986797Z] 11:13:04     INFO -      r15 = 0x0000000000000045   rip = 0x00007fcbecdbe5f9
[task 2017-06-06T11:13:04.988891Z] 11:13:04     INFO -      Found by: call frame info
[task 2017-06-06T11:13:04.991077Z] 11:13:04     INFO -  27  libxul.so!nsTArray_Impl<nsAutoPtr<nsComponentManagerImpl::KnownModule>, nsTArrayInfallibleAllocator>::RemoveElementsAt [nsComponentManager.h:8adc00c59534 : 229 + 0x2]
[task 2017-06-06T11:13:04.993097Z] 11:13:04     INFO -      rbx = 0x00007fcbdda303c0   rbp = 0x00007fff76b51a60
[task 2017-06-06T11:13:04.995096Z] 11:13:04     INFO -      rsp = 0x00007fff76b51a20   r12 = 0x00007fcbdfa63e30
[task 2017-06-06T11:13:04.997498Z] 11:13:04     INFO -      r13 = 0x00007fcbdfaf8228   r14 = 0x00007fcbdfa63d08
[task 2017-06-06T11:13:05.000525Z] 11:13:05     INFO -      r15 = 0x0000000000000045   rip = 0x00007fcbec51f1ec
[task 2017-06-06T11:13:05.004456Z] 11:13:05     INFO -      Found by: call frame info
[task 2017-06-06T11:13:05.006496Z] 11:13:05     INFO -  28  libxul.so!nsComponentManagerImpl::Shutdown [nsTArray.h:8adc00c59534 : 1738 + 0x5]
[task 2017-06-06T11:13:05.008525Z] 11:13:05     INFO -      rbx = 0x00007fcbdfaf8140   rbp = 0x00007fff76b51a80
[task 2017-06-06T11:13:05.010633Z] 11:13:05     INFO -      rsp = 0x00007fff76b51a70   r12 = 0x00007fff76b51ab0
[task 2017-06-06T11:13:05.016512Z] 11:13:05     INFO -      r13 = 0x00007fff76b51a9f   r14 = 0x00007fcbd6e4d240
[task 2017-06-06T11:13:05.018563Z] 11:13:05     INFO -      r15 = 0x00007fcbec4e7120   rip = 0x00007fcbec51faa9
[task 2017-06-06T11:13:05.020527Z] 11:13:05     INFO -      Found by: call frame info
[task 2017-06-06T11:13:05.022533Z] 11:13:05     INFO -  29  libxul.so!mozilla::ShutdownXPCOM [XPCOMInit.cpp:8adc00c59534 : 1007 + 0x5]
[task 2017-06-06T11:13:05.024555Z] 11:13:05     INFO -      rbx = 0x00007fff76b51ac0   rbp = 0x00007fff76b51b00
[task 2017-06-06T11:13:05.026680Z] 11:13:05     INFO -      rsp = 0x00007fff76b51a90   r12 = 0x00007fff76b51ab0
[task 2017-06-06T11:13:05.032131Z] 11:13:05     INFO -      r13 = 0x00007fff76b51a9f   r14 = 0x00007fcbd6e4d240
[task 2017-06-06T11:13:05.034306Z] 11:13:05     INFO -      r15 = 0x00007fcbec4e7120   rip = 0x00007fcbec55096f
[task 2017-06-06T11:13:05.036332Z] 11:13:05     INFO -      Found by: call frame info
[task 2017-06-06T11:13:05.038505Z] 11:13:05     INFO -  30  libxul.so!XRE_XPCShellMain [XPCShellImpl.cpp:8adc00c59534 : 1550 + 0x7]
[task 2017-06-06T11:13:05.040569Z] 11:13:05     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff76b51fb0
[task 2017-06-06T11:13:05.042702Z] 11:13:05     INFO -      rsp = 0x00007fff76b51b10   r12 = 0x0000000000000000
[task 2017-06-06T11:13:05.044837Z] 11:13:05     INFO -      r13 = 0x00007fcbdbedf000   r14 = 0x00007fcbdbedf000
[task 2017-06-06T11:13:05.046994Z] 11:13:05     INFO -      r15 = 0x00007fcbdfa18138   rip = 0x00007fcbecdefaf8
[task 2017-06-06T11:13:05.052544Z] 11:13:05     INFO -      Found by: call frame info
[task 2017-06-06T11:13:05.054768Z] 11:13:05     INFO -  31  xpcshell!main [xpcshell.cpp:8adc00c59534 : 68 + 0x14]
[task 2017-06-06T11:13:05.056938Z] 11:13:05     INFO -      rbx = 0x0000000000000002   rbp = 0x00007fff76b52000
[task 2017-06-06T11:13:05.058957Z] 11:13:05     INFO -      rsp = 0x00007fff76b51fc0   r12 = 0x00007fcbdfa70170
[task 2017-06-06T11:13:05.061040Z] 11:13:05     INFO -      r13 = 0x00007fff76b520e0   r14 = 0x0000000000000000
[task 2017-06-06T11:13:05.063163Z] 11:13:05     INFO -      r15 = 0x0000000000000000   rip = 0x0000000000405686
[task 2017-06-06T11:13:05.068457Z] 11:13:05     INFO -      Found by: call frame info
[task 2017-06-06T11:13:05.070661Z] 11:13:05     INFO -  32  libc-2.23.so + 0x20830
[task 2017-06-06T11:13:05.072648Z] 11:13:05     INFO -      rbx = 0x0000000000000000   rbp = 0x0000000000420860
[task 2017-06-06T11:13:05.074654Z] 11:13:05     INFO -      rsp = 0x00007fff76b52010   r12 = 0x00000000004058cc
[task 2017-06-06T11:13:05.076656Z] 11:13:05     INFO -      r13 = 0x00007fff76b520e0   r14 = 0x0000000000000000
[task 2017-06-06T11:13:05.078591Z] 11:13:05     INFO -      r15 = 0x0000000000000000   rip = 0x00007fcbe87cf830
[task 2017-06-06T11:13:05.080632Z] 11:13:05     INFO -      Found by: call frame info
[task 2017-06-06T11:13:05.084433Z] 11:13:05     INFO -  33  xpcshell + 0x5620
[task 2017-06-06T11:13:05.086564Z] 11:13:05     INFO -      rsp = 0x00007fff76b52030   rip = 0x0000000000405620
[task 2017-06-06T11:13:05.088535Z] 11:13:05     INFO -      Found by: stack scanning
[task 2017-06-06T11:13:05.092367Z] 11:13:05     INFO -  34  xpcshell + 0x58cc
[task 2017-06-06T11:13:05.094360Z] 11:13:05     INFO -      rsp = 0x00007fff76b52048   rip = 0x00000000004058cc
[task 2017-06-06T11:13:05.096272Z] 11:13:05     INFO -      Found by: stack scanning
[task 2017-06-06T11:13:05.098159Z] 11:13:05     INFO -  35  xpcshell + 0x5620
[task 2017-06-06T11:13:05.104353Z] 11:13:05     INFO -      rsp = 0x00007fff76b52098   rip = 0x0000000000405620
[task 2017-06-06T11:13:05.106509Z] 11:13:05     INFO -      Found by: stack scanning
[task 2017-06-06T11:13:05.108433Z] 11:13:05     INFO -  36  xpcshell!pthread_atfork + 0x20
[task 2017-06-06T11:13:05.110358Z] 11:13:05     INFO -      rsp = 0x00007fff76b520a0   rip = 0x0000000000420850
[task 2017-06-06T11:13:05.112208Z] 11:13:05     INFO -      Found by: stack scanning
[task 2017-06-06T11:13:05.114056Z] 11:13:05     INFO -  37  xpcshell + 0x58cc
[task 2017-06-06T11:13:05.115955Z] 11:13:05     INFO -      rsp = 0x00007fff76b520b8   rip = 0x00000000004058cc
[task 2017-06-06T11:13:05.117902Z] 11:13:05     INFO -      Found by: stack scanning
[task 2017-06-06T11:13:05.119936Z] 11:13:05     INFO -  38  xpcshell!_start + 0x29
[task 2017-06-06T11:13:05.124481Z] 11:13:05     INFO -      rsp = 0x00007fff76b520d0   rip = 0x00000000004058f5
[task 2017-06-06T11:13:05.126399Z] 11:13:05     INFO -      Found by: stack scanning

Failure log OS X: https://treeherder.mozilla.org/logviewer.html#?job_id=104866492&repo=mozilla-inbound
>TEST-UNEXPECTED-FAIL | dom/push/test/xpcshell/test_permissions.js | xpcshell return code: 1
>TEST-UNEXPECTED-FAIL | browser/components/migration/tests/unit/test_fx_telemetry.js | xpcshell return code: 1
Flags: needinfo?(jcoppeard)
(Assignee)

Comment 4

4 months ago
The problem seems to be that destructors running after JS engine shutdown are triggering barriers and crashing.

Maybe we can trace any roots from the embedding and clear them at shutdown time (the things they point to are going to go away regardless).  Andrew, what do you think?  Or is this a leak situation that shouldn't be happening anyway?
Flags: needinfo?(jcoppeard) → needinfo?(continuation)
Well, this gets into the territory of hiding leaks by breaking cycles. I don't remember exactly the implications of that. I also don't remember if we actually do leak checking in XPCShell tests.
Flags: needinfo?(continuation)
Keywords: triage-deferred
Priority: -- → P3
(Assignee)

Updated

4 days ago
Depends on: 1407593
You need to log in before you can comment on or make changes to this bug.