Closed Bug 1369828 Opened 4 years ago Closed 4 years ago
Intermittent stylo native-theme/492155-4
.html == native-theme/492155-4 .html | image comparison, max difference: 1, number of differing pixels: 1
59 bytes, text/x-review-board-request
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=104135478&repo=autoland https://queue.taskcluster.net/v1/task/blEudiCtREmPZZYELplRfA/runs/0/artifacts/public/logs/live_backing.log https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/blEudiCtREmPZZYELplRfA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1 This started frequently failing on Stylo builds when bug 1367488 landed on autoland.
The failure is caused by a single color value difference of a single pixel at the edge of a scrollbar thumb. This is a benign difference that's consistent with e.g. the thumb being layerized in one image, and not in the other, and could plausibly have been caused by bug 1367488 since it potentially changes the visible region and clip rect on a thumb layer. Since the difference is benign, it should be appropriate to fuzz it away. However, I'm not sure where to insert a fuzzing annotation in this case, since the comparison being done in the failing test (492155-4.html == 492155-4.html) does not match what is in reftest.list (492155-4.html != about:blank). I assume there is something Stylo-specific going on here (like the page rendered with Stylo is being compared to the page rendered without Stylo), but I'm not sure whether to insert a fuzzing annotation in such a situation.
the fuzzy condition in this case would be fuzzy-if(styloVsGecko,1,1)
or even better, fuzzy-if(styloVsGecko,0-1,0-1) since it seems to be intermittent :)
Assignee: nobody → botond
Comment on attachment 8874001 [details] Bug 1369828 - Fuzz native-theme/492155-4.html during stylo-vs-gecko comparison. https://reviewboard.mozilla.org/r/145452/#review149376
Attachment #8874001 - Flags: review?(mstange) → review+
Went ahead and triggered autoland for this so I can get it included in my merge of autoland to mozilla-central tonight.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/60b41398d6c2 Fuzz native-theme/492155-4.html during stylo-vs-gecko comparison. r=mstange
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/mozilla-central/rev/43039280fe46 Fuzz native-theme/492155-4.html during stylo-vs-gecko comparison. r=mstange a=bustage
You need to log in before you can comment on or make changes to this bug.