Port bug 1369323 |Let's remove nsScriptSecurityManager::GetNoAppCodebasePrincipal| to TB

RESOLVED FIXED in Thunderbird 55.0

Status

Thunderbird
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Jorg K (GMT+2), Assigned: Jorg K (GMT+2))

Tracking

Trunk
Thunderbird 55.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
+++ This bug was initially created as a clone of Bug #1369323 +++
This method is just used by some ffos related addons.

===

Well, unfortunately this method is used in TB:
https://dxr.mozilla.org/comm-central/search?q=getNoAppCodebasePrincipal&redirect=false

and removing it now causes errors seen on treeherder here:
https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-macosx64/1496329232/comm-central_yosemite_r7_test-mozmill-bm133-tests1-macosx-build22.txt.gz

JavaScript error: chrome://messenger/content/newmailaccount/accountProvisioner.js, line 42: TypeError: Services.scriptSecurityManager.getNoAppCodebasePrincipal is not a function

Let's hope that the replacement
-          principal: Services.scriptSecurityManager.getNoAppCodebasePrincipal(targetURI)
+          principal: Services.scriptSecurityManager.createCodebasePrincipal(targetURI, {}),
will just work ;-)
(Assignee)

Comment 1

a year ago
Created attachment 8873940 [details] [diff] [review]
1369835-principal.patch
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
(Assignee)

Comment 2

a year ago
https://hg.mozilla.org/comm-central/rev/22d34b082d5c3b9498d424781b3b24e8f3c536f0
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.