1369890 - Port mochitest/scroll/test_zoom_text.html to browser test

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Eitan Isaacson [:eeejay]]

The test needs a new browser window and doesn't work well in an iframe. So this whole test should probably be a browser test.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Port mochitest/scroll/test_zoom_text.html to browser test. r?surkov

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8874024 [details] [diff] [review]
Port mochitest/scroll/test_zoom_text.html to browser test. r?surkov

Review of attachment 8874024 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/moz.build
@@ +37,5 @@
>    'tests/browser/states/browser.ini'
>  ]
>  
>  with Files("**"):
> +    BUG_COMPONENT = ("Core", "Disability Access APIs")

not sure what the change is here

::: accessible/tests/browser/scroll/browser.ini
@@ +2,5 @@
> +support-files =
> +  head.js
> +  !/accessible/tests/browser/events.js
> +  !/accessible/tests/browser/shared-head.js
> +  !/accessible/tests/mochitest/*.js

it'd be probably nicer to have a shared folder between mochitest and browser tests, for example, utils or something folder.

::: accessible/tests/browser/shared-head.js
@@ +208,5 @@
>        url = `${CURRENT_CONTENT_DIR}e10s/${doc}`;
>      } else {
>        // Assume it's a markup snippet.
> +      url = "data:text/html;charset=utf-8;base64,";
> +      url += btoa(

thank you :)

@@ +305,5 @@
> +  if (!interfaces) {
> +    return accessible;
> +  }
> +
> +  for (let iface of interfaces.filter(i => !(accessible instanceof i))) {

I see this part goes from common.js version, which was introduced in bug 1276972, where you were a reviewer :) Do you remember what is it for?

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to alexander :surkov from comment #2)
> Comment on attachment 8874024 [details] [diff] [review]
> Port mochitest/scroll/test_zoom_text.html to browser test. r?surkov
> 
> Review of attachment 8874024 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/moz.build
> @@ +37,5 @@
> >    'tests/browser/states/browser.ini'
> >  ]
> >  
> >  with Files("**"):
> > +    BUG_COMPONENT = ("Core", "Disability Access APIs")
> 
> not sure what the change is here

Auto-newline in editor, oops.

> 
> ::: accessible/tests/browser/scroll/browser.ini
> @@ +2,5 @@
> > +support-files =
> > +  head.js
> > +  !/accessible/tests/browser/events.js
> > +  !/accessible/tests/browser/shared-head.js
> > +  !/accessible/tests/mochitest/*.js
> 
> it'd be probably nicer to have a shared folder between mochitest and browser
> tests, for example, utils or something folder.

Bug 1372264.

> 
> ::: accessible/tests/browser/shared-head.js
> @@ +208,5 @@
> >        url = `${CURRENT_CONTENT_DIR}e10s/${doc}`;
> >      } else {
> >        // Assume it's a markup snippet.
> > +      url = "data:text/html;charset=utf-8;base64,";
> > +      url += btoa(
> 
> thank you :)

yw!

> 
> @@ +305,5 @@
> > +  if (!interfaces) {
> > +    return accessible;
> > +  }
> > +
> > +  for (let iface of interfaces.filter(i => !(accessible instanceof i))) {
> 
> I see this part goes from common.js version, which was introduced in bug
> 1276972, where you were a reviewer :) Do you remember what is it for?

I don't recall. I assume if it is instanceof, it is already queried to that interface, and you shouldn't need to do it twice. Don't know what the harm would be, though.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76fcf40c564b
Port mochitest/scroll/test_zoom_text.html to browser test. r=surkov

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=76fcf40c564b9bbd945d15bada25f04babe9730a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Failure log browser_caching_name.js : https://treeherder.mozilla.org/logviewer.html#?job_id=106403521&repo=mozilla-inbound
[task 2017-06-12T16:46:59.234741Z] 16:46:59     INFO - Entering test bound 
[task 2017-06-12T16:46:59.236815Z] 16:46:59     INFO - Buffered messages logged at 16:46:57
[task 2017-06-12T16:46:59.242798Z] 16:46:59     INFO - TEST-PASS | accessible/tests/browser/e10s/browser_caching_name.js | Accessible document present. - 
[task 2017-06-12T16:46:59.245485Z] 16:46:59     INFO - TEST-PASS | accessible/tests/browser/e10s/browser_caching_name.js | Wrong name of the accessible for ['td@id="tc" node', address: [object HTMLTableCellElement], role: cell, name: 'test2 test3', address: [xpconnect wrapped nsIAccessible]] - 
[task 2017-06-12T16:46:59.254899Z] 16:46:59     INFO - TEST-PASS | accessible/tests/browser/e10s/browser_caching_name.js | Wrong name of the accessible for ['td@id="tc" node', address: [object HTMLTableCellElement], role: cell, name: 'test1', address: [xpconnect wrapped nsIAccessible]] - 
[task 2017-06-12T16:46:59.257118Z] 16:46:59     INFO - TEST-PASS | accessible/tests/browser/e10s/browser_caching_name.js | Wrong name of the accessible for ['td@id="tc" node', address: [object HTMLTableCellElement], role: cell, name: 'test5', address: [xpconnect wrapped nsIAccessible]] - 
[task 2017-06-12T16:46:59.257418Z] 16:46:59     INFO - Leaving test bound 
[task 2017-06-12T16:46:59.266752Z] 16:46:59     INFO - Entering test bound 
[task 2017-06-12T16:46:59.270078Z] 16:46:59     INFO - TEST-PASS | accessible/tests/browser/e10s/browser_caching_name.js | Accessible document present. - 
[task 2017-06-12T16:46:59.271919Z] 16:46:59     INFO - TEST-PASS | accessible/tests/browser/e10s/browser_caching_name.js | Wrong name of the accessible for ['td@id="gc" node', address: [object HTMLTableCellElement], role: gridcell, name: 'test2 test3', address: [xpconnect wrapped nsIAccessible]] - 
[task 2017-06-12T16:46:59.280099Z] 16:46:59     INFO - TEST-PASS | accessible/tests/browser/e10s/browser_caching_name.js | Wrong name of the accessible for ['td@id="gc" node', address: [object HTMLTableCellElement], role: gridcell, name: 'test1', address: [xpconnect wrapped nsIAccessible]] - 
[task 2017-06-12T16:46:59.281918Z] 16:46:59     INFO - Buffered messages finished
[task 2017-06-12T16:46:59.287490Z] 16:46:59     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/e10s/browser_caching_name.js | Wrong name of the accessible for ['td@id="gc" node', address: [object HTMLTableCellElement], role: gridcell, name: 'This is a paragraph This is a link • Listitem1 • Listitem2', address: [xpconnect wrapped nsIAccessible]] - Got This is a paragraph This is a link • Listitem1 • Listitem2, expected This is a paragraph
[task 2017-06-12T16:46:59.290120Z] 16:46:59     INFO - Stack trace:
[task 2017-06-12T16:46:59.292845Z] 16:46:59     INFO - chrome://mochikit/content/browser-test.js:test_is:998
[task 2017-06-12T16:46:59.295273Z] 16:46:59     INFO - chrome://mochitests/content/a11y/accessible/tests/mochitest/name.js:testName:15
[task 2017-06-12T16:46:59.296788Z] 16:46:59     INFO - chrome://mochitests/content/browser/accessible/tests/browser/e10s/browser_caching_name.js:testSubtreeRule:389

Failure log browser_test_zoom_text.js: https://treeherder.mozilla.org/logviewer.html#?job_id=106409289&repo=mozilla-inbound
10:12:42     INFO - TEST-START | accessible/tests/browser/scroll/browser_test_zoom_text.js
10:12:43     INFO - TEST-INFO | started process screenshot
10:12:43     INFO - TEST-INFO | screenshot: exit 0
10:12:43     INFO - Buffered messages logged at 10:12:42
10:12:43     INFO - Entering test bound 
10:12:43     INFO - Buffered messages logged at 10:12:43
10:12:43     INFO - TEST-PASS | accessible/tests/browser/scroll/browser_test_zoom_text.js | Accessible document present. - 
10:12:43     INFO - Buffered messages finished
10:12:43     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/scroll/browser_test_zoom_text.js | Uncaught exception - [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAccessibleText.getCharacterExtents]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js :: testTextPos :: line 142"  data: no]
10:12:43     INFO - Stack trace:
10:12:43     INFO -     testTextPos@chrome://mochitests/content/a11y/accessible/tests/mochitest/layout.js:142:3
10:12:43     INFO -     runTests@chrome://mochitests/content/browser/accessible/tests/browser/scroll/browser_test_zoom_text.js:19:3
10:12:43     INFO -     async*addAccessibleTask/</<@chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:257:13
10:12:43     INFO -     async*this.BrowserTestUtils.withNewTab<@resource://testing-common/BrowserTestUtils.jsm:106:24
10:12:43     INFO -     addAccessibleTask/<@chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:233:11
10:12:43     INFO -     Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:806:21
10:12:43     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:801:9
10:12:43     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:714:7
10:12:43     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58c4cba8b8eb
Backed out changeset 76fcf40c564b for failing accessible/tests/browser/e10s/browser_caching_name.js on Linux and accessible/tests/browser/scroll/browser_test_zoom_text.js on Windows 7. r=backout

Comment 7

[Eitan Isaacson [:eeejay]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19695114c3f487de24dde5129f20682dc493cdb6

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/296fcae46c6f
Port mochitest/scroll/test_zoom_text.html to browser test. r=surkov

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/296fcae46c6f