1370104 - Crash in core::result::unwrap_failed<T> | webrender::renderer::Renderer::draw_tile_frame

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is 
report bp-53fc2e02-72a4-435d-b75e-401fc0170604.
=============================================================
Crashing Thread (9)
Frame 	Module 	Signature 	Source
0 	xul.dll 	std::panicking::rust_panic 	C:/projects/rust/src/libstd/panicking.rs:577
1 	xul.dll 	std::panicking::rust_panic_with_hook 	C:/projects/rust/src/libstd/panicking.rs:565
2 	xul.dll 	std::panicking::begin_panic<collections::string::String> 	C:/projects/rust/src/libstd/panicking.rs:511
3 	xul.dll 	std::panicking::begin_panic_fmt 	C:/projects/rust/src/libstd/panicking.rs:495
4 	xul.dll 	core::panicking::panic_fmt 	C:/projects/rust/src/libcore/panicking.rs:61
5 	xul.dll 	core::result::unwrap_failed<webrender::device::ShaderError> 	C:/projects/rust/src/libcore/macros.rs:29
6 	xul.dll 	webrender::renderer::Renderer::draw_tile_frame 	gfx/webrender/src/renderer.rs:2141
7 	xul.dll 	webrender_bindings::bindings::wr_renderer_render 	gfx/webrender_bindings/src/bindings.rs:771
8 	xul.dll 	mozilla::wr::RendererOGL::Render() 	gfx/webrender_bindings/RendererOGL.cpp:128
9 	xul.dll 	mozilla::wr::RenderThread::UpdateAndRender(WrWindowId) 	gfx/webrender_bindings/RenderThread.cpp:194
10 	xul.dll 	mozilla::wr::RenderThread::NewFrameReady(WrWindowId) 	gfx/webrender_bindings/RenderThread.cpp:132
11 	xul.dll 	mozilla::detail::RunnableMethodImpl<mozilla::dom::HTMLMediaElement::ChannelLoader* const, void ( mozilla::dom::HTMLMediaElement::ChannelLoader::*)(mozilla::dom::HTMLMediaElement*), 1, 0, mozilla::dom::HTMLMediaElement*>::Run() 	obj-firefox/dist/include/nsThreadUtils.h:1133
12 	xul.dll 	MessageLoop::RunTask(already_AddRefed<mozilla::Runnable>) 	ipc/chromium/src/base/message_loop.cc:361
13 	xul.dll 	MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask&&) 	ipc/chromium/src/base/message_loop.cc:369
14 	xul.dll 	MessageLoop::DoWork() 	ipc/chromium/src/base/message_loop.cc:444
15 	xul.dll 	base::MessagePumpDefault::Run(base::MessagePump::Delegate*) 	ipc/chromium/src/base/message_pump_default.cc:36
16 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc:231
17 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc:211
18 	xul.dll 	base::Thread::ThreadMain() 	ipc/chromium/src/base/thread.cc:180
19 	xul.dll 	`anonymous namespace'::ThreadFunc 	ipc/chromium/src/base/platform_thread_win.cc:28
20 	kernel32.dll 	BaseThreadInitThunk 	
21 	ntdll.dll 	RtlUserThreadStart

these crashes in the gpu process started appearing in 55.0a1 build 20170603030204.
this would be the changelog to the day before: https://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2017-06-02&tochange=43039280fe464869428f03b047bb7c762784f44b

Comment 2

[Sotaro Ikeda [:sotaro]]

The crahs might be related to the followings.

  https://github.com/servo/webrender/issues/1324
  https://github.com/servo/webrender/issues/1332

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Hi Dzmitry, can you take a look at the crashes? Sounds like they may be related to some of your changes in servo.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I have a try push going with the fixes to verify.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fe87f9cffb200966a770b77081d74f043acba38

Comment 5

[Kartikaya Gupta (email:[e-mail])]

This should be fixed in the Jun 6 windows nightly. I'll wait a bit to see if any crashes are reported and close this if not.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

No more crashes. Fixed by bug 1369152.