1370333 - Add support for browserAction.setPopup and browserAction.getPopup

Status: VERIFIED FIXED

(WebExtensions :: Android, enhancement, P2)

Description

[Matthew Wein [:mattw]]

MDN documentation: 
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction/getPopup
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction/setPopup

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1370333 - Add support for browserAction popup on Firefox for Android.

Review commit: https://reviewboard.mozilla.org/r/174456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174456/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8902792 [details]
Bug 1370333 - Add support for browserAction popup on Firefox for Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174456/diff/1-2/

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8902792 [details]
Bug 1370333 - Add support for browserAction popup on Firefox for Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174456/diff/2-3/

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8902792 [details]
Bug 1370333 - Add support for browserAction popup on Firefox for Android.

https://reviewboard.mozilla.org/r/174456/#review180546

::: mobile/android/components/extensions/test/mochitest/test_ext_activeTab_permission.html:390
(Diff revision 3)
> +  `;
> +
> +  let extension = ExtensionTestUtils.loadExtension({
> +    background,
> +    manifest: {
> +      "name": "PageAction Extension",

name should be BrowserAction?

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8902792 [details]
Bug 1370333 - Add support for browserAction popup on Firefox for Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/174456/diff/3-4/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/965791d09bdc
Add support for browserAction popup on Firefox for Android. r=mixedpuppy

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/965791d09bdc

Comment 9

[CosminB]

Attachment: Bug1370333.gif

This issue is verified as fixed on Fennec 57.0a1 (2017-09-07) under Android 6.0.1.

The browserAction.setPopup and browserAction.getPopup are working as expected.
The extension used for the testing is: https://addons-dev.allizom.org/en-US/firefox/addon/browseractionsetpopup-getpopup/ 

Please see the attached video.

Comment 10

[Will Bamberg [:wbamberg]]

I've updated compat tables for:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction/getPopup#Browser_compatibility
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction/setPopup#Browser_compatibility
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/browser_action#Browser_compatibility

...to indicate that Firefox for Android supports this from version 57.