Closed
Bug 1370333
Opened 7 years ago
Closed 7 years ago
Add support for browserAction.setPopup and browserAction.getPopup
Categories
(WebExtensions :: Android, enhancement, P2)
Tracking
(firefox57 verified)
VERIFIED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: mattw, Assigned: rpl)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [browserAction]triaged)
Attachments
(2 files)
MDN documentation: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction/getPopup https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction/setPopup
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8902792 -
Flags: review?(mixedpuppy)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8902792 [details] Bug 1370333 - Add support for browserAction popup on Firefox for Android. https://reviewboard.mozilla.org/r/174456/#review180546 ::: mobile/android/components/extensions/test/mochitest/test_ext_activeTab_permission.html:390 (Diff revision 3) > + `; > + > + let extension = ExtensionTestUtils.loadExtension({ > + background, > + manifest: { > + "name": "PageAction Extension", name should be BrowserAction?
Attachment #8902792 -
Flags: review?(mixedpuppy) → review+
Comment hidden (mozreview-request) |
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/965791d09bdc Add support for browserAction popup on Firefox for Android. r=mixedpuppy
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/965791d09bdc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
This issue is verified as fixed on Fennec 57.0a1 (2017-09-07) under Android 6.0.1. The browserAction.setPopup and browserAction.getPopup are working as expected. The extension used for the testing is: https://addons-dev.allizom.org/en-US/firefox/addon/browseractionsetpopup-getpopup/ Please see the attached video.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Keywords: dev-doc-needed
Comment 10•7 years ago
|
||
I've updated compat tables for: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction/getPopup#Browser_compatibility https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserAction/setPopup#Browser_compatibility https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/browser_action#Browser_compatibility ...to indicate that Firefox for Android supports this from version 57.
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•