Closed Bug 1370333 Opened 7 years ago Closed 7 years ago

Add support for browserAction.setPopup and browserAction.getPopup

Categories

(WebExtensions :: Android, enhancement, P2)

Unspecified
Android
enhancement

Tracking

(firefox57 verified)

VERIFIED FIXED
mozilla57
Tracking Status
firefox57 --- verified

People

(Reporter: mattw, Assigned: rpl)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [browserAction]triaged)

Attachments

(2 files)

Blocks: 1389911
Assignee: nobody → lgreco
No longer blocks: 1389911
Status: NEW → ASSIGNED
Depends on: 1389911, 1383160
Attachment #8902792 - Flags: review?(mixedpuppy)
Comment on attachment 8902792 [details]
Bug 1370333 - Add support for browserAction popup on Firefox for Android.

https://reviewboard.mozilla.org/r/174456/#review180546

::: mobile/android/components/extensions/test/mochitest/test_ext_activeTab_permission.html:390
(Diff revision 3)
> +  `;
> +
> +  let extension = ExtensionTestUtils.loadExtension({
> +    background,
> +    manifest: {
> +      "name": "PageAction Extension",

name should be BrowserAction?
Attachment #8902792 - Flags: review?(mixedpuppy) → review+
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/965791d09bdc
Add support for browserAction popup on Firefox for Android. r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/965791d09bdc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Attached image Bug1370333.gif
This issue is verified as fixed on Fennec 57.0a1 (2017-09-07) under Android 6.0.1.

The browserAction.setPopup and browserAction.getPopup are working as expected.
The extension used for the testing is: https://addons-dev.allizom.org/en-US/firefox/addon/browseractionsetpopup-getpopup/ 

Please see the attached video.
Status: RESOLVED → VERIFIED
Depends on: 1398127
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.