Closed Bug 1370421 Opened 2 years ago Closed 2 years ago

Bucketize metrics for build variations

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(4 files)

I'm pretty sure bug 1362148 added redundant reporting for some build variations, such as the minimum build toolchains. We should look for build tasks reporting into the same Perfherder bucket and add metadata to the mozharness config to differentiate the build configuration.
Yeah, bug 1362148 definitely resulted in some redundancy. I'll clean this up.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment on attachment 8875060 [details]
Bug 1370421 - Put base-toolchains builds into own perfherder bucket;

https://reviewboard.mozilla.org/r/146428/#review150906

::: testing/mozharness/mozharness/mozilla/building/buildbase.py:2063
(Diff revision 2)
>          if build_metrics:
>              perfherder_data['suites'].append(build_metrics)
>          perfherder_data['suites'].extend(self._load_sccache_stats())
>  
>          # Ensure all extra options for this configuration are present.
>          for opt in self.config.get('perfherder_extra_options', []):

Can we move all of the perfherder_extra_options flags from mozharness configs into PERFHERDER_EXTRA_OPTIONS in Taskcluster in the future?
Attachment #8875060 - Flags: review?(mshal) → review+
Comment on attachment 8875075 [details]
Bug 1370421 - Define Perfherder bucket for asan-fuzzing;

https://reviewboard.mozilla.org/r/146436/#review150908
Attachment #8875075 - Flags: review?(mshal) → review+
Comment on attachment 8875076 [details]
Bug 1370421 - Differentiate Perfherder buckets for Linux64 ASAN builds;

https://reviewboard.mozilla.org/r/146438/#review150910
Attachment #8875076 - Flags: review?(mshal) → review+
Comment on attachment 8875077 [details]
Bug 1370421 - Verify we don't write Perfherder data to same bucket;

https://reviewboard.mozilla.org/r/146440/#review150912
Attachment #8875077 - Flags: review?(mshal) → review+
Comment on attachment 8875060 [details]
Bug 1370421 - Put base-toolchains builds into own perfherder bucket;

https://reviewboard.mozilla.org/r/146428/#review150906

> Can we move all of the perfherder_extra_options flags from mozharness configs into PERFHERDER_EXTRA_OPTIONS in Taskcluster in the future?

Possibly. I considered doing that. But I think there are some gotchas to that approach and I want to spend a bit of time looking at things before I commit to it. Either way, it's follow-up territory.
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/378499da2030
Put base-toolchains builds into own perfherder bucket; r=mshal
https://hg.mozilla.org/integration/autoland/rev/d2289ec1f6d1
Define Perfherder bucket for asan-fuzzing; r=mshal
https://hg.mozilla.org/integration/autoland/rev/9a60cc7a38d1
Differentiate Perfherder buckets for Linux64 ASAN builds; r=mshal
https://hg.mozilla.org/integration/autoland/rev/0911969994df
Verify we don't write Perfherder data to same bucket; r=mshal
Depends on: 1428912
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.