1428912 - KeyError: u'name' in taskcluster/taskgraph/transforms/build_lints.py

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1428912 - Only keep track of job names for seen configs in build_lints.

When looking for perfherder data collection duplicates, we currently
keep full job objects references, which are then used in case an error
occurs, to display the job names of the duplicates.

But those job objects are yielded and may be modified by other
transforms, and presently, by the time a duplicate is found, the
corresponding job object has been modified such that it has no 'name'
key anymore, leading to a KeyError exception when trying to display
the duplicate error message.

So instead of keeping the job objects, which can change, and which we
don't have a real use for, just keep the job name.

Review commit: https://reviewboard.mozilla.org/r/211130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211130/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8940876 [details]
Bug 1428912 - Only keep track of job names for seen configs in build_lints.

https://reviewboard.mozilla.org/r/211130/#review217296

Good fix!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13dc722140a0
Only keep track of job names for seen configs in build_lints. r=dustin

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/13dc722140a0