1370466 - (stylo-wpt) [meta] stylo: Pass WPT

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, enhancement, P5)

Description

[Manish Goregaokar [:manishearth]]

We should pass all the WPT tests that Gecko passes


Test run with WPT enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=09c0a641034905c64e2675fee0cfbf49b845eff8&selectedJob=104445102

Comment 1

[Chris Peterson [:cpeterson]]

Shing had filed bug 1366972 for Stylo WPT failures. I'll resolve that bug as a duplicate of this one because Manish's test run is more recent and he has already filed some blocking bugs.

Comment 3

[Manish Goregaokar [:manishearth]]

https://github.com/servo/servo/issues/17181 , https://github.com/servo/servo/issues/17182


(This WPT run is also Shing's, I'm just analyzing the results and fixing things)

Comment 4

[Chris Peterson [:cpeterson]]

P5 because this is a meta bug. Fixing the WPT test failures, though, is obviously a high priority!

Comment 5

[Shing Lyu [:shinglyu]]

Attachment: List of failure

There are 3 big categories: CSSOM, Animation and WebVTT that is failing right now. Not sure if we've paid any attention to WebVTT before.

Comment 6

[Manish Goregaokar [:manishearth]]

The CSSOM ones are mostly being fixed by jyc's patches on servo, or were fixed already by me this week.

I haven't really looked at the animation ones.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Animation bugs for web platform test have been tracked in a google document.
Most of failure there will be fixed by bug 1339690, bug 1362897 and bug 1353966.

[1] https://docs.google.com/spreadsheets/d/1iDkLyj06ZnAFynoIRW8uawZsHNS7Fl_ZTO7sbqUDkTE/edit#gid=252449755

Comment 8

[Chris Peterson [:cpeterson]]

In yesterday's team meeting, Manish said he would try to enable WPT tests and annotate the expected failures (CSSOM, animations, etc).

Comment 9

[Manish Goregaokar [:manishearth]]

just needs james to push patches for bug 1370461

Comment 10

[Emilio Cobos Álvarez (:emilio)]

I don't think there's any point in leaving this open.