Closed Bug 1374432 Opened 3 years ago Closed 3 years ago

stylo: building but not enabling stylo results in test failures

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

I did a try push with my build-stylo-by-default (but not enabled) patches and got:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da77dcd01bfec27ad9957e0d481dfb8a424e56b1

The build failures are understood, and will be getting fixed.

The WPT tests for the regular--not stylo--Linux64 builds are completely orange.  I think whatever is communicating stylo-ness to the WPT framework should be keying off MOZ_STYLO_ENABLE, not MOZ_STYLO.

I think the same issue affects the mochitest-9 test failures in that same push.
It's using the `stylo` property in mozinfo.json. It would be very helpful for wpt if we can keep that information in the mozinfo files since that's where the variables in the expectation metdata files are populated from.
I think that means we should change the condition hereabouts:

http://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mozinfo.py#85

which also means that MOZ_STYLO_ENABLE should be exported as a substitution.  I can do that tomorrow if nobody beats me to it.
If we don't do this, various bits of test infrastructure will turn on when
stylo is merely built, not enabled, which will cause no end of orange and
unhappiness.
Attachment #8879528 - Flags: review?(james)
Attachment #8879528 - Flags: review?(james) → review+
Assignee: nobody → nfroyd
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/553d1437de14
enable stylo attribute for tests only if stylo is enabled; r=jgraham
https://hg.mozilla.org/mozilla-central/rev/553d1437de14
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.