Convert blur CSS filter to WebRender

RESOLVED FIXED in Firefox 58

Status

()

Core
Graphics: WebRender
P1
normal
RESOLVED FIXED
8 months ago
3 months ago

People

(Reporter: mrobinson, Assigned: mtseng)

Tracking

(Blocks: 3 bugs, {feature})

Trunk
mozilla58
feature
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 unaffected, firefox57 unaffected, firefox58 fixed)

Details

(Whiteboard: [wr-mvp] [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
Blocks: 1351131
Depends on: 1365972
This is going to require some more work in WebRender, because the Blur filter is currently unimplemented: https://github.com/servo/webrender/issues/1351.

Updated

7 months ago
Keywords: feature
Priority: -- → P3
Whiteboard: [gfx-noted]
Blocks: 1386665

Updated

4 months ago
Priority: P3 → P2
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
status-firefox56: --- → unaffected
status-firefox57: --- → unaffected
This will be needed to get decent facebook performance. The Blur filter is now implemented in WebRender so we should be able to hook up the Gecko side.
Blocks: 1403189
I'll work on this.
Assignee: nobody → mtseng

Updated

3 months ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: P2 → P1
The gecko glue code is easy. But there are some bugs in webrender, so we have some reftests failure if we turn on blur filter. I'm looking into it.
Created attachment 8920072 [details] [diff] [review]
wip.

Current wip.

MozReview-Commit-ID: 1hUqXsH1vCJ
Depends on: 1410359
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Attachment #8920072 - Attachment is obsolete: true
The WR bug only affect the precision of blur effect. We can land this with sightly large fuzzy value. Once WR has accurate blur effect we can tweak the fuzzy value again.

Comment 11

3 months ago
mozreview-review
Comment on attachment 8921335 [details]
Bug 1370564 - Add suppport for blur filter.

https://reviewboard.mozilla.org/r/192344/#review197500
Attachment #8921335 - Flags: review?(bugmail) → review+

Comment 12

3 months ago
mozreview-review
Comment on attachment 8921336 [details]
Bug 1370564 - Add fuzzy-if for some blur filter test cases in webrender.

https://reviewboard.mozilla.org/r/192346/#review197508
Attachment #8921336 - Flags: review?(bugmail) → review+
Can you list the WR issues that are tracking the WR implementation bugs? Just in a comment or as "see also" on this bug is fine, thanks.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #13)
> Can you list the WR issues that are tracking the WR implementation bugs?
> Just in a comment or as "see also" on this bug is fine, thanks.

Sure, please see https://github.com/servo/webrender/pull/1920

Comment 15

3 months ago
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66b6eee5b343
Add suppport for blur filter. r=kats
https://hg.mozilla.org/integration/autoland/rev/3ceb33adf5bc
Add fuzzy-if for some blur filter test cases in webrender. r=kats

Updated

3 months ago
https://hg.mozilla.org/mozilla-central/rev/66b6eee5b343
https://hg.mozilla.org/mozilla-central/rev/3ceb33adf5bc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Blocks: 1411813
Blocks: 1411819
You need to log in before you can comment on or make changes to this bug.