Closed Bug 1370564 Opened 3 years ago Closed 2 years ago

Convert blur CSS filter to WebRender

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: mrobinson, Assigned: mtseng)

References

(Blocks 1 open bug)

Details

(Keywords: feature, Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(2 files, 1 obsolete file)

No description provided.
This is going to require some more work in WebRender, because the Blur filter is currently unimplemented: https://github.com/servo/webrender/issues/1351.
Keywords: feature
Priority: -- → P3
Whiteboard: [gfx-noted]
Priority: P3 → P2
Whiteboard: [gfx-noted] → [wr-mvp] [gfx-noted]
This will be needed to get decent facebook performance. The Blur filter is now implemented in WebRender so we should be able to hook up the Gecko side.
Blocks: 1403189
I'll work on this.
Assignee: nobody → mtseng
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: P2 → P1
The gecko glue code is easy. But there are some bugs in webrender, so we have some reftests failure if we turn on blur filter. I'm looking into it.
Attached patch wip. (obsolete) — Splinter Review
Current wip.

MozReview-Commit-ID: 1hUqXsH1vCJ
Depends on: 1410359
Attachment #8920072 - Attachment is obsolete: true
The WR bug only affect the precision of blur effect. We can land this with sightly large fuzzy value. Once WR has accurate blur effect we can tweak the fuzzy value again.
Comment on attachment 8921336 [details]
Bug 1370564 - Add fuzzy-if for some blur filter test cases in webrender.

https://reviewboard.mozilla.org/r/192346/#review197508
Attachment #8921336 - Flags: review?(bugmail) → review+
Can you list the WR issues that are tracking the WR implementation bugs? Just in a comment or as "see also" on this bug is fine, thanks.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #13)
> Can you list the WR issues that are tracking the WR implementation bugs?
> Just in a comment or as "see also" on this bug is fine, thanks.

Sure, please see https://github.com/servo/webrender/pull/1920
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66b6eee5b343
Add suppport for blur filter. r=kats
https://hg.mozilla.org/integration/autoland/rev/3ceb33adf5bc
Add fuzzy-if for some blur filter test cases in webrender. r=kats
https://hg.mozilla.org/mozilla-central/rev/66b6eee5b343
https://hg.mozilla.org/mozilla-central/rev/3ceb33adf5bc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.