Closed Bug 1411813 Opened 4 years ago Closed 4 years ago

Investigate why facebook still use software rendering for blur filter.

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: mtseng, Assigned: mtseng)

References

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(1 file)

Per bug 1403189 comment 1, we still use software rendering for blur filter.
Whiteboard: [wr-mvp] [gfx-noted] → [wr-mvp] [triage] [gfx-noted]
That's because facebook use blur filter with opacity < 1.0. We'll fallback here https://searchfox.org/mozilla-central/source/layout/painting/nsDisplayList.cpp#9592

I'll check if we can relax this condition.
Comment on attachment 8922259 [details]
Bug 1411813 - Don't fallback nsDisplayFilter if opacity is present.

https://reviewboard.mozilla.org/r/193302/#review198554

::: commit-message-64bab:1
(Diff revision 1)
> +Bug 1411813 - Don't fallback nsDisplayFilter if opacity is presence. r=kats

s/presence/present/
Attachment #8922259 - Flags: review?(bugmail) → review+
Status: NEW → ASSIGNED
Whiteboard: [wr-mvp] [triage] [gfx-noted] → [wr-mvp] [gfx-noted]
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/76eee0a0c764
Don't fallback nsDisplayFilter if opacity is present. r=kats
https://hg.mozilla.org/mozilla-central/rev/76eee0a0c764
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
I still see us hitting the software blur code on facebook when there video's visible.
Flags: needinfo?(mtseng)
Yes. I'll check it.
Status: RESOLVED → REOPENED
Flags: needinfo?(mtseng)
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
I test it again. I turned on "gfx.webrender.highlight-painted-layers". But I saw the blur doesn't hit the fallback. Would you mind check it again?
Flags: needinfo?(jmuizelaar)
Yeah, I'm still seeing a massive slowdown when I have video playings. With paint flashing turned on there's definitely something flashing in the bottom right corner.
Flags: needinfo?(jmuizelaar)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #11)
> bottom right corner.

of the videos.
After debugging, the bottom right corner is "filter: drop-shadow(0px 0 12px rgba(0, 0, 0, .7));". I'll create another for tracking converting filter drop-shadow.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Create bug 1415034 for tracking drop-shadow.
You need to log in before you can comment on or make changes to this bug.