1370716 - Error on console when browserAction button is pressed with no background script

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P5)

Description

[Mike Kaply [:mkaply]]

The following code in background.js should add a context menu to the toolbar button menu:

      chrome.contextMenus.create({
        "title": "Import Friends",
        "contexts": ["browser_action"],
        "id": "import_friends",
        "onclick": function(clickData) {
            alert('here');
        }
      });

When you right click on the button in the toolbar, you get an error in ext-contextMenus.js at line 130

item is undefined.

Comment 1

[Mike Kaply [:mkaply]]

This line:

http://searchfox.org/mozilla-central/source/browser/components/extensions/ext-contextMenus.js#99

const root = gRootItems.get(contextData.extension);

in buildActionContextMenu is returning null.

Comment 2

[Tomislav Jovanovic :zombie]

Is this the only code in the whole extension?  (If not, can you attach a minimal STR extension please?)

Are you adding menu items from other contexts?

Comment 3

[Mike Kaply [:mkaply]]

Sorry, I'm in mid development so I misunderstood what was happening here.

I don't have a background script added yet, but every time the button is pressed there is an error.

So the bug seems to be that if you don't have a background script, we still try to add context menus (and show an error on the console)

Sorry for the confusion.

Comment 4

[Tomislav Jovanovic :zombie]

In that case, unless you are testing in Nightly, this is likely bug 1362445.

Comment 5

[Tomislav Jovanovic :zombie]

or perhaps not.

Comment 6

[Tomislav Jovanovic :zombie]

Attachment: Bug 1370716 - Only try to add _action menus if extension has permission

Review commit: https://reviewboard.mozilla.org/r/165364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165364/

Comment 7

[Tomislav Jovanovic :zombie]

So the issue is when the extension doesn't use menus (doesn't ask for the permission), the menus initialization [1] never happens, so we shouldn't even try to add _action context menus in that case.

1) http://searchfox.org/mozilla-central/source/browser/components/extensions/ext-menus.js#621

Comment 8

[Tomislav Jovanovic :zombie]

Comment on attachment 8894276 [details]
Bug 1370716 - Only try to add _action menus if extension has permission

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165364/diff/1-2/

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8894276 [details]
Bug 1370716 - Only try to add _action menus if extension has permission

https://reviewboard.mozilla.org/r/165364/#review170838

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f41f31b5299
Only try to add _action menus if extension has permission r=mixedpuppy

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6f41f31b5299

Comment 12

[CosminB]

Attachment: Bug1370716.zip

I can reproduce this issue on Firefox 55.0a1 (20170606030207) under Wind 7 64-bit.

This issue is verified as fixed on Firefox 57.0b14 (20171102181127) and Firefox 58.0a1 (2017-11-02) under Wind 7 64-bit and Mac OS X 10.13.

There is no error in the browser console when you right click on the browser_action that has no background script added.

Please see the attached video.