Clicking WebExtension buttons doesn't close the overflow panel

NEW
Unassigned

Status

()

Firefox
Toolbars and Customization
P2
normal
17 days ago
2 days ago

People

(Reporter: Gijs, Unassigned, NeedInfo)

Tracking

({regression})

53 Branch
regression
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox53 unaffected, firefox54 unaffected, firefox55 disabled, firefox56 affected)

Details

(Whiteboard: [photon-structure])

(Reporter)

Description

17 days ago
STR:

1. install a webextension that has a button that doesn't have a subview, e.g. https://addons.mozilla.org/en-US/firefox/addon/instapaper-official/

2. resize the window so the button ends up in the overflow panel

3. open the overflow panel

4. click the add-on button

ER:
panel closes

AR:
panel stays open


This is a regression - it worked on 54/53.
Flags: qe-verify+
(Reporter)

Updated

17 days ago
Blocks: 1370986

Updated

16 days ago
Priority: -- → P3
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
(Reporter)

Comment 1

11 days ago
The issue here is that these buttons have type=view (which implies they will show their own sub-panel thing), which means the CustomizableUI code doesn't close them itself (instead, it tries to show a view for them). It's not clear to me why this works at all in the main menupanel on non-photon today. I think when I reviewed bug 1217129 I assumed browser_action buttons always had a view, not just some of the time... Shane, do you know why this isn't already broken / what would be a reasonably-scoped fix for this?
Blocks: 1217129
status-firefox55: affected → disabled
status-firefox56: --- → affected
tracking-firefox55: ? → ---
Flags: needinfo?(mixedpuppy)
Keywords: regressionwindow-wanted
Is there a type=button or something like that...we should be able to easily do that.
Flags: needinfo?(mixedpuppy) → needinfo?(gijskruitbosch+bugs)
(Reporter)

Comment 3

11 days ago
(In reply to Shane Caraveo (:mixedpuppy) from comment #2)
> Is there a type=button or something like that...we should be able to easily
> do that.

Yes, but you can't update the widget specification after the fact, and from what I understand WebExtensions can attach/detach their views at will...

My question remains: how does this currently work, when buttons without views are in the main (hamburger) menupanel, if indeed it does?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mixedpuppy)
Priority: P3 → P2
Whiteboard: [reserve-photon-structure] → [photon-structure]
You need to log in before you can comment on or make changes to this bug.