Closed Bug 1370973 Opened 3 years ago Closed 3 years ago

Add support for CONNECT proxy (add LWP::Protocol::connect)

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: dylan)

References

Details

Attachments

(1 file)

PR
44 bytes, text/x-github-pull-request
dylan
: review+
Details | Review
Right now we're using the older http-based squid proxy, which means that Bugzilla->params->{proxy_url} is set to something like http://dc-proxy.
Because squid doesn't support SNI (and some other SSL features) this means that we can't connect to sites that use SNI.

This has meant:

1) GitHub patches can't be viewed in attachments
2) auth delegation doesn't work to things on Heroku.

To use the CONNECT proxy feature, it is simple enough to change the configuration of proxy_url to connect://dc-proxy, but this requires LWP::Protocol::connect.

This bug adds that dependency.
Attached file PR
Attachment #8875845 - Flags: review?(rsoderberg)
Comment on attachment 8875845 [details] [review]
PR

r+ from atoll on the github PR.

To git@github.com:mozilla-bteam/bmo.git
   0a7f9d271..03bc18296  master -> master
Attachment #8875845 - Flags: review?(rsoderberg) → review+
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.