Closed Bug 1370978 Opened 2 years ago Closed 2 years ago

Enable av1 decoding in Nightly on mac and linux

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Unblock testing of av1 decoding by enabling it for nightly only on the two of our four platforms where it builds.
Assignee: nobody → giles
Comment on attachment 8875372 [details]
Bug 1370978 - Enable av1 decoding in Nightly on macOS and Linux.

https://reviewboard.mozilla.org/r/146798/#review150852
Attachment #8875372 - Flags: review?(nfroyd) → review+
Comment on attachment 8875372 [details]
Bug 1370978 - Enable av1 decoding in Nightly on macOS and Linux.

https://reviewboard.mozilla.org/r/146798/#review151518

r+ with micro-nit (that you may choose to ignore if you don't have the time for that, as it's not that important)

::: commit-message-87f16:3
(Diff revision 1)
> +Enable av1 decoding with the aom reference library on nightly
> +build where it's working so we can get wider testing.

To be nit-picky, it seems you don't exactly "Enable av1 ... where it's working", but instead "Enable av1 ... except where it's not working yet".
Attachment #8875372 - Flags: review?(gsquelart) → review+
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a344042d76e9
Enable av1 decoding in Nightly on macOS and Linux. r=froydnj,gerald
https://hg.mozilla.org/mozilla-central/rev/a344042d76e9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
FYI, once it was enabled, coverity found ~50 defects in this component.
I can grant access if needed (and I created a component just for aom code
https://scan.coverity.com/projects/firefox?tab=overview
You need to log in before you can comment on or make changes to this bug.