1370978 - Enable av1 decoding in Nightly on mac and linux

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Ralph Giles (:rillian)]

Unblock testing of av1 decoding by enabling it for nightly only on the two of our four platforms where it builds.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1370978 - Enable av1 decoding in Nightly on macOS and Linux.

Enable av1 decoding with the aom reference library on nightly
build where it's working so we can get wider testing.

Review commit: https://reviewboard.mozilla.org/r/146798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146798/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8875372 [details]
Bug 1370978 - Enable av1 decoding in Nightly on macOS and Linux.

https://reviewboard.mozilla.org/r/146798/#review150852

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8875372 [details]
Bug 1370978 - Enable av1 decoding in Nightly on macOS and Linux.

https://reviewboard.mozilla.org/r/146798/#review151518

r+ with micro-nit (that you may choose to ignore if you don't have the time for that, as it's not that important)

::: commit-message-87f16:3
(Diff revision 1)
> +Enable av1 decoding with the aom reference library on nightly
> +build where it's working so we can get wider testing.

To be nit-picky, it seems you don't exactly "Enable av1 ... where it's working", but instead "Enable av1 ... except where it's not working yet".

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8875372 [details]
Bug 1370978 - Enable av1 decoding in Nightly on macOS and Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146798/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a344042d76e9
Enable av1 decoding in Nightly on macOS and Linux. r=froydnj,gerald

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a344042d76e9

Comment 7

[Sylvestre Ledru [:Sylvestre]]

FYI, once it was enabled, coverity found ~50 defects in this component.
I can grant access if needed (and I created a component just for aom code
https://scan.coverity.com/projects/firefox?tab=overview