1371093 - Remove redundant tooltool manifest definitions from mozharness

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium] OoO until Dec 30]

Attachment: Bug 1371093 - Remove now redundant tooltool manifest definitions from mozharness.

Bug 1356952 defined tooltool manifest at the taskcluster job definition.
This makes many definitions from mozharness now redundant.

While this would ideally have been done in bug 1356952, some of those
definitions are likely to still be used by some buildbot job or some
obscure taskcluster job seldomly triggered. Preparing for the
possibility that this might burn some jobs, making this removal
backout-able independently allows other work to happen on top of bug
1356952 without the risk of everything having to be backed out because
of some random bustage.

Review commit: https://reviewboard.mozilla.org/r/146948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146948/

Comment 2

[Mike Hommey [:glandium] OoO until Dec 30]

Attachment: Validation script

Quite similar to what I did in bug 1356952.

Note that after this bug, there still remains a bunch of "tooltool_manifest_src"s in other mozharness configs, which indicate there's more work on this front for followups.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8875522 [details]
Bug 1371093 - Remove now redundant tooltool manifest definitions from mozharness.

https://reviewboard.mozilla.org/r/146948/#review151452

Looks good, though I didn't verify that these aren't still used somehow by buildbot. I assume automation will tell us that fairly quickly :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c8ab344a249
Remove now redundant tooltool manifest definitions from mozharness. r=mshal

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0c8ab344a249