Closed Bug 1356952 Opened 3 years ago Closed 2 years ago

Move as much tooltool manifest definitions as possible to taskcluster job definitions

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(5 files, 2 obsolete files)

There are two main reasons to want this:
- Jobs (like toolchain builds) can be optimized out and not run even when the tooltool manifest they use changes, because taskcluster can't know about them.
- The mach artifact toolchain additions from bug 1356529 want to find the tooltool manifest easily and currently has to find the info in mozharness configuration, which only really works for mozharness-based jobs, which is not all of them.
Assignee: nobody → mh+mozilla
Attached file Validation script (obsolete) —
FWIW, this is the script I used to validate that the manifests taken out of mozharness do match (except for the base-toolchains jobs, because that was exactly why they had their tooltool manifest defined in taskcluster definitions in the first place).

It requires bug 1356958 to be applied first to work for the Windows jobs.

(The script assumes it's in $topsrcdir, and runs with the virtualenv python)
Attachment #8875049 - Attachment mime type: text/x-python → text/plain
Attached file Validation script (obsolete) —
I had forgotten to account for variants.
Attachment #8875049 - Attachment is obsolete: true
Attachment #8875054 - Attachment mime type: text/x-python → text/plain
Attached file Validation script
And another adjustment for variants.
Attachment #8875054 - Attachment is obsolete: true
Depends on: 1370815
Comment on attachment 8875039 [details]
Bug 1356952 - Add tooltool manifests defined in mozharness configurations to taskcluster job definitions.

https://reviewboard.mozilla.org/r/146400/#review150892

These all look fine to me. Thanks for providing the validation script!
Attachment #8875039 - Flags: review?(mshal) → review+
Comment on attachment 8875040 [details]
Bug 1356952 - Use environment variable to define tooltool manifest in hazard builds.

https://reviewboard.mozilla.org/r/146402/#review150894
Attachment #8875040 - Flags: review?(mshal) → review+
Comment on attachment 8875041 [details]
Bug 1356952 - Use environment variable to define tooltool manifest in spidermonkey builds.

https://reviewboard.mozilla.org/r/146404/#review150896
Attachment #8875041 - Flags: review?(mshal) → review+
Comment on attachment 8875042 [details]
Bug 1356952 - Move tooltool manifests defined in toolchain build scripts to taskcluster job definitions.

https://reviewboard.mozilla.org/r/146406/#review150898
Attachment #8875042 - Flags: review?(mshal) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/bde62d05afec
Add tooltool manifests defined in mozharness configurations to taskcluster job definitions. r=mshal
https://hg.mozilla.org/integration/autoland/rev/0376305933bf
Use environment variable to define tooltool manifest in hazard builds. r=mshal
https://hg.mozilla.org/integration/autoland/rev/3d6e3b030c4f
Use environment variable to define tooltool manifest in spidermonkey builds. r=mshal
https://hg.mozilla.org/integration/autoland/rev/29d01be1fca2
Move tooltool manifests defined in toolchain build scripts to taskcluster job definitions. r=mshal
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.