Move as much tooltool manifest definitions as possible to taskcluster job definitions

RESOLVED FIXED in Firefox 55

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments, 2 obsolete attachments)

(Assignee)

Description

a year ago
There are two main reasons to want this:
- Jobs (like toolchain builds) can be optimized out and not run even when the tooltool manifest they use changes, because taskcluster can't know about them.
- The mach artifact toolchain additions from bug 1356529 want to find the tooltool manifest easily and currently has to find the info in mozharness configuration, which only really works for mozharness-based jobs, which is not all of them.
(Assignee)

Updated

a year ago
Assignee: nobody → mh+mozilla
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 5

a year ago
Created attachment 8875049 [details]
Validation script

FWIW, this is the script I used to validate that the manifests taken out of mozharness do match (except for the base-toolchains jobs, because that was exactly why they had their tooltool manifest defined in taskcluster definitions in the first place).

It requires bug 1356958 to be applied first to work for the Windows jobs.

(The script assumes it's in $topsrcdir, and runs with the virtualenv python)
(Assignee)

Updated

a year ago
Attachment #8875049 - Attachment mime type: text/x-python → text/plain
(Assignee)

Comment 6

a year ago
Created attachment 8875054 [details]
Validation script

I had forgotten to account for variants.
Attachment #8875049 - Attachment is obsolete: true
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8875054 - Attachment mime type: text/x-python → text/plain
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 15

a year ago
Created attachment 8875176 [details]
Validation script

And another adjustment for variants.
Attachment #8875054 - Attachment is obsolete: true
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Depends on: 1370815

Comment 20

a year ago
mozreview-review
Comment on attachment 8875039 [details]
Bug 1356952 - Add tooltool manifests defined in mozharness configurations to taskcluster job definitions.

https://reviewboard.mozilla.org/r/146400/#review150892

These all look fine to me. Thanks for providing the validation script!
Attachment #8875039 - Flags: review?(mshal) → review+

Comment 21

a year ago
mozreview-review
Comment on attachment 8875040 [details]
Bug 1356952 - Use environment variable to define tooltool manifest in hazard builds.

https://reviewboard.mozilla.org/r/146402/#review150894
Attachment #8875040 - Flags: review?(mshal) → review+

Comment 22

a year ago
mozreview-review
Comment on attachment 8875041 [details]
Bug 1356952 - Use environment variable to define tooltool manifest in spidermonkey builds.

https://reviewboard.mozilla.org/r/146404/#review150896
Attachment #8875041 - Flags: review?(mshal) → review+

Comment 23

a year ago
mozreview-review
Comment on attachment 8875042 [details]
Bug 1356952 - Move tooltool manifests defined in toolchain build scripts to taskcluster job definitions.

https://reviewboard.mozilla.org/r/146406/#review150898
Attachment #8875042 - Flags: review?(mshal) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 32

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/bde62d05afec
Add tooltool manifests defined in mozharness configurations to taskcluster job definitions. r=mshal
https://hg.mozilla.org/integration/autoland/rev/0376305933bf
Use environment variable to define tooltool manifest in hazard builds. r=mshal
https://hg.mozilla.org/integration/autoland/rev/3d6e3b030c4f
Use environment variable to define tooltool manifest in spidermonkey builds. r=mshal
https://hg.mozilla.org/integration/autoland/rev/29d01be1fca2
Move tooltool manifests defined in toolchain build scripts to taskcluster job definitions. r=mshal
(Assignee)

Updated

a year ago
Blocks: 1371093

Comment 33

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bde62d05afec
https://hg.mozilla.org/mozilla-central/rev/0376305933bf
https://hg.mozilla.org/mozilla-central/rev/3d6e3b030c4f
https://hg.mozilla.org/mozilla-central/rev/29d01be1fca2
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.