The mozilla icon at top of about:home should be shown at left-top under RTL languages

VERIFIED FIXED in Firefox 56

Status

()

Firefox
General
P1
normal
VERIFIED FIXED
3 months ago
2 months ago

People

(Reporter: rexboy, Assigned: rexboy)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-onboarding])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
The Mozilla icon of about:home is shown on the top right corner no matter what the language type it is. We should show it on the top left corner for RTL languages, just like what we do for the gear icon in about:newtab at top of the page.

One of the reason that we must fix it is we show an icon button for opening new onboarding experiences on the opposite side. If we don't support RTL in the right way the two icon stack together.

It should be an trivial one-line css changes, but not sure if we got other works to do.
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8875659 [details]
bug 1371201 - Show Mozilla icon at top of about:home at left-top under RTL direction.

https://reviewboard.mozilla.org/r/147078/#review151244
Attachment #8875659 - Flags: review?(dao+bmo) → review+

Updated

3 months ago
Assignee: nobody → rexboy
(Assignee)

Comment 3

3 months ago
Thank you Dao!

Adding some tags for project tracking.
Blocks: 1354046
Whiteboard: [photon-onboarding]

Updated

3 months ago
Flags: qe-verify+
QA Contact: jwilliams

Updated

2 months ago
Target Milestone: --- → Firefox 56

Updated

2 months ago
Status: NEW → ASSIGNED
Priority: -- → P1
(Assignee)

Updated

2 months ago
Keywords: checkin-needed

Comment 4

2 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a1a5084b3f88
Show Mozilla icon at top of about:home at left-top under RTL direction. r=dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a1a5084b3f88
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED

Comment 6

2 months ago
Operating System : Windows OS 64 bit 
Browser : Firefox Nightly 55.0
Bug Verified and Fixed

Bug Verification day [20170621]
Flags: needinfo?(jwilliams)
Per comment 6 and my findings I will change the status of this bug to Verified Fixed.
Status: RESOLVED → VERIFIED
Flags: needinfo?(jwilliams)
(Assignee)

Updated

2 months ago
Duplicate of this bug: 1371904
You need to log in before you can comment on or make changes to this bug.