Open Bug 1371661 Opened 7 years ago Updated 2 years ago

Google image search profile


(Core :: JavaScript: GC, enhancement, P3)

55 Branch
Windows 10



Performance Impact low


(Reporter: afilip, Unassigned)


(Blocks 1 open bug, )


(Keywords: perf, Whiteboard: [QRC][QRC_Analyzed])

2.Search for fox
3.Start Gecko profile
4.Click images 
5.Share profile

Gecko profile:
Miko, could you help to have first profiling? Thanks.
Assignee: nobody → mikokm
Flags: needinfo?(mikokm)
Although the profile display list creation times are pretty high (>5ms), nothing really stands out.

Filip: Would it be possible to get the profile with a higher sampling interval than 1ms (for example 0.3ms)?
Flags: needinfo?(mikokm) → needinfo?(afilip)
Hi Miko here is the profile with 0.3 interval :
Flags: needinfo?(afilip)
(In reply to Filip Andrei from comment #3)
> Hi Miko here is the profile with 0.3 interval :

Thank you. Unfortunately, the profile seems to be still missing some data, for example the segment here: is 20ms, but only 1.5ms is accounted for.
Could you please try increasing the profiler buffer size to something like 50MB to see if it makes a difference?
Flags: needinfo?(afilip)
I modified the buffer size to 540 mb and that is the max size i have on the Acer hardware
Flags: needinfo?(afilip)
Flags: needinfo?(mikokm)
Thank you Filip. Based on these profiles, there does not seem to be any obvious optimization opportunities.
Assignee: mikokm → nobody
Flags: needinfo?(mikokm) → needinfo?(afilip)
filip, could you help to provide more clues to show the performance issue? Or we could close the bug and wait another symptom shows up. Thanks.
I tooked another profile where i think that the slow response is more evidenced and the only based criteria is that is a lot slower than Chrome.Can you please take a look at this
Flags: needinfo?(afilip)
David, could you help to follow Filip's new profile in Comment 8? Thanks.
Assignee: nobody → dvander
Flags: needinfo?(dvander)
I don't really see anything actionable in this profile. It looks like the content process wants some information about cookies and is waiting for the UI to reply. The UI is spending a good deal of time running UI javascript and doing UI reflows/paints. Maybe "why do cookies need to contact the main thread" is a valid question, but maybe there is also a scheduling problem in the parent process.
Assignee: dvander → nobody
Depends on: 1382701
Filip, is it possible you were experiencing page faults when you took the profile in comment 8? How much RAM do you have and how many tabs do you think you had open?
Here's a profile of the steps in comment 0 with tweaked dom.ipc.processCount prefs so that there's only one content process, and the profiling interval set to 2ms.
These settings seem to produce profiles that have fewer gaps in them.

I've also enabled stylo.
Andreas, could you also help to continue the investigation? Thanks.
Assignee: nobody → afarre
Flags: needinfo?(afarre)
I'm currently on PTO. Can help out in the week after next. Keeping the needinfo set to remind me.
Hi Andreas, could you help the profiling? thanks.
I re-ran the test on the Acer hardware, again with profile interval set to 2 ms:

and I see a bunch of GeckoMain delays as well as a bunch of Content delays. If I'm reading the profile correctly the reasons seems to be ipc waiting for GC, CC, painting. Not sure what more to say.
Flags: needinfo?(afarre)
tracking under quantum flow
Component: General → JavaScript: GC
Whiteboard: [QRC][QRC_NeedAnalysis] → [qf][QRC][QRC_Analyzed]
Whiteboard: [qf][QRC][QRC_Analyzed] → [qf:p2][QRC][QRC_Analyzed]
Keywords: perf
Assignee: afarre → nobody
Priority: -- → P3
Whiteboard: [qf:p2][QRC][QRC_Analyzed] → [qf:p3][QRC][QRC_Analyzed]
Performance Impact: --- → P3
Whiteboard: [qf:p3][QRC][QRC_Analyzed] → [QRC][QRC_Analyzed]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.