Improve Sync Notification Titles

RESOLVED FIXED in Firefox 56

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rfeeley, Assigned: jeongkyu.kim, Mentored)

Tracking

({good-first-bug})

55 Branch
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Reviewed notification copy with Michelle as our titles are not consistently in title case.

from: browser/locales/en-US/chrome/browser/accounts.properties

Current:
syncStartNotification.title = Sync enabled
deviceDisconnectedNotification.title = Sync disconnected
tabArrivingNotification.title = Tab received
tabArrivingNotificationWithDevice.title = Tab from {device-name}
tabsArrivingNotification.title = Multiple tabs received

Proposed (just title case correction, except the last one):
syncStartNotification.title = Sync Enabled
deviceDisconnectedNotification.title = Sync Disconnected
tabArrivingNotification.title = Tab Received
tabArrivingNotificationWithDevice.title = Tab from {device-name}
tabsArrivingNotification.title = Tabs Received
Mentor: eoger
Keywords: good-first-bug
The first one was already fixed in bug 1370645 and the fourth one looks the same as current one. Thus the three items below are supposed to be changed, correct?

deviceDisconnectedNotification.title = Sync Disconnected
tabArrivingNotification.title = Tab Received
tabsArrivingNotification.title = Tabs Received

And the last one appears to need new string id. If then, do you have any suggestion?
Yeah that seems about right.
You could go for multipleTabsArrivingNotification.title
Assignee: nobody → jeongkyu.kim
Priority: -- → P3
Comment on attachment 8877129 [details]
Bug 1371676 - Improve Sync Notification Titles

https://reviewboard.mozilla.org/r/148470/#review152968

::: browser/locales/en-US/chrome/browser/accounts.properties:53
(Diff revision 1)
>  # The body for these is the URL of the tab recieved
> -tabArrivingNotification.title = Tab received
> +tabArrivingNotification.title = Tab Received
>  # LOCALIZATION NOTE (tabArrivingNotificationWithDevice.title) %S is the device name
>  tabArrivingNotificationWithDevice.title = Tab from %S
>  
> -tabsArrivingNotification.title = Multiple tabs received
> +multipleTabsArrivingNotification.title = Tabs Received

Looks like you forgot to change this too:
http://searchfox.org/mozilla-central/source/browser/components/nsBrowserGlue.js#2253
:)
Attachment #8877129 - Flags: review?(eoger)
My bad :) I forgot to search my changes through DXR. Let me fix the string in nsBrowserGlue.js.
Comment on attachment 8877129 [details]
Bug 1371676 - Improve Sync Notification Titles

https://reviewboard.mozilla.org/r/148470/#review152984

r+ with changes, thanks!

::: browser/locales/en-US/chrome/browser/accounts.properties:43
(Diff revision 2)
>  # LOCALIZATION NOTE (sendTabToAllDevices.menuitem)
>  # Displayed in the Send Tabs context menu when right clicking a tab, a page or a link.
>  sendTabToAllDevices.menuitem = All Devices
>  
>  # LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title,
>  # tabsArrivingNotification.title, unnamedTabsArrivingNotification2.body,

I think you have to change the identifier here too.
Attachment #8877129 - Flags: review?(eoger) → review+
Sorry for my late response :) I just updated my patch. Thanks!
Looks great, thanks!
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fab569b6389
Improve Sync Notification Titles r=eoger
https://hg.mozilla.org/mozilla-central/rev/9fab569b6389
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.