1371676 - Improve Sync Notification Titles

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P3)

Description

[Ryan Feeley [:rfeeley]]

Reviewed notification copy with Michelle as our titles are not consistently in title case.

from: browser/locales/en-US/chrome/browser/accounts.properties

Current:
syncStartNotification.title = Sync enabled
deviceDisconnectedNotification.title = Sync disconnected
tabArrivingNotification.title = Tab received
tabArrivingNotificationWithDevice.title = Tab from {device-name}
tabsArrivingNotification.title = Multiple tabs received

Proposed (just title case correction, except the last one):
syncStartNotification.title = Sync Enabled
deviceDisconnectedNotification.title = Sync Disconnected
tabArrivingNotification.title = Tab Received
tabArrivingNotificationWithDevice.title = Tab from {device-name}
tabsArrivingNotification.title = Tabs Received

Comment 1

[Jeongkyu Kim]

The first one was already fixed in bug 1370645 and the fourth one looks the same as current one. Thus the three items below are supposed to be changed, correct?

deviceDisconnectedNotification.title = Sync Disconnected
tabArrivingNotification.title = Tab Received
tabsArrivingNotification.title = Tabs Received

And the last one appears to need new string id. If then, do you have any suggestion?

Comment 2

[Edouard Oger [:eoger]]

Yeah that seems about right.
You could go for multipleTabsArrivingNotification.title

Comment 3

[Jeongkyu Kim]

Attachment: Bug 1371676 - Improve Sync Notification Titles

Review commit: https://reviewboard.mozilla.org/r/148470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148470/

Comment 4

[Edouard Oger [:eoger]]

Comment on attachment 8877129 [details]
Bug 1371676 - Improve Sync Notification Titles

https://reviewboard.mozilla.org/r/148470/#review152968

::: browser/locales/en-US/chrome/browser/accounts.properties:53
(Diff revision 1)
>  # The body for these is the URL of the tab recieved
> -tabArrivingNotification.title = Tab received
> +tabArrivingNotification.title = Tab Received
>  # LOCALIZATION NOTE (tabArrivingNotificationWithDevice.title) %S is the device name
>  tabArrivingNotificationWithDevice.title = Tab from %S
>  
> -tabsArrivingNotification.title = Multiple tabs received
> +multipleTabsArrivingNotification.title = Tabs Received

Looks like you forgot to change this too:
http://searchfox.org/mozilla-central/source/browser/components/nsBrowserGlue.js#2253
:)

Comment 5

[Jeongkyu Kim]

My bad :) I forgot to search my changes through DXR. Let me fix the string in nsBrowserGlue.js.

Comment 6

[Jeongkyu Kim]

Comment on attachment 8877129 [details]
Bug 1371676 - Improve Sync Notification Titles

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148470/diff/1-2/

Comment 7

[Edouard Oger [:eoger]]

Comment on attachment 8877129 [details]
Bug 1371676 - Improve Sync Notification Titles

https://reviewboard.mozilla.org/r/148470/#review152984

r+ with changes, thanks!

::: browser/locales/en-US/chrome/browser/accounts.properties:43
(Diff revision 2)
>  # LOCALIZATION NOTE (sendTabToAllDevices.menuitem)
>  # Displayed in the Send Tabs context menu when right clicking a tab, a page or a link.
>  sendTabToAllDevices.menuitem = All Devices
>  
>  # LOCALIZATION NOTE (tabArrivingNotification.title, tabArrivingNotificationWithDevice.title,
>  # tabsArrivingNotification.title, unnamedTabsArrivingNotification2.body,

I think you have to change the identifier here too.

Comment 8

[Jeongkyu Kim]

Comment on attachment 8877129 [details]
Bug 1371676 - Improve Sync Notification Titles

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148470/diff/2-3/

Comment 9

[Jeongkyu Kim]

Sorry for my late response :) I just updated my patch. Thanks!

Comment 10

[Edouard Oger [:eoger]]

Looks great, thanks!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fab569b6389
Improve Sync Notification Titles r=eoger

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9fab569b6389