Closed Bug 1371744 Opened 7 years ago Closed 7 years ago

Some padding on the legacy extensions page would be nice

Categories

(Toolkit :: Add-ons Manager, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla56
Tracking Status
firefox56 --- verified

People

(Reporter: andy+bugzilla, Assigned: aswan)

References

Details

(Whiteboard: triaged)

Attachments

(2 files)

The title "Legacy Extensions" has roughly 1em distance between it and the vertical divider. Other pages have a bigger padding. Jumping between the options make it a little jarring, but not critical.
Assignee: nobody → aswan
Priority: -- → P3
Whiteboard: triaged
Emanuela, how much spacing should there be here?
Flags: needinfo?(emanuela)
(In reply to Andrew Swan [:aswan] from comment #2)
> Emanuela, how much spacing should there be here?

It should be the same space of the Extension :) (on the inspector seems to be 48px)
Flags: needinfo?(emanuela)
Attachment #8881503 - Flags: review?(mstriemer)
The other panes have a grey box at the top for the descriptions [1]. Would that make sense here instead?

[1] https://www.dropbox.com/s/2o1b8bylltudwh2/Screenshot%202017-06-27%2014.47.37.png?dl=0
Here's how it would look [1]. I think there should be a period in the link text as well.

[1] https://www.dropbox.com/s/yhugy6m7lv60dj8/Screenshot%202017-06-27%2014.57.17.png?dl=0
The current appearance (with the exception of the missing padding) is based on the mockups from UX here:
https://mozilla.invisionapp.com/share/HUAUGBGWZ#/screens/227774578
Comment on attachment 8881503 [details]
Bug 1371744 Put a margin around the legacy page heading

https://reviewboard.mozilla.org/r/152650/#review157856

This matches the mock so r+ on that.

I think the link text should have a period as it does in the other panes. Also using the grey box seems more consistent but if we're moving to this style then that's cool.
Attachment #8881503 - Flags: review?(mstriemer) → review+
Oh thanks for catching the missing period.  I'll open a new bug for that because ... l10n.
Emanuela, do you want to weigh in on the discussion above before this gets landed?
Flags: needinfo?(emanuela)
Checked in with Emanuela, she prefers that we keep it like this.
Flags: needinfo?(emanuela)
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0573d09a93ae
Put a margin around the legacy page heading r=mstriemer
https://hg.mozilla.org/mozilla-central/rev/0573d09a93ae
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
I was able to reproduce the initial issue on Firefox 56.0a1 (2017-06-29) under Windows 10 64-bit.

Verified fixed on Firefox 56.0a1 (2017-07-10/11) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. See screenshot: https://www.screencast.com/t/HH9a0DtdJr
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.