1371744 - Some padding on the legacy extensions page would be nice

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Andy McKay]

Attachment: Screenshot 2017-06-09 10.21.10.png

The title "Legacy Extensions" has roughly 1em distance between it and the vertical divider. Other pages have a bigger padding. Jumping between the options make it a little jarring, but not critical.

Comment 2

[Andrew Swan [:aswan]]

Emanuela, how much spacing should there be here?

Comment 3

[emanuela [ux]]

(In reply to Andrew Swan [:aswan] from comment #2)
> Emanuela, how much spacing should there be here?

It should be the same space of the Extension :) (on the inspector seems to be 48px)

Comment 4

[Andrew Swan [:aswan]]

Attachment: Bug 1371744 Put a margin around the legacy page heading

Review commit: https://reviewboard.mozilla.org/r/152650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152650/

Comment 5

[Mark Striemer [:mstriemer]]

The other panes have a grey box at the top for the descriptions [1]. Would that make sense here instead?

[1] https://www.dropbox.com/s/2o1b8bylltudwh2/Screenshot%202017-06-27%2014.47.37.png?dl=0

Comment 6

[Mark Striemer [:mstriemer]]

Here's how it would look [1]. I think there should be a period in the link text as well.

[1] https://www.dropbox.com/s/yhugy6m7lv60dj8/Screenshot%202017-06-27%2014.57.17.png?dl=0

Comment 7

[Andrew Swan [:aswan]]

The current appearance (with the exception of the missing padding) is based on the mockups from UX here:
https://mozilla.invisionapp.com/share/HUAUGBGWZ#/screens/227774578

Comment 8

[Mark Striemer [:mstriemer]]

Comment on attachment 8881503 [details]
Bug 1371744 Put a margin around the legacy page heading

https://reviewboard.mozilla.org/r/152650/#review157856

This matches the mock so r+ on that.

I think the link text should have a period as it does in the other panes. Also using the grey box seems more consistent but if we're moving to this style then that's cool.

Comment 9

[Andrew Swan [:aswan]]

Oh thanks for catching the missing period.  I'll open a new bug for that because ... l10n.
Emanuela, do you want to weigh in on the discussion above before this gets landed?

Comment 10

[Andrew Swan [:aswan]]

Checked in with Emanuela, she prefers that we keep it like this.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0573d09a93ae
Put a margin around the legacy page heading r=mstriemer

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0573d09a93ae

Comment 13

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the initial issue on Firefox 56.0a1 (2017-06-29) under Windows 10 64-bit.

Verified fixed on Firefox 56.0a1 (2017-07-10/11) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. See screenshot: https://www.screencast.com/t/HH9a0DtdJr