1371809 - pass theme widget types as mozilla::ThemeWidgetType rather than uint8_t

Status: RESOLVED DUPLICATE of bug 1478391

(Core :: Graphics, enhancement, P5)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

As followup to bug 1367577, we should create a mozilla::ThemeWidgetType name that's a typedef to ThemeWidgetType, and start converting things that pass theme widget types around from using uint8_t to ThemeWidgetType.  We should probably *start* with the style data and finish with the nsITheme implementations, since then we should be able to avoid casting.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the first patch in the series should probably be something like this:
https://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/76d668dbcfa7/create-theme-widget-type-in-mozilla

The second patch or set of patches would probably involve converting nsStyleDisplay::mAppearance, which will probably be the hardest piece since it involves landing coordinated stylo patches.

Once that's done (and landed), work can proceed with conversion of code in nsIFrame etc., and then with the nsITheme interface and implementations.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This was fixed (all at once) in bug 1478391, and with a different name.