1382138 - stylo: make '-moz-appearance' animatable

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Daisuke Akatsuka (:daisuke)]

'-moz-appearance' should animate discretely.
To realize this, we will fix bug 1371809 at first.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1382138 - Part 1: Make -moz-appearance animatable.

Review commit: https://reviewboard.mozilla.org/r/168050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168050/

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1382138 - Part 2: Add -moz-appearance property to moz prefixed properties test.

Since we made -moz-appearance animatable, append to the moz prefixed properties
test.

Review commit: https://reviewboard.mozilla.org/r/168052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168052/

Comment 3

[Daisuke Akatsuka (:daisuke)]

I discussed with Brian.
In this time, we implement using non_upper_case_globals instead of fixing bug 1371809.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=386e7eef67b2ee1100e83369d2a68f765af438d9

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8896768 [details]
Bug 1382138 - Part 2: Add -moz-appearance property to moz prefixed properties test.

https://reviewboard.mozilla.org/r/168052/#review173178

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8896767 [details]
Bug 1382138 - Part 1: Make -moz-appearance animatable.

https://reviewboard.mozilla.org/r/168050/#review173180

Comment 6

[Hiroyuki Ikezoe (:hiro)]

(In reply to Daisuke Akatsuka (:daisuke) from comment #3)
> I discussed with Brian.
> In this time, we implement using non_upper_case_globals instead of fixing
> bug 1371809.

Would you mind explaining the reason why?  I think we don't need to rush to make this moz prefixed property animatable, I guess bug 1371809 (and depending one) could be fixed at least within a few weeks. There were unclear things in those bugs?

Comment 7

[Brian Birtles (:birtles, Feb 26~ parental leave)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #6)
> (In reply to Daisuke Akatsuka (:daisuke) from comment #3)
> > I discussed with Brian.
> > In this time, we implement using non_upper_case_globals instead of fixing
> > bug 1371809.
> 
> Would you mind explaining the reason why?  I think we don't need to rush to
> make this moz prefixed property animatable, I guess bug 1371809 (and
> depending one) could be fixed at least within a few weeks. There were
> unclear things in those bugs?

We need to drive P1/P2 Stylo bugs down quickly, ideally close to zero by the end of this week. Daisuke suggested it was going to take him quite a while to fix bug 1371809. Furthermore, since there's a good chance this is used in the wild and since it blocks turning on a few tests we shouldn't make bug 1371809 block this. Let's get the content fixed and tests turned on then tidy things up in a non-blocking follow-up.

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Servo PR 18066

Comment 9

[Brian Birtles (:birtles, Feb 26~ parental leave)]

When this lands, we can stop skipping mozilla/test_discrete-animations.html

Comment 10

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8896768 [details]
Bug 1382138 - Part 2: Add -moz-appearance property to moz prefixed properties test.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168052/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eb2225325f3
Part 2: Add -moz-appearance property to moz prefixed properties test. r=hiro

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1eb2225325f3