Add new Photon-themed download icon

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
2 months ago
2 months ago

People

(Reporter: sfoster, Assigned: sfoster)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-animation])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
The download icon changes to a narrower arrow with the progressbar line beneath it in Photon.

Updated

2 months ago
Flags: qe-verify?
Whiteboard: [photon-animation] → [photon-animation] [triage]
Comment hidden (mozreview-request)

Comment 2

2 months ago
mozreview-review
Comment on attachment 8876349 [details]
Bug 1371834 - Add arrow+bar download icon for MOZ_PHOTON_THEME.

https://reviewboard.mozilla.org/r/147742/#review152470

r=me with the one issue below fixed

::: browser/themes/shared/menuPanel.svg:34
(Diff revision 1)
> +#ifdef MOZ_PHOTON_THEME
> +  <path id="downloads" d="M248.7 26.1h-17.5c-1 0-1.8.8-1.8 1.8s.8 1.8 1.8 1.8h17.5c1 0 1.8-.8 1.8-1.8s-.8-1.8-1.8-1.8zm-10-2.2c.7.7 1.8.7 2.5 0l8.8-8.8c.7-.7.6-1.8-.1-2.5-.7-.6-1.7-.6-2.4 0l-5.8 5.8v-15c0-1-.8-1.8-1.8-1.8s-1.8.8-1.8 1.8v15l-5.8-5.8c-.7-.7-1.8-.6-2.5.1-.6.7-.6 1.7 0 2.4l8.9 8.8z"/>
> +#else

This shouldn't be necessary with Photon because the download button won't be customizable to the menu panel.

To be explicit about this, you can use
#ifndef MOZ_PHOTON_THEME
  ... old download icon ...
#endif
Attachment #8876349 - Flags: review?(jaws) → review+

Comment 3

2 months ago
mozreview-review-reply
Comment on attachment 8876349 [details]
Bug 1371834 - Add arrow+bar download icon for MOZ_PHOTON_THEME.

https://reviewboard.mozilla.org/r/147742/#review152470

> This shouldn't be necessary with Photon because the download button won't be customizable to the menu panel.
> 
> To be explicit about this, you can use
> #ifndef MOZ_PHOTON_THEME
>   ... old download icon ...
> #endif

On the other hand, we should probably leave this here and then when the patch is written to remove the ability to customize to the menu panel, that patch can remove both icon designs.

So, I'll drop this.

Comment 4

2 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07b11447b58f
Add arrow+bar download icon for MOZ_PHOTON_THEME. r=jaws

Comment 5

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/07b11447b58f
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Flags: qe-verify? → qe-verify+
Whiteboard: [photon-animation] [triage] → [photon-animation]

Updated

2 months ago
Iteration: --- → 56.1 - Jun 26
Priority: -- → P1
QA Contact: jwilliams
Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=5293e5f8935831e2e0d91ac9b69c1b473b3c0177&newProject=mozilla-central&newRev=c8f3df191e354062025352a45ac421e557ed324c

Seems good. :)
Depends on: 1373333

Comment 7

2 months ago
I have reproduced this bug with Nightly 55.0a1 (2017-06-09) on Windows 8, 64-bit.

The bug's fix is now verified on Latest Nightly 56.0a1 

Build ID 	20170615030208
User Agent 	Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170614]
Verifying per comment 7. My findings match Anika's.
Status: RESOLVED → VERIFIED

Updated

2 months ago
Flags: qe-verify+
(Assignee)

Updated

2 months ago
Blocks: 1375309
You need to log in before you can comment on or make changes to this bug.