1372094 - Add mozharness config for Firefox UI functional jobs on Windows

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Via bug 1371404 I added the firefox ui tests to Windows, and as bug shows we do not correctly specify the minidump stackwalk binay.

> 14:20:01     INFO - MINIDUMP_STACKWALK binary not found: /usr/local/bin/linux64-minidump_stackwalk

Due to that and maybe other broken configs we should provide a Windows specific configuration, or make the current one cross-platform compatible.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The path for the minidump stackwalk actually comes from the following file:

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/remove_executables.py

So maybe we don't need that many changes.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So by adding nothing specific to the mozharness config file for MINIDUMP_STACKWALK, the path gets set to:

> 15:40:21     INFO -  'MINIDUMP_SAVE_PATH': 'Z:\\task_1497281892\\build\\blobber_upload_dir',
> 15:40:21     INFO -  'MINIDUMP_STACKWALK': 'win32-minidump_stackwalk.exe',

So it misses the full path. This is because we only resolve the basename of the file, but do not try to find it in possible paths:

https://dxr.mozilla.org/mozilla-central/rev/2a63a6c35033b5cbc6c98cabc7657c7290284691/testing/mozharness/mozharness/mozilla/testing/testbase.py#758-762

Rob, do we automatically supply the stackwalk binary on Windows TC nodes? Or would test jobs have to explicitly retrieve it by using tooltool, and marking the file to be downloaded?

Comment 3

[Rob Thijssen [:grenade (EET/UTC+0300)]]

we don't currently install stackwalk on workers, but it's simple to add to the json manifests. if you can point me to a url for an installer artifact containing the binaries, i can add it quickly.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: dummy crash

Review commit: https://reviewboard.mozilla.org/r/150852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150852/

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1372094 - Add mozharness config for firefox-ui test jobs on Windows.

Review commit: https://reviewboard.mozilla.org/r/150854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150854/

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8879552 [details]
Bug 1372094 - Add mozharness config for firefox-ui test jobs on Windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150854/diff/1-2/

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, the last revision works fine now which makes use of similar entries as the Marionette unit tests for Windows. The minidump stacktrace is correctly downloaded, and executed:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de0f62d300600e1e6586f72bf516a217499efd9a&selectedJob=108536634

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8879552 [details]
Bug 1372094 - Add mozharness config for firefox-ui test jobs on Windows.

https://reviewboard.mozilla.org/r/150854/#review155664

thanks for this!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79f9200b6cc1
Add mozharness config for firefox-ui test jobs on Windows. r=jmaher

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/79f9200b6cc1