Closed Bug 1372152 Opened 4 years ago Closed 4 years ago

GetShellFolderPath should use SHGetKnownFolderPath instead of SHGetKnownFolderIDList

Categories

(Toolkit :: Startup and Profile System, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Iteration:
56.1 - Jun 26
Tracking Status
firefox56 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-performance])

Attachments

(1 file, 1 obsolete file)

(Florian Quèze from bug 1363398 comment #20)

> GetShellFolderPath is still more expensive than I would like, but I don't
> see any obvious expensive main thread IO anymore. SHParseDisplayName seems
> to be about a third of what remains, so calling SHGetKnownFolderPath instead
> of SHGetKnownFolderIDList may be a good thing to do in a follow-up.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8876693 - Flags: review?(jmathies)
Attached patch PatchSplinter Review
(same patch, without trailing whitespace)
Attachment #8876694 - Flags: review?(jmathies)
Attachment #8876693 - Attachment is obsolete: true
Attachment #8876693 - Flags: review?(jmathies)
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P1
Iteration: --- → 55.7 - Jun 12
Comment on attachment 8876694 [details] [diff] [review]
Patch

Review of attachment 8876694 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8876694 - Flags: review?(jmathies) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/321e5a4f37b5
GetShellFolderPath should use SHGetKnownFolderPath instead of SHGetKnownFolderIDList, r=jimm.
Iteration: 55.7 - Jun 12 → 56.1 - Jun 26
https://hg.mozilla.org/mozilla-central/rev/321e5a4f37b5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1372881
No longer depends on: 1372881
== Change summary for alert #7261 (as of June 13 2017 06:40 UTC) ==

Improvements:

 15%  sessionrestore_no_auto_restore windows7-32 opt e10s     930.00 -> 791.92
 15%  sessionrestore windows7-32 pgo e10s                     705.64 -> 602.67
 14%  sessionrestore windows7-32 opt e10s                     895.83 -> 766.08
 14%  sessionrestore_no_auto_restore windows7-32 pgo e10s     737.72 -> 631.33
  4%  tresize windows7-32 pgo e10s                            11.05 -> 10.62
  3%  tresize windows7-32 opt e10s                            12.70 -> 12.29

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7261
You need to log in before you can comment on or make changes to this bug.