1372260 - Change stub installer file name to "Firefox Installer"

Status: VERIFIED FIXED

(Release Engineering :: Release Automation, enhancement, P1)

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

At bare minimum, we need to change:

1. Beetmover s3 key
https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/configs/beetmover/en_us_signing.yml.tmpl#l20
https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/configs/beetmover/repacks.yml.tmpl#l31

2. Bouncer paths update to reflect the S3 locations

https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/configs/releases/bouncer_firefox_beta.py#l68
https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/configs/releases/bouncer_firefox_devedition.py#l69
https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/configs/releases/bouncer_firefox_release.py#l68
https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/configs/releases/dev_bouncer_firefox_beta.py#l67

I don't think we need to change anything build related but I could be wrong.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

i) Comment 1 reflects reality for beta and release.

ii) For nightly, there's nothing to change in tcmigration as we don't have Windows yet enabled in Taskcluster (at least, not at beetmover level). So most likely the current nightly stub installers (such as http://archive.mozilla.org/pub/firefox/nightly/2017/06/2017-06-02-03-02-04-mozilla-central/firefox-55.0a1.en-US.win32.installer-stub.exe for example) come from BB. It'd be a build change most likely, :Callek suggested https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/package-name.mk#58.

Comment 3

[Romain Testard [:RT]]

Chris, could this be implemented by the time FF55 hits release?
This is part of the new onboarding requirements and the streamlined stub that comes along with this ships in release 55.
We believe this can have significant impact on the "Open stub installer" / "Download stub installer" ratio, which itself is critical to a good onboarding.

Comment 4

[Rail Aliiev [:rail]]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #1)
> At bare minimum, we need to change:

I think you summarized it properly. We also may need to let mozdowloader people know about these changes.

Comment 5

[Chris AtLee [:catlee]]

Yeah, I think we can get this done in the 55 Beta cycle.

Just to be clear, the proposal is to rename "Firefox Setup Step $VERSION.exe" as "Firefox Installer.exe".?

Is there any need to rename the full installer? It's currently named "Firefox Setup $VERSION.exe"

Julien, is this something we can take on 55?

Comment 6

[Romain Testard [:RT]]

(In reply to Chris AtLee [:catlee] from comment #5)
> Yeah, I think we can get this done in the 55 Beta cycle.
> 
> Just to be clear, the proposal is to rename "Firefox Setup Step
> $VERSION.exe" as "Firefox Installer.exe".?
Yes
> 
> Is there any need to rename the full installer? It's currently named
> "Firefox Setup $VERSION.exe"
Not at this point. We only care about the stub installer since it's what get used on the new onboarding experience.
The audience for full installers is very different and the naming in place currently may not need changing.

Comment 7

[Julien Cristau [:jcristau]]

Matt, do you know of anything that would care about the file name of the stub installer and that might break if we change it?

Comment 8

[Molly Howell (she/her) (mostly inactive)]

I don't know of anything that depends on that file name.

Comment 9

[Julien Cristau [:jcristau]]

OK, sounds like something we can still do in 55 then.

Comment 10

[Romain Testard [:RT]]

For info we just got the final funnelcake results where this was tested and the improvements have been quite significant regarding the "install attempt"/"download events" ratio (7% improvement). 
It would be good to see that improvement translate on the release installs for 55.
Also is a separate bug required to implement the same change on Beta or should this bug cover it too?

Comment 11

[Rail Aliiev [:rail]]

The change should just ride the trains, nothing special for beta/release.

Mihai, can you look at this please.

Comment 12

[Chris AtLee [:catlee]]

(In reply to Rail Aliiev [:rail] ⌚️ET from comment #11)
> The change should just ride the trains, nothing special for beta/release.
> 
> Mihai, can you look at this please.

We will need to uplift this to Beta (55).

Comment 13

[Rail Aliiev [:rail]]

I completely out of date with our versioning :D

Comment 14

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Rail Aliiev [:rail] ⌚️ET from comment #11)
> The change should just ride the trains, nothing special for beta/release.
> 
> Mihai, can you look at this please.

Yes, of course! Am PTO this week but will grab this over the week-end/next week.

Comment 15

[Rail Aliiev [:rail]]

also see https://github.com/mozilla-releng/beetmoverscript/pull/70/files

Comment 16

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Rail Aliiev [:rail] ⌚️ET from comment #15)
> also see https://github.com/mozilla-releng/beetmoverscript/pull/70/files

Yep, thanks for the heads-up!

Comment 17

[Mihai Tabara [:mtabara]⌚️GMT]

Note to self: I'm to send Nick's way the patches for this.

Comment 18

[Nicole Yee (:nicoleyee)]

looks like there's plans for this to land. thanks! just a reminder that soft code freeze is the 31st :)

Comment 19

[Mihai Tabara [:mtabara]⌚️GMT]

Will get my hands on this in the next 24-48h. Incoming patches will go to :nthomas's plate for review. I hope ETA will be EOW.

Comment 20

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1372260 - change stub installer to Firefox Installer. . a=release DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/159522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159522/

Comment 21

[Mihai Tabara [:mtabara]⌚️GMT]

The changes above reflect https://bugzilla.mozilla.org/show_bug.cgi?id=1372260#c1 and are to be uplifted to beta after landing to central so that they catch the next beta12 on Monday as a good testing roundtrip.

@Romain: do we want the the same consistency in nightlies as well, e.g. "firefox-56.0a1.en-US.win32.installer-stub.exe" => "Firefox Installer.exe" or can we ignore this? 

FWIW, we have high hopes to switch to TC Tier-1 before the merge on 2nd of August so that implies changes to:
i) https://github.com/mozilla-releng/beetmoverscript/blob/master/beetmoverscript/templates/firefox_nightly.yml#L185
ii) https://github.com/mozilla-releng/beetmoverscript/blob/master/beetmoverscript/templates/firefox_nightly_repacks.yml#L69

If for some reason we don't make it to the deadline and we'd still relay on BB, it'd be a build change most likely, :Callek suggested https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/package-name.mk#58. 

But I suspect this targets 55, hence current beta and soon-to-be 55 release.

Comment 22

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8888549 [details]
Bug 1372260 - change stub installer to Firefox Installer. . a=release DONTBUILD

https://reviewboard.mozilla.org/r/159522/#review164990

Comment 23

[Mihai Tabara [:mtabara]⌚️GMT]

CC'ing whimboo for these changes, FYI we're changing the stub installer name from "Firefox Setup Step $VERSION.exe" as "Firefox Installer.exe". Please let me know if there are any concerns before landing these.

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mihai, we don't use the stub installer for automation, but mozdownload (https://github.com/mozilla/mozdownload/) supports it. So this tool might need an update. If you can check that and file an issue that would be great. Thanks.

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f9825759106
change stub installer to Firefox Installer. r=nthomas. a=release DONTBUILD

Comment 26

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8888549 [details]
Bug 1372260 - change stub installer to Firefox Installer. . a=release DONTBUILD

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f982575910610a111df61783db775661f421d79

https://hg.mozilla.org/releases/mozilla-beta/rev/73a5be6013ce71f8ef17792215e4060b4069874a

Comment 27

[Mihai Tabara [:mtabara]⌚️GMT]

Landed on inbound and uplifted to beta.
Awaiting the 55.0b12 to confirm everything is working properly before closing this bug.

Question from https://bugzilla.mozilla.org/show_bug.cgi?id=1372260#c21 for Romain still stands. If we want the same consistency over nightlies, we can flip that very easily too.

Comment 28

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0f9825759106

Comment 29

[Romain Testard [:RT]]

> Question from https://bugzilla.mozilla.org/show_bug.cgi?id=1372260#c21 for
> Romain still stands. If we want the same consistency over nightlies, we can
> flip that very easily too.
Consistency over nightlies sounds good, please let me know if you want me to open a separate bug for this if it cannot be addressed here.
Also, just for information we'll soon default stub installs for eligible environments to 64 bit Firefox - I'm unsure if it matters or not but since the file name mentions the Firefox architecture I just wanted to make sure there won't be problems with 64 bit installs.

Comment 30

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Romain Testard [:RT_out until July 21st] from comment #29)
> Consistency over nightlies sounds good, please let me know if you want me to
> open a separate bug for this if it cannot be addressed here.

We can address it here, no need to file another bug.

> Also, just for information we'll soon default stub installs for eligible
> environments to 64 bit Firefox - I'm unsure if it matters or not but since
> the file name mentions the Firefox architecture I just wanted to make sure
> there won't be problems with 64 bit installs.

Hm, actually this raises a good question. 
Changing the artifact name in nightlies is straightforward and can be done quickly. 
The only problem is, the l10n artifact naming overlap.

So for example, say we change the stub installer name, which currently is "firefox-56.0a1.en-US.win32.installer-stub.exe" to "Firefox Installer.exe". Again, for en-US is fine as the artifact would live under these destinations:

- {{ upload_date }}-{{ branch }}/firefox-{{ version }}.{{ locale }}.{{ platform }}.installer-stub.exe
- latest-{{ branch }}/firefox-{{ version }}.{{ locale }}.{{ platform }}.installer-stub.exe
- latest-{{ branch }}-l10n/firefox-{{ version }}.{{ locale }}.{{ platform }}.installer-stub.exe

But for l10n, the things would get ugly as all of the stub installers live under the same subdirectory: (e.g. under http://archive.mozilla.org/pub/firefox/nightly/2017/07/2017-07-24-03-02-04-mozilla-central-l10n/ there is:

firefox-56.0a1.an.win32.installer-stub.exe
firefox-56.0a1.ast.win32.installer-stub.exe
....

If we rename this to "Firefox Installer.exe" the files would just overlap and get overwritten.

There's two possible solutions to this:
1. We keep the format but slightly adjust it to "Firefox Installer.{locale_code}.exe" to avoid artifacts overlapping.

Plus: easy to do
Minus: not quite 100% consistency with beta/release

2. We reorganize our subidrs from http://archive.mozilla.org/pub/firefox/nightly/ to reflect the way they are organized under http://archive.mozilla.org/pub/firefox/{candidates,releases}

Plus: we'd keep the consistency and have all stub installers named "Firefox Installer.exe"
Minuses: 
* not trivial to do as it implies to revisit all our artifact destinations
* there's lots of tooling down the stream that consume and scrape our artifacts; we got bitten in the past whenever we slightly changed the location of an artifact

@Romain: what do you think?

Comment 31

[Romain Testard [:RT]]

So my understanding is that we're good with beta and release but the problem mentioned here only affects nightly.
I'd go with (1) for nightly given there are very few new installs and the benefits on nightly aren't actually not that huge so not worth the effort and risk of causing further issues down the line.

Comment 32

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Romain Testard [:RT] from comment #31)
> So my understanding is that we're good with beta and release but the problem
> mentioned here only affects nightly.

That is correct. Well, the code is on beta only now but since we'll be merging this to release next Monday, it'll get there in time for 55 too so yes, all good from beta/release standpoint.

For 55.0b12 which ships today you can see the renamed stub installers in each of the locale folders. E.g. for "ar" locale, the stub installer is now https://archive.mozilla.org/pub/firefox/candidates/55.0b12-candidates/build1/win32/ar/Firefox%20Installer.exe

> I'd go with (1) for nightly given there are very few new installs and the
> benefits on nightly aren't actually not that huge so not worth the effort
> and risk of causing further issues down the line.

Sounds good, I'll follow-up with a PR in a second to change those too.

Comment 33

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1372260 - change stub installer filename in nightlies to Firefox Installer.{locale}.exe

Comment 34

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8889841 [details] [review]
Bug 1372260 - change stub installer filename in nightlies to Firefox Installer.{locale}.exe

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #33)
> Created attachment 8889841 [details] [review]
> Bug 1372260 - change stub installer filename in nightlies to Firefox
> Installer.{locale}.exe

Bug 1372260 - bump beetmoverscript in beetmoverworker. r=versionbump 
https://hg.mozilla.org/build/puppet/rev/d82a746838b1
https://hg.mozilla.org/build/puppet/rev/ef5385529161

All beetmoverworkers updated.

Comment 35

[Mihai Tabara [:mtabara]⌚️GMT]

I think we're done here, we can close this bug.

To sum-up:

i) beta and release will now have "Firefox Installer.exe" as the stub installer. See sample for 55.0b12 - https://archive.mozilla.org/pub/firefox/candidates/55.0b12-candidates/build1/win32/ar/Firefox%20Installer.exe

ii) nightlies will have "Firefox Installer.{locale_code}.exe".See sample:
http://archive.mozilla.org/pub/firefox/nightly/latest-date-l10n/Firefox%20Installer.an.exe
http://archive.mozilla.org/pub/firefox/nightly/2017/07/2017-07-24-15-05-27-date-l10n/Firefox%20Installer.an.exe

Please feel free to reopen if I missed anything.

Comment 36

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Henrik Skupin (:whimboo) [away 07/19 - 07/31] from comment #24)
> Mihai, we don't use the stub installer for automation, but mozdownload
> (https://github.com/mozilla/mozdownload/) supports it. So this tool might
> need an update. If you can check that and file an issue that would be great.
> Thanks.

Mihai, did you have a chance to do this ?

Comment 37

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Nick Thomas [:nthomas] from comment #36)
> (In reply to Henrik Skupin (:whimboo) [away 07/19 - 07/31] from comment #24)
> > Mihai, we don't use the stub installer for automation, but mozdownload
> > (https://github.com/mozilla/mozdownload/) supports it. So this tool might
> > need an update. If you can check that and file an issue that would be great.
> > Thanks.
> 
> Mihai, did you have a chance to do this ?

Thanks for the heads-up.
Did that now - https://github.com/mozilla/mozdownload/issues/440

Comment 38

[Mihai Tabara [:mtabara]⌚️GMT]

Haven't heard any complains on this yet.
Stub installers look good both on beta and nightly.
The code will ride the trains to release as well next week so we should be good.