Closed Bug 1372260 Opened 2 years ago Closed 2 years ago

Change stub installer file name to "Firefox Installer"

Categories

(Release Engineering :: Release Automation: Other, enhancement, P1)

All
Windows
enhancement

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: RT, Assigned: mtabara)

References

(Blocks 1 open bug)

Details

User Story

Per bug 1328445 we ship a streamlined stub installer with FF55 as part of the new onboarding experience. Part of the requirements for the streamlined stub installer is to change the file name to make it more user friendly since this tested well during funnelcake experiments.

Acceptance criteria:
- Stub installer file name changed to "Firefox Installer"

Attachments

(2 files)

No description provided.
User Story: (updated)
Blocks: 1367070
Priority: -- → P3
i) Comment 1 reflects reality for beta and release.

ii) For nightly, there's nothing to change in tcmigration as we don't have Windows yet enabled in Taskcluster (at least, not at beetmover level). So most likely the current nightly stub installers (such as http://archive.mozilla.org/pub/firefox/nightly/2017/06/2017-06-02-03-02-04-mozilla-central/firefox-55.0a1.en-US.win32.installer-stub.exe for example) come from BB. It'd be a build change most likely, :Callek suggested https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/package-name.mk#58.
Chris, could this be implemented by the time FF55 hits release?
This is part of the new onboarding requirements and the streamlined stub that comes along with this ships in release 55.
We believe this can have significant impact on the "Open stub installer" / "Download stub installer" ratio, which itself is critical to a good onboarding.
Flags: needinfo?(catlee)
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #1)
> At bare minimum, we need to change:

I think you summarized it properly. We also may need to let mozdowloader people know about these changes.
Component: General → Release Automation
QA Contact: catlee
Yeah, I think we can get this done in the 55 Beta cycle.

Just to be clear, the proposal is to rename "Firefox Setup Step $VERSION.exe" as "Firefox Installer.exe".?

Is there any need to rename the full installer? It's currently named "Firefox Setup $VERSION.exe"

Julien, is this something we can take on 55?
Flags: needinfo?(rtestard)
Flags: needinfo?(jcristau)
Flags: needinfo?(catlee)
(In reply to Chris AtLee [:catlee] from comment #5)
> Yeah, I think we can get this done in the 55 Beta cycle.
> 
> Just to be clear, the proposal is to rename "Firefox Setup Step
> $VERSION.exe" as "Firefox Installer.exe".?
Yes
> 
> Is there any need to rename the full installer? It's currently named
> "Firefox Setup $VERSION.exe"
Not at this point. We only care about the stub installer since it's what get used on the new onboarding experience.
The audience for full installers is very different and the naming in place currently may not need changing.
Flags: needinfo?(rtestard)
Matt, do you know of anything that would care about the file name of the stub installer and that might break if we change it?
Flags: needinfo?(jcristau) → needinfo?(mhowell)
I don't know of anything that depends on that file name.
Flags: needinfo?(mhowell)
OK, sounds like something we can still do in 55 then.
For info we just got the final funnelcake results where this was tested and the improvements have been quite significant regarding the "install attempt"/"download events" ratio (7% improvement). 
It would be good to see that improvement translate on the release installs for 55.
Also is a separate bug required to implement the same change on Beta or should this bug cover it too?
Flags: needinfo?(rail)
The change should just ride the trains, nothing special for beta/release.

Mihai, can you look at this please.
Flags: needinfo?(rail) → needinfo?(mtabara)
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #11)
> The change should just ride the trains, nothing special for beta/release.
> 
> Mihai, can you look at this please.

We will need to uplift this to Beta (55).
I completely out of date with our versioning :D
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #11)
> The change should just ride the trains, nothing special for beta/release.
> 
> Mihai, can you look at this please.

Yes, of course! Am PTO this week but will grab this over the week-end/next week.
Assignee: nobody → mtabara
Flags: needinfo?(mtabara)
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #15)
> also see https://github.com/mozilla-releng/beetmoverscript/pull/70/files

Yep, thanks for the heads-up!
Note to self: I'm to send Nick's way the patches for this.
looks like there's plans for this to land. thanks! just a reminder that soft code freeze is the 31st :)
Will get my hands on this in the next 24-48h. Incoming patches will go to :nthomas's plate for review. I hope ETA will be EOW.
Priority: P3 → P1
The changes above reflect https://bugzilla.mozilla.org/show_bug.cgi?id=1372260#c1 and are to be uplifted to beta after landing to central so that they catch the next beta12 on Monday as a good testing roundtrip.

@Romain: do we want the the same consistency in nightlies as well, e.g. "firefox-56.0a1.en-US.win32.installer-stub.exe" => "Firefox Installer.exe" or can we ignore this? 

FWIW, we have high hopes to switch to TC Tier-1 before the merge on 2nd of August so that implies changes to:
i) https://github.com/mozilla-releng/beetmoverscript/blob/master/beetmoverscript/templates/firefox_nightly.yml#L185
ii) https://github.com/mozilla-releng/beetmoverscript/blob/master/beetmoverscript/templates/firefox_nightly_repacks.yml#L69

If for some reason we don't make it to the deadline and we'd still relay on BB, it'd be a build change most likely, :Callek suggested https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/package-name.mk#58. 

But I suspect this targets 55, hence current beta and soon-to-be 55 release.
Flags: needinfo?(rtestard)
Comment on attachment 8888549 [details]
Bug 1372260 - change stub installer to Firefox Installer. . a=release DONTBUILD

https://reviewboard.mozilla.org/r/159522/#review164990
Attachment #8888549 - Flags: review?(nthomas) → review+
CC'ing whimboo for these changes, FYI we're changing the stub installer name from "Firefox Setup Step $VERSION.exe" as "Firefox Installer.exe". Please let me know if there are any concerns before landing these.
Status: NEW → ASSIGNED
Flags: needinfo?(hskupin)
See Also: → 1379261
Mihai, we don't use the stub installer for automation, but mozdownload (https://github.com/mozilla/mozdownload/) supports it. So this tool might need an update. If you can check that and file an issue that would be great. Thanks.
Flags: needinfo?(hskupin)
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f9825759106
change stub installer to Firefox Installer. r=nthomas. a=release DONTBUILD
Landed on inbound and uplifted to beta.
Awaiting the 55.0b12 to confirm everything is working properly before closing this bug.

Question from https://bugzilla.mozilla.org/show_bug.cgi?id=1372260#c21 for Romain still stands. If we want the same consistency over nightlies, we can flip that very easily too.
Keywords: leave-open
> Question from https://bugzilla.mozilla.org/show_bug.cgi?id=1372260#c21 for
> Romain still stands. If we want the same consistency over nightlies, we can
> flip that very easily too.
Consistency over nightlies sounds good, please let me know if you want me to open a separate bug for this if it cannot be addressed here.
Also, just for information we'll soon default stub installs for eligible environments to 64 bit Firefox - I'm unsure if it matters or not but since the file name mentions the Firefox architecture I just wanted to make sure there won't be problems with 64 bit installs.
Flags: needinfo?(rtestard)
(In reply to Romain Testard [:RT_out until July 21st] from comment #29)
> Consistency over nightlies sounds good, please let me know if you want me to
> open a separate bug for this if it cannot be addressed here.

We can address it here, no need to file another bug.

> Also, just for information we'll soon default stub installs for eligible
> environments to 64 bit Firefox - I'm unsure if it matters or not but since
> the file name mentions the Firefox architecture I just wanted to make sure
> there won't be problems with 64 bit installs.

Hm, actually this raises a good question. 
Changing the artifact name in nightlies is straightforward and can be done quickly. 
The only problem is, the l10n artifact naming overlap.

So for example, say we change the stub installer name, which currently is "firefox-56.0a1.en-US.win32.installer-stub.exe" to "Firefox Installer.exe". Again, for en-US is fine as the artifact would live under these destinations:

- {{ upload_date }}-{{ branch }}/firefox-{{ version }}.{{ locale }}.{{ platform }}.installer-stub.exe
- latest-{{ branch }}/firefox-{{ version }}.{{ locale }}.{{ platform }}.installer-stub.exe
- latest-{{ branch }}-l10n/firefox-{{ version }}.{{ locale }}.{{ platform }}.installer-stub.exe

But for l10n, the things would get ugly as all of the stub installers live under the same subdirectory: (e.g. under http://archive.mozilla.org/pub/firefox/nightly/2017/07/2017-07-24-03-02-04-mozilla-central-l10n/ there is:

firefox-56.0a1.an.win32.installer-stub.exe
firefox-56.0a1.ast.win32.installer-stub.exe
....

If we rename this to "Firefox Installer.exe" the files would just overlap and get overwritten.

There's two possible solutions to this:
1. We keep the format but slightly adjust it to "Firefox Installer.{locale_code}.exe" to avoid artifacts overlapping.

Plus: easy to do
Minus: not quite 100% consistency with beta/release

2. We reorganize our subidrs from http://archive.mozilla.org/pub/firefox/nightly/ to reflect the way they are organized under http://archive.mozilla.org/pub/firefox/{candidates,releases}

Plus: we'd keep the consistency and have all stub installers named "Firefox Installer.exe"
Minuses: 
* not trivial to do as it implies to revisit all our artifact destinations
* there's lots of tooling down the stream that consume and scrape our artifacts; we got bitten in the past whenever we slightly changed the location of an artifact

@Romain: what do you think?
Flags: needinfo?(rtestard)
So my understanding is that we're good with beta and release but the problem mentioned here only affects nightly.
I'd go with (1) for nightly given there are very few new installs and the benefits on nightly aren't actually not that huge so not worth the effort and risk of causing further issues down the line.
Flags: needinfo?(rtestard)
(In reply to Romain Testard [:RT] from comment #31)
> So my understanding is that we're good with beta and release but the problem
> mentioned here only affects nightly.

That is correct. Well, the code is on beta only now but since we'll be merging this to release next Monday, it'll get there in time for 55 too so yes, all good from beta/release standpoint.

For 55.0b12 which ships today you can see the renamed stub installers in each of the locale folders. E.g. for "ar" locale, the stub installer is now https://archive.mozilla.org/pub/firefox/candidates/55.0b12-candidates/build1/win32/ar/Firefox%20Installer.exe

> I'd go with (1) for nightly given there are very few new installs and the
> benefits on nightly aren't actually not that huge so not worth the effort
> and risk of causing further issues down the line.

Sounds good, I'll follow-up with a PR in a second to change those too.
Attachment #8889841 - Flags: review?(jlorenzo) → review+
Comment on attachment 8889841 [details] [review]
Bug 1372260 - change stub installer filename in nightlies to Firefox Installer.{locale}.exe

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #33)
> Created attachment 8889841 [details] [review]
> Bug 1372260 - change stub installer filename in nightlies to Firefox
> Installer.{locale}.exe

Bug 1372260 - bump beetmoverscript in beetmoverworker. r=versionbump 
https://hg.mozilla.org/build/puppet/rev/d82a746838b1
https://hg.mozilla.org/build/puppet/rev/ef5385529161

All beetmoverworkers updated.
Attachment #8889841 - Flags: checked-in+
I think we're done here, we can close this bug.

To sum-up:

i) beta and release will now have "Firefox Installer.exe" as the stub installer. See sample for 55.0b12 - https://archive.mozilla.org/pub/firefox/candidates/55.0b12-candidates/build1/win32/ar/Firefox%20Installer.exe

ii) nightlies will have "Firefox Installer.{locale_code}.exe".See sample:
http://archive.mozilla.org/pub/firefox/nightly/latest-date-l10n/Firefox%20Installer.an.exe
http://archive.mozilla.org/pub/firefox/nightly/2017/07/2017-07-24-15-05-27-date-l10n/Firefox%20Installer.an.exe

Please feel free to reopen if I missed anything.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
(In reply to Henrik Skupin (:whimboo) [away 07/19 - 07/31] from comment #24)
> Mihai, we don't use the stub installer for automation, but mozdownload
> (https://github.com/mozilla/mozdownload/) supports it. So this tool might
> need an update. If you can check that and file an issue that would be great.
> Thanks.

Mihai, did you have a chance to do this ?
(In reply to Nick Thomas [:nthomas] from comment #36)
> (In reply to Henrik Skupin (:whimboo) [away 07/19 - 07/31] from comment #24)
> > Mihai, we don't use the stub installer for automation, but mozdownload
> > (https://github.com/mozilla/mozdownload/) supports it. So this tool might
> > need an update. If you can check that and file an issue that would be great.
> > Thanks.
> 
> Mihai, did you have a chance to do this ?

Thanks for the heads-up.
Did that now - https://github.com/mozilla/mozdownload/issues/440
Haven't heard any complains on this yet.
Stub installers look good both on beta and nightly.
The code will ride the trains to release as well next week so we should be good.
Status: RESOLVED → VERIFIED
See Also: → 1387021
You need to log in before you can comment on or make changes to this bug.