Closed
Bug 1379261
Opened 7 years ago
Closed 7 years ago
release promotion changes for TC mac and win builds
Categories
(Release Engineering :: Release Automation: Other, enhancement)
Release Engineering
Release Automation: Other
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: rail, Assigned: rail)
References
Details
Attachments
(7 files, 5 obsolete files)
59 bytes,
text/x-review-board-request
|
jlorenzo
:
review+
rail
:
checked-in+
|
Details |
6.67 KB,
patch
|
mozilla
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
1.08 KB,
patch
|
Callek
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
1.41 KB,
patch
|
mozilla
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
55 bytes,
patch
|
mtabara
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
11.16 KB,
patch
|
mtabara
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
15.18 KB,
patch
|
mtabara
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
This is a bare minimum that I need to land in order to test other patches on jamun. There will be more after I'm done.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8884820 [details] Bug 1379261 - release promotion changes for TC mac and win builds https://reviewboard.mozilla.org/r/155698/#review160710 LGTM module the nits on "repackage". ::: mozilla/config.py:2179 (Diff revision 1) > "unsigned": "gecko.v2.mozilla-release.revision.{rev}.firefox.macosx64-opt", > + "ci_system": "bb", > + # Uncomment when TC is tier-1 > + # "ci_system": "tc", > + # "repacakge": "gecko.v2.mozilla-release.revision.{rev}.firefox-l10n.macosx64-nightly-repackage.en-US", > + # "repacakge-signing": "gecko.v2.mozilla-release.revision.{rev}.firefox-l10n.macosx64-nightly-repackage-signing.en-US", Nit: `repackage` and `repackage-signing`. Same comment applies to the lines below and to the other files.
Attachment #8884820 -
Flags: review?(jlorenzo) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8884820 [details] Bug 1379261 - release promotion changes for TC mac and win builds https://hg.mozilla.org/build/buildbot-configs/rev/5609b214c0e58d299f9e97795219355587b58953
Attachment #8884820 -
Flags: checked-in+
Assignee | ||
Comment 5•7 years ago
|
||
Putting the patches together before I start testing them...
Assignee | ||
Comment 6•7 years ago
|
||
In-tree Beetmover config changes. Splitting things into 4 (vs 2) tasks.
Assignee | ||
Comment 7•7 years ago
|
||
Assignee | ||
Comment 8•7 years ago
|
||
and https://github.com/mozilla-releng/releasetasks/compare/master...rail:tier1?expand=1
Assignee | ||
Comment 10•7 years ago
|
||
Attachment #8886252 -
Flags: review?
Updated•7 years ago
|
Attachment #8886252 -
Flags: review? → review+
Assignee | ||
Comment 11•7 years ago
|
||
Comment on attachment 8886252 [details] [diff] [review] update-routes.diff remote: https://hg.mozilla.org/build/buildbot-configs/rev/efb48acf7ed628d12046275577cf9fee3e3f244f remote: https://hg.mozilla.org/build/buildbot-configs/rev/553e45492857314818c6599c76ab0a39bcb766bb
Attachment #8886252 -
Flags: checked-in+
Updated•7 years ago
|
Attachment #8886293 -
Flags: review? → review+
Assignee | ||
Comment 13•7 years ago
|
||
Comment on attachment 8886293 [details] [diff] [review] jamun-signing.diff https://hg.mozilla.org/build/buildbot-configs/rev/588e922ab919d8e9872a9faec18fa8ec05d89d85
Attachment #8886293 -
Flags: checked-in+
Assignee | ||
Comment 14•7 years ago
|
||
Attachment #8886227 -
Attachment is obsolete: true
Comment 15•7 years ago
|
||
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #13) > Comment on attachment 8886293 [details] [diff] [review] > jamun-signing.diff > > https://hg.mozilla.org/build/buildbot-configs/rev/ > 588e922ab919d8e9872a9faec18fa8ec05d89d85 Merged to prod - https://hg.mozilla.org/build/buildbot-configs/rev/8b4445eb311e.
Assignee | ||
Comment 16•7 years ago
|
||
I also pushed https://hg.mozilla.org/build/buildbot-configs/rev/d2ac6abf8f2e32052e162452194fc4545c520328: windows has nothing in repackage.
Assignee | ||
Comment 17•7 years ago
|
||
Attachment #8886359 -
Attachment is obsolete: true
Assignee | ||
Comment 18•7 years ago
|
||
Attachment #8886228 -
Attachment is obsolete: true
Assignee | ||
Comment 19•7 years ago
|
||
Attachment #8887627 -
Flags: review?(aki)
Updated•7 years ago
|
Attachment #8887627 -
Flags: review?(aki) → review+
Assignee | ||
Comment 20•7 years ago
|
||
Comment on attachment 8887627 [details] [diff] [review] buildbot-configs: Enable release signing on jamun https://hg.mozilla.org/build/buildbot-configs/rev/75853960369c215f1fff285f3d11edc12bd1a694
Attachment #8887627 -
Flags: checked-in+
Assignee | ||
Comment 21•7 years ago
|
||
Attachment #8887935 -
Flags: review?(mtabara)
Assignee | ||
Comment 22•7 years ago
|
||
Attachment #8887597 -
Attachment is obsolete: true
Attachment #8887936 -
Flags: review?(mtabara)
Updated•7 years ago
|
Attachment #8887935 -
Attachment is patch: true
Attachment #8887935 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8887935 -
Flags: review?(mtabara) → review+
Comment 23•7 years ago
|
||
Comment on attachment 8887936 [details] [diff] [review] release-runner changes Review of attachment 8887936 [details] [diff] [review]: ----------------------------------------------------------------- ::: lib/python/kickoff/__init__.py @@ +166,5 @@ > + taskid=unsigned_task["taskId"] > + ) > + if platform.startswith("mac"): > + # FIXME: dirty dirty hack > + mar_tools_url = "https://archive.mozilla.org/pub/firefox/nightly/2017/06/2017-06-21-03-02-08-mozilla-central" This looks indeed suspicious. How long are we planning to keep this hack?
Attachment #8887936 -
Flags: review?(mtabara) → review+
Assignee | ||
Comment 24•7 years ago
|
||
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #23) > > + if platform.startswith("mac"): > > + # FIXME: dirty dirty hack > > + mar_tools_url = "https://archive.mozilla.org/pub/firefox/nightly/2017/06/2017-06-21-03-02-08-mozilla-central" > > This looks indeed suspicious. How long are we planning to keep this hack? This is bug 1381495 :/
Assignee | ||
Updated•7 years ago
|
Attachment #8887935 -
Flags: checked-in+
Assignee | ||
Comment 25•7 years ago
|
||
Comment on attachment 8887936 [details] [diff] [review] release-runner changes https://hg.mozilla.org/build/tools/rev/077a4adc87dc6c02665e21c68ac9974eb866990e
Attachment #8887936 -
Flags: checked-in+
Assignee | ||
Comment 26•7 years ago
|
||
Deployed. The only remaining patch is the gecko patch.
Assignee | ||
Comment 27•7 years ago
|
||
Comment on attachment 8887596 [details] [diff] [review] gecko: beetmover configs We will need to update this after bug 1372260 lands
Comment 28•7 years ago
|
||
(In reply to Rail Aliiev [:rail] ⌚️ET - PTO in August from comment #27) > Comment on attachment 8887596 [details] [diff] [review] > gecko: beetmover configs > > We will need to update this after bug 1372260 lands Uplifted + adjusted for jamun (change also in repackage) https://hg.mozilla.org/projects/jamun/rev/de332d82d056efa1396012a11e56062ff6c27ca1
Assignee | ||
Comment 29•7 years ago
|
||
Refreshed, with stub installer renamed.
Attachment #8887596 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8889510 -
Flags: review?(mtabara)
Comment 30•7 years ago
|
||
Comment on attachment 8889510 [details] [diff] [review] gecko: beetmover configs Looks good to me, assuming I got this right :)
Attachment #8889510 -
Flags: review?(mtabara) → review+
Comment 31•7 years ago
|
||
Pushed by raliiev@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8f72d0cb7441 Update release promotion beetmover manifests r=mtabara DONTBUILD
Comment 32•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8f72d0cb7441
You need to log in
before you can comment on or make changes to this bug.
Description
•