1372409 - Webrender can get stuck in a compositing loop

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Markus Stange [:mstange]]

Steps to reproduce:
 1. Enable webrender, webrendest and the webrender profiler.
 2. Go to https://bugzilla.mozilla.org/show_bug.cgi?id=1372299
 3. In one swift motion, move your mouse over the link to the first attachment and click it.

Expected results:
As soon as the new page has loaded, we should stop compositing and the profiler overlay should come to a rest.

Actual results:
We keep compositing at 60fps, forever.


This does not happen if I rest my mouse on the link for a bit before I click the link.

I think this somehow has to do with the link target overlay in the bottom left corner of the window. It animates in and out as your mouse moves over links. If you click a link, maybe the animation is aborted before it's completed, and that causes us to think that there is still an animation running?

Comment 1

[Sotaro Ikeda [:sotaro]]

I could reproduce the problem.

Comment 2

[Peter Chang[:pchang]]

Looks like this is related to OMTA. The high cpu usage was gone after change gfx.webrender.omta.enabled as 0.

Comment 3

[Sotaro Ikeda [:sotaro]]

There were 2 causes of this bug.
[1] There is a case that no new transaction from WebRenderLayerManager. 
      DiscardCompositorAnimations() is called in the beginning of WebRenderLayerManager::EndTransactionInternal()
[2] At WebRenderBridgeParent, TOpAddCompositorAnimations was received after the animation removal.
      The TOpAddCompositorAnimations was added during EmptyTransaction.
      But the transaction was aborted by TransactionIncomplete. After that, the animation was removed.
      Then WebRenderLayerManager did a new EndTransaction(), it triggered to send the TOpAddCompositorAnimations.

Comment 4

[Sotaro Ikeda [:sotaro]]

Bug 1372816 handles [2].

Comment 5

[Sotaro Ikeda [:sotaro]]

I did not see [1], since Bug 1372816 was addressed.

Comment 6

[Sotaro Ikeda [:sotaro]]

:mstange, can you confirm if this bug is fixed?

Comment 7

[Markus Stange [:mstange]]

I can no longer reproduce this bug. Looks like it's fixed, thanks!