Closed Bug 1372489 Opened 4 years ago Closed 4 years ago

Update GLConsts.h and GLDefs.h

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jerry, Assigned: jerry)

References

Details

Attachments

(1 file, 1 obsolete file)

The d3d11 nv12 format needs some newer def values. Update the GLConsts.h and GLDefs.h here.

The ANGLE_stream_producer_d3d_texture_nv12 and ANGLE_keyed_mutex extension are not exist in egl.xml, so add the "LOCAL_EGL_DXGI_KEYED_MUTEX_ANGLE" and "LOCAL_EGL_D3D_TEXTURE_SUBRESOURCE_ID_ANGLE" manually in GLDefs.h.

egl
https://github.com/KhronosGroup/EGL-Registry/commit/2e6e7ff7bf91d0ffcd7ca297aa2b18977b5e9492
gl, glx and wgl
https://github.com/KhronosGroup/OpenGL-Registry/commit/23a3a95673921d4bf99001a0c50ef2ac2850dcf1
Attached patch Update GLConsts.h and GLDefs.h. (obsolete) — Splinter Review
Get the latest gl.xml, egl.xml, wgl.xml and glx.xml.
Then, execute the |GLParseRegistryXML.py|. Please check the details in |GLParseRegistryXML.py|.

The ANGLE_stream_producer_d3d_texture_nv12 and ANGLE_keyed_mutex extension are not exist in egl.xml,
so add the "LOCAL_EGL_DXGI_KEYED_MUTEX_ANGLE" and "LOCAL_EGL_D3D_TEXTURE_SUBRESOURCE_ID_ANGLE" manually in GLDefs.h.

egl:
https://github.com/KhronosGroup/EGL-Registry/commit/2e6e7ff7bf91d0ffcd7ca297aa2b18977b5e9492
gl, glx and wgl:
https://github.com/KhronosGroup/OpenGL-Registry/commit/23a3a95673921d4bf99001a0c50ef2ac2850dcf1

MozReview-Commit-ID: nUVJix5HZp
Attachment #8877016 - Flags: review?(jgilbert)
Blocks: 1372490
Attachment #8877016 - Flags: review?(jgilbert) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/62a77d29f27f
Update GLConsts.h and GLDefs.h. r=jgilbert
Keywords: checkin-needed
Attachment #8877016 - Attachment is obsolete: true
Attachment #8877877 - Attachment description: Fix the typo for EGL_DXGI_KEYED_MUTEX_ANGLE value. → Update GLConsts.h and GLDefs.h. v2. r=jgilbert
Pushed by hshih@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7b4774740d7
Update GLConsts.h and GLDefs.h. r=jgilbert.
https://hg.mozilla.org/mozilla-central/rev/a7b4774740d7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.