Closed
Bug 1372489
Opened 7 years ago
Closed 7 years ago
Update GLConsts.h and GLDefs.h
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: jerry, Assigned: jerry)
References
Details
Attachments
(1 file, 1 obsolete file)
|
281.37 KB,
patch
|
jerry
:
review+
|
Details | Diff | Splinter Review |
The d3d11 nv12 format needs some newer def values. Update the GLConsts.h and GLDefs.h here. The ANGLE_stream_producer_d3d_texture_nv12 and ANGLE_keyed_mutex extension are not exist in egl.xml, so add the "LOCAL_EGL_DXGI_KEYED_MUTEX_ANGLE" and "LOCAL_EGL_D3D_TEXTURE_SUBRESOURCE_ID_ANGLE" manually in GLDefs.h. egl https://github.com/KhronosGroup/EGL-Registry/commit/2e6e7ff7bf91d0ffcd7ca297aa2b18977b5e9492 gl, glx and wgl https://github.com/KhronosGroup/OpenGL-Registry/commit/23a3a95673921d4bf99001a0c50ef2ac2850dcf1
|
Assignee | |
Comment 1•7 years ago
|
||
Get the latest gl.xml, egl.xml, wgl.xml and glx.xml. Then, execute the |GLParseRegistryXML.py|. Please check the details in |GLParseRegistryXML.py|. The ANGLE_stream_producer_d3d_texture_nv12 and ANGLE_keyed_mutex extension are not exist in egl.xml, so add the "LOCAL_EGL_DXGI_KEYED_MUTEX_ANGLE" and "LOCAL_EGL_D3D_TEXTURE_SUBRESOURCE_ID_ANGLE" manually in GLDefs.h. egl: https://github.com/KhronosGroup/EGL-Registry/commit/2e6e7ff7bf91d0ffcd7ca297aa2b18977b5e9492 gl, glx and wgl: https://github.com/KhronosGroup/OpenGL-Registry/commit/23a3a95673921d4bf99001a0c50ef2ac2850dcf1 MozReview-Commit-ID: nUVJix5HZp
Attachment #8877016 -
Flags: review?(jgilbert)
|
||
Updated•7 years ago
|
Attachment #8877016 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/62a77d29f27f Update GLConsts.h and GLDefs.h. r=jgilbert
Keywords: checkin-needed
|
||
Comment 3•7 years ago
|
||
Backed out in https://hg.mozilla.org/integration/autoland/rev/6010f4b0f4fd - reftests, https://treeherder.mozilla.org/logviewer.html#?job_id=106899594&repo=autoland and mochitests, https://treeherder.mozilla.org/logviewer.html#?job_id=106899851&repo=autoland
|
|
Assignee | |
Comment 4•7 years ago
|
||
Attachment #8877877 -
Flags: review+
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8877016 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8877877 -
Attachment description: Fix the typo for EGL_DXGI_KEYED_MUTEX_ANGLE value. → Update GLConsts.h and GLDefs.h. v2. r=jgilbert
|
|
Assignee | |
Comment 5•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8823cd447d7009725f58f98addd26b5684b649a0&selectedJob=107219868 The gl_context_lost related fails are covered in Bug 1372490.
Pushed by hshih@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a7b4774740d7 Update GLConsts.h and GLDefs.h. r=jgilbert.
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a7b4774740d7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•