1372490 - GetError() returns GL_CONTEXT_LOST not GL_CONTEXT_LOST_WEBGL

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

It should be GL_CONTEXT_LOST_WEBGL instead of GL_CONTEXT_LOST.


From:
https://www.khronos.org/registry/webgl/specs/latest/1.0/

[WebGLHandlesContextLoss] GLenum getError() (OpenGL ES 2.0 §2.5, man page)
    If the context's webgl context lost flag is set, returns CONTEXT_LOST_WEBGL the first time this method is called. Afterward, returns NO_ERROR until the context has been restored.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Fix the wrong return value for webgl context-lost.

MozReview-Commit-ID: KYr0cKoeWJo

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8877017 [details] [diff] [review]
Fix the wrong return value for webgl context-lost.

Review of attachment 8877017 [details] [diff] [review]:
-----------------------------------------------------------------

This is the same value, just technically different names. We have a history of omitting the vendor suffix where possible, which is what we do here.

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

From https://raw.githubusercontent.com/KhronosGroup/OpenGL-Registry/master/xml/gl.xml,
the value of GL_CONTEXT_LOST and GL_CONTEXT_LOST_WEBGL are different.

<enum value="0x0507" name="GL_CONTEXT_LOST"/>
<enum value="0x0507" name="GL_CONTEXT_LOST_KHR"/>

<enum value="0x9242" name="GL_CONTEXT_LOST_WEBGL"/>

Comment 4

[Kelsey Gilbert [:jgilbert]]

Ah, I see grep failed me here, because our code was wrong.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8877017 [details] [diff] [review]
Fix the wrong return value for webgl context-lost.

Review of attachment 8877017 [details] [diff] [review]:
-----------------------------------------------------------------

Confirmed that these are different values in the bug this bug depends on.

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6849460769275308fe46cf3eb0cfa38805fda66c

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d3a9cc05519
GetError() returns GL_CONTEXT_LOST not GL_CONTEXT_LOST_WEBGL. r=jgilbert

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0d3a9cc05519