1372500 - delete references to mozilla-aurora code in treeherder

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Description

[Sebastian Pacurar [:spacurar]]

Since mozilla-aurora will not exist anymore, it should be removed from buildbot, taskcluster and treeherder.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think the only thing we'd want to do is mark mozilla-aurora as an onhold repository in https://github.com/mozilla/treeherder/blob/8061296172c80f3e4a186f3d959027f5406bbf4c/treeherder/model/fixtures/repository.json#L59-L71 / https://github.com/mozilla/treeherder/blob/0300fb69bad7223585fd9e9c885b5a159b292221/tests/ui/mock/repositories.json#L45

We can probably drop the reference to aurora in https://github.com/mozilla/treeherder/blob/de4c189c15e5115c6e8a3f51c59932268a95782b/treeherder/model/management/commands/publish_result_set_to_pulse.py#L15 but that's not super important.

A number of tests reference aurora[1], but I'm not sure they actually need to be removed, or if removing them has a possibility of breaking things or reducing code coverage.

Question: What about comm-aurora?


1. https://github.com/mozilla/treeherder/blob/0300fb69bad7223585fd9e9c885b5a159b292221/tests/sample_data/buildbot_text.json#L251
https://github.com/mozilla/treeherder/blob/0300fb69bad7223585fd9e9c885b5a159b292221/tests/ui/mock/job_groups.json#L333
https://github.com/mozilla/treeherder/blob/0300fb69bad7223585fd9e9c885b5a159b292221/tests/sample_data/pulse_consumer/github_push_commits.json#L225
https://github.com/mozilla/treeherder/blob/55650d582dd0b25d212a09c0d2712b711c1562bd/tests/sample_data/resultset_data.json#L92

Comment 2

[Sebastian Pacurar [:spacurar]]

I talked with :bhearsum about comm-aurora. He said that we should leave that as it is for now.
So marking mozilla-aurora as on-hold should do the trick for now. Is there a way for me to test if moving other references might break things?

Comment 3

[Ed Morley [:emorley]]

If you open a PR, the tests will run on Travis and if any fail, you'll know what needs updating :-)

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] spacurar:remove_mozilla-aurora_code > mozilla:master

Comment 5

[Sebastian Pacurar [:spacurar]]

Attachment: Set mozilla-aurora status to onhold in TH

Should I also test if travis works if I remove those test references to mozilla-aurora which :KWierso mentioned here https://bugzilla.mozilla.org/show_bug.cgi?id=1372500#c1 ?

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8879125 [details] [review]
Set mozilla-aurora status to onhold in TH

This is great - thank you :-)
(I'll squash the multiple commits/merges when landing, generally it's recommended to squash them for fixups before opening the PR etc)

> Should I also test if travis works if I remove those test references to
> mozilla-aurora which :KWierso mentioned here
> https://bugzilla.mozilla.org/show_bug.cgi?id=1372500#c1 ?

Those references can stay, they are just random sample data and such.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/58186479d313d37fd5052e8416bfc35523f112b5
Bug 1372500 - Disable the EOL mozilla-aurora repository (#2576)

Comment 8

[Ed Morley [:emorley]]

Thank you for the PR! (It will auto-deploy to stage within 10 minutes, and be manually deployed to prod within the week.)